From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD740C433F5 for ; Mon, 10 Jan 2022 20:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v7p3LTcqdh9nBIHjt2Go8+mWH8IjxH4LHCivV6WUN5I=; b=mQAjWLDfvoySDB RZF6SERalGzx7aTZ2WiyqgKq8Yt3Fp/Ng0XhF1umr5lt0z5QPcXKCAvsqRFKzcGN7uCjZ/4ITCiSS bV7+kjXapSRk2CDoeFnW6OpYNU7RG7kWYbiUI3ojGB0W9shXVj6erab7Jv2+hZsjpmx3vvcyvJ17i 2PYVEGw91mQ3IbEddmynjKOUgB6QpUG4Hptoa4s0zw3P7B4pR4+ixyQREGcX0YDvuFV9tcqil8Qy3 zduMfQgrrUBrZEV7oTeTrCXfpI9M1MCAFK/zd4moj0MpCTlJiQSGYmuaRiNEIirwr1C0RBER5KBzg GbY5+SUsvELiJ3aVIqbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n711U-00DAyw-9g; Mon, 10 Jan 2022 20:12:08 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n711R-00DAxX-44 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 20:12:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2B20CB817E1; Mon, 10 Jan 2022 20:12:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1E37C36AE9; Mon, 10 Jan 2022 20:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641845521; bh=1lf/ELFerWFfOHZ3BPKudqF7I3BLnH/Pps9NEDUeYrk=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=ITvSF+sawCB0+JHKmRu1WmUCj1uknYVJCZGVCjOto/T71DioD4j4dtQlmo13kNI4C qG3IZxBgeMtnVW1oWVDFDnsPP+/vTYgwrTTIOTMo9OrLi0+XDGUety+aD/Yqw/brGR NZnq1q2db3ysnReYB3rnQtMEoKgHe/AYgG6+cq+odFqVbY2wUEilPziPRkqRdTIERn Ine9S31pxMowd789Az8jJGIqLUu/FE7F29520cm6HYfENmXd3iHszCMhXjdZa4gWEh e4fxiaZRkpzrSfvIDaFEkAxT/fpIYGcH/nNDslQ7WOVaCaFg0By088I6rR3Y0ME4nJ c+OOSMwzdURJg== MIME-Version: 1.0 In-Reply-To: <89046151-e44e-6828-ad76-8574fba4fca8@gmail.com> References: <20220103233948.198119-1-Mr.Bossman075@gmail.com> <20220103233948.198119-6-Mr.Bossman075@gmail.com> <20220105235157.8ED80C36AEB@smtp.kernel.org> <89046151-e44e-6828-ad76-8574fba4fca8@gmail.com> Subject: Re: [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050 clock driver From: Stephen Boyd Cc: mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, adrian.hunter@intel.com, jirislaby@kernel.org, giulio.benetti@benettiengineering.com, nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org To: Jesse Taube , linux-imx@nxp.com Date: Mon, 10 Jan 2022 12:12:00 -0800 User-Agent: alot/0.9.1 Message-Id: <20220110201201.C1E37C36AE9@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_121205_351923_A13C25ED X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Jesse Taube (2022-01-09 11:07:42) > >> + > >> + clk_hw_data->num = IMXRT1050_CLK_END; > >> + hws = clk_hw_data->hws; > >> + > >> + hws[IMXRT1050_CLK_OSC] = __clk_get_hw(of_clk_get_by_name(np, "osc")); > > > > Use clk_parent_data instead and reference the binding name with .fw_name > > Hi Stephen, sorry to bother you again. > I'm wondering if adding `clk_parent_data` is necessary as it seems like > it wold be a big change and the other IMX boards haven't implemented > this yet would it be okay if I don't do this, or if it is necessary > could you link to a patch set to change it. > Is it a big change because the imx_clk_hw*() APIs aren't prepared for non-string parents? Can you make some clk_parent_data based APIs and migrate things over gradually? This is really a question for i.MX folks to see if anyone is working on moving away from the string names. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel