From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B004C433F5 for ; Wed, 12 Jan 2022 02:47:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nFVrAnt5Bs0PX8lmc19OSnykaDWuziVVPD453pRqiY8=; b=gzcLf/a59yFfDs QwbeQxVo7WDMf1n0hD6Aj6HKhztUF7Bl1D4f6nQogC9OFVj/2oq621sr7nvuCcG1L8ZYgjAdM4+QW XicGSnFxdGJVBRVzjGPhhhEU5UNkpIX6ds73mTsNX5VgdYiNeeKrPKgRIdOBi68PcVQhC+tCDikmB L9UvjwAo3ow6TKXMagkH9SPiQoy5ObnfxTZz7j8ufhYRykVVoRpCAwnEr4oKffZzYrreVi3gJXaTS DLSJscaYCUD06saRO/WNt5VuZhD9SIDzxyF67Ep1ezPZ7jamBHpN3vk1oNhGWsfCZ02Y5IyhKqB6F nA1uuB4K62KmEjvYc8RQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7Tef-000wiX-N0; Wed, 12 Jan 2022 02:46:29 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7Ted-000wiB-3a for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 02:46:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 91EC1CE1BF9; Wed, 12 Jan 2022 02:46:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5266C36AE3; Wed, 12 Jan 2022 02:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641955581; bh=OZfNXL4MnKaUhxdWponGWXg2xOKdXHnrj3FC9N364Y0=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=UTkUNTMG0yjaLfPj9l9I/3KX8ZmDwsDp5ffl/I16ep0GrMy9AICHSRSDE2u1nFFdI io8WQHFllD7xXSTw3BWZ026ISo6G6H2j62MSCUqgQJ9WJOTEvHNMCa8dfwmQ6HTovR AUPtVxOZ2tiOUqL2UysbHtIxLQiNDOhzPsoMHO6OmxaUwWizHndahJQtySQamMhM4o Z5tMf2s4K+NOh1eIT6N734CPLCsq91p8PoodxUBSNfHG0VjTSQjH2uGb5K3obTqlT9 gRpRfZernSklsZubEhqKOXHsLX7m8lHA/lP3DX1QPco+wil31OmBH45DgLcohwWm1x mwhr6CsO/Y4lA== MIME-Version: 1.0 In-Reply-To: References: <20220103233948.198119-1-Mr.Bossman075@gmail.com> <20220103233948.198119-6-Mr.Bossman075@gmail.com> <20220105235157.8ED80C36AEB@smtp.kernel.org> <89046151-e44e-6828-ad76-8574fba4fca8@gmail.com> <20220110201201.C1E37C36AE9@smtp.kernel.org> Subject: Re: [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050 clock driver From: Stephen Boyd Cc: Jesse Taube , linux-imx@nxp.com, mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, adrian.hunter@intel.com, jirislaby@kernel.org, giulio.benetti@benettiengineering.com, nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org To: Abel Vesa Date: Tue, 11 Jan 2022 18:46:20 -0800 User-Agent: alot/0.9.1 Message-Id: <20220112024621.C5266C36AE3@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220111_184627_371441_03B08F3B X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Abel Vesa (2022-01-10 14:48:10) > On 22-01-10 12:12:00, Stephen Boyd wrote: > > Quoting Jesse Taube (2022-01-09 11:07:42) > > > >> + > > > >> + clk_hw_data->num = IMXRT1050_CLK_END; > > > >> + hws = clk_hw_data->hws; > > > >> + > > > >> + hws[IMXRT1050_CLK_OSC] = __clk_get_hw(of_clk_get_by_name(np, "osc")); > > > > > > > > Use clk_parent_data instead and reference the binding name with .fw_name > > > > > > Hi Stephen, sorry to bother you again. > > > I'm wondering if adding `clk_parent_data` is necessary as it seems like > > > it wold be a big change and the other IMX boards haven't implemented > > > this yet would it be okay if I don't do this, or if it is necessary > > > could you link to a patch set to change it. > > > > > > > Is it a big change because the imx_clk_hw*() APIs aren't prepared for > > non-string parents? Can you make some clk_parent_data based APIs and > > migrate things over gradually? This is really a question for i.MX folks > > to see if anyone is working on moving away from the string names. > > I'm currently looking into it. I would suggest we take this patch as is > and I'll switch it later on to clk_parent_data. > Ok sounds like a plan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel