From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 978CEC433F5 for ; Wed, 12 Jan 2022 07:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sw8F/WJHrLOZuWIgMMpWut7KPWTKFtsM8JYJ8c6kVGc=; b=nUBUeP0OuE1TtZ RtAPiPwijT3SrqCajTRXGVifgmFxkZQKZksOGpQAsuz5LwDBIWfD21X9TE+vnEdjYBbO6xa5N0uEL 6FSL+6ZZ6b+AccLAz1JzlHXX8SrKqdcrq0GQslWGbD1UovAirLqUfbAWhcYUO663c7cpHuPcyjdJ/ Nfjdatp16AZSe/YHwpEVnBDi1qyKlJ+Ttex0oyPcBQ+YfMgFGqRpg/ZtSdw22vQpwjLOpzhBz6uu/ DI+XyyYA+dvvlMuQf+zJOyE7mzoIQqZilc6ZWoUD0l4KasInxO78x2ieEstGkqOlHSIdf5IvBERVd XP0IBDxQXUxTkDocB1/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7YUe-001RXQ-4v; Wed, 12 Jan 2022 07:56:28 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7YUb-001RXH-HN for linux-arm-kernel@bombadil.infradead.org; Wed, 12 Jan 2022 07:56:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4a6laHOt+Mp6isAwERXcIBVqCRhM9YwMlge0du+d2SY=; b=EMdZMnKR55xuxgZSnqF8xnl5/Q 5v8t9i2DgHjtPbua9QUFOAk5x/ObP4omT9HE0VoPrOVg9Mi5fMZIhUxSwAUISCaUANuA1P8eD4Hiw TdkcuRLzCOkJwU6AKUPNOiixXysx0JnD2RtMhrZ6HegGvRexqz6I18KGy+v7HOvRdxrP48vXarkYU jsVc/cL3a5GmdiIwMZAF3v3sKFD/Mcrh14q+w5gQiUwHOUHqh/sMWQqTA8BdGufwCX2v6IQDeMK+A ceFjZmY9oGs758zsg208wHNV9M9im4ixxis2ulAnX4KLTjYxQmi3NFUcrUCsbgorPDp1KMjLTPq5X XiI+pjtQ==; Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7YUY-000lJv-1y for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 07:56:24 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BD67E68AFE; Wed, 12 Jan 2022 08:56:09 +0100 (CET) Date: Wed, 12 Jan 2022 08:56:09 +0100 From: Christoph Hellwig To: Arnd Bergmann Cc: Christoph Hellwig , Guo Ren , the arch/x86 maintainers , Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-arch , Jeff Layton , "J. Bruce Fields" Subject: Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h Message-ID: <20220112075609.GA4854@lst.de> References: <20220111083515.502308-1-hch@lst.de> <20220111083515.502308-5-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_075622_171377_EE74A547 X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 11, 2022 at 04:33:30PM +0100, Arnd Bergmann wrote: > This is a very subtle change to the exported UAPI header contents: > On 64-bit architectures, the three unusable numbers are now always > shown, rather than depending on a user-controlled symbol. Well, the change is bigger and less subtle. Before this change the constants were never visible to userspace at all (except on mips), because the #ifdef CONFIG_64BIT it never set for userspace builds. > This is probably what we want here for compatibility reasons, but I think > it should be explained in the changelog text, and I'd like Jeff or Bruce > to comment on it as well: the alternative here would be to make the > uapi definition depend on __BITS_PER_LONG==32, which is > technically the right thing to do but more a of a change. I can change this to #if __BITS_PER_LONG==32 || defined(__KERNEL__), but it will still be change in what userspace sees. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel