From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8414AC433F5 for ; Wed, 12 Jan 2022 09:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gRCCroRXbDNODzZtvHGthP4y4kyvBpvGfP38Qy80vHs=; b=MSbMOX53bHbxZ3 cltfdcF64uxAJraSj0M+DoI3MmS5W5gvrbxd2rhrT/LIPE3ah2D2KlyOGjal4Rd1xFHTePEgjF/PG H4FLyLAoP001Q11jmlI3vxTHnP5F8WZMmoNeMlrP2jXMLahuRatF+q5RmPO1vx4Kg1T0WLegueMHO eRfTN77uktHCGK1dpfhcimQmzIn6NjxCWblXRpvsm+5Er+Brwt7mM45uIwdnAf7rnBLUbMqjKR+pn 24fp9ILf6hmXYX48M7jbDgCAN5eM86C/ZzsN7NyrHV6DySa5n+UgnvrGBa+FkfCxoXSx99KqpSWBI 0H/tetfUqoC22V76NLKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7ZTQ-001fGS-VQ; Wed, 12 Jan 2022 08:59:17 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7ZTJ-001fCX-0D for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 08:59:14 +0000 Received: (Authenticated sender: jacopo@jmondi.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id D0EBA1BF204; Wed, 12 Jan 2022 08:59:03 +0000 (UTC) Date: Wed, 12 Jan 2022 10:00:03 +0100 From: Jacopo Mondi To: Eugen Hristev Subject: Re: [PATCH v3 18/23] media: atmel: atmel-isc-base: add wb debug messages Message-ID: <20220112090003.nktnhm3oho4mdx6g@uno.localdomain> References: <20211213134940.324266-1-eugen.hristev@microchip.com> <20211213134940.324266-19-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211213134940.324266-19-eugen.hristev@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_005909_268536_36A73C2D X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Eugen, On Mon, Dec 13, 2021 at 03:49:35PM +0200, Eugen Hristev wrote: > Add debug messages that make it easier to debug white balance algorithm. > > Signed-off-by: Eugen Hristev The dev_dbg() infrastructure is preferred, as far as I know v4l2_dbg() is legacy and should be removed. However the driver uses v4l2_dbg() already, so Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/media/platform/atmel/atmel-isc-base.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c > index 53cac1aac0fd..f1f1019f9d82 100644 > --- a/drivers/media/platform/atmel/atmel-isc-base.c > +++ b/drivers/media/platform/atmel/atmel-isc-base.c > @@ -1329,10 +1329,15 @@ static void isc_hist_count(struct isc_device *isc, u32 *min, u32 *max) > > if (!*min) > *min = 1; > + > + v4l2_dbg(1, debug, &isc->v4l2_dev, > + "isc wb: hist_id %u, hist_count %u", > + ctrls->hist_id, *hist_count); > } > > static void isc_wb_update(struct isc_ctrls *ctrls) > { > + struct isc_device *isc = container_of(ctrls, struct isc_device, ctrls); > u32 *hist_count = &ctrls->hist_count[0]; > u32 c, offset[4]; > u64 avg = 0; > @@ -1349,6 +1354,9 @@ static void isc_wb_update(struct isc_ctrls *ctrls) > (u64)hist_count[ISC_HIS_CFG_MODE_GB]; > avg >>= 1; > > + v4l2_dbg(1, debug, &isc->v4l2_dev, > + "isc wb: green components average %llu\n", avg); > + > /* Green histogram is null, nothing to do */ > if (!avg) > return; > @@ -1401,9 +1409,15 @@ static void isc_wb_update(struct isc_ctrls *ctrls) > else > gw_gain[c] = 1 << 9; > > + v4l2_dbg(1, debug, &isc->v4l2_dev, > + "isc wb: component %d, s_gain %u, gw_gain %u\n", > + c, s_gain[c], gw_gain[c]); > /* multiply both gains and adjust for decimals */ > ctrls->gain[c] = s_gain[c] * gw_gain[c]; > ctrls->gain[c] >>= 9; > + v4l2_dbg(1, debug, &isc->v4l2_dev, > + "isc wb: component %d, final gain %u\n", > + c, ctrls->gain[c]); > } > } > > @@ -1423,6 +1437,10 @@ static void isc_awb_work(struct work_struct *w) > return; > > isc_hist_count(isc, &min, &max); > + > + v4l2_dbg(1, debug, &isc->v4l2_dev, > + "isc wb mode %d: hist min %u , max %u\n", hist_id, min, max); > + > ctrls->hist_minmax[hist_id][HIST_MIN_INDEX] = min; > ctrls->hist_minmax[hist_id][HIST_MAX_INDEX] = max; > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel