From: Maxime Ripard <maxime@cerno.tech>
To: Evgeny Boger <boger@wirenboard.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v4 2/3] dt-bindings: net: support for Allwinner R40 EMAC controller
Date: Wed, 12 Jan 2022 10:04:01 +0100 [thread overview]
Message-ID: <20220112090401.vbwhqudqvdce7jm4@houat> (raw)
In-Reply-To: <20220111160600.58384-3-boger@wirenboard.com>
[-- Attachment #1.1: Type: text/plain, Size: 2006 bytes --]
Hi,
On Tue, Jan 11, 2022 at 07:05:59PM +0300, Evgeny Boger wrote:
> R40 and A10/A20 share the same EMAC IP.
> However, on R40 the EMAC reset needs to be deasserted first,
> so resets property is required.
>
> Signed-off-by: Evgeny Boger <boger@wirenboard.com>
> ---
> .../net/allwinner,sun4i-a10-emac.yaml | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml
> index 8d8560a67abf..8b38b4e981fe 100644
> --- a/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml
> @@ -15,7 +15,9 @@ maintainers:
>
> properties:
> compatible:
> - const: allwinner,sun4i-a10-emac
> + enum:
> + - allwinner,sun4i-a10-emac
> + - allwinner,sun8i-r40-emac
>
> reg:
> maxItems: 1
> @@ -30,6 +32,19 @@ properties:
> description: Phandle to the device SRAM
> $ref: /schemas/types.yaml#/definitions/phandle-array
>
> + resets:
> + maxItems: 1
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun8i-r40-emac
> +
> +then:
> + required:
> + - resets
> +
> required:
> - compatible
> - reg
> @@ -42,11 +57,14 @@ unevaluatedProperties: false
>
> examples:
> - |
> + #define RST_BUS_EMAC 14
> +
> emac: ethernet@1c0b000 {
> compatible = "allwinner,sun4i-a10-emac";
> reg = <0x01c0b000 0x1000>;
> interrupts = <55>;
> clocks = <&ahb_gates 17>;
> + resets = <&ccu RST_BUS_EMAC>;
> phy-handle = <&phy0>;
> allwinner,sram = <&emac_sram 1>;
> };
The example doesn't make much sense now, since we can't have an A10
controller with the reset line.
Either leave it like it was, or create a new example
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-12 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 16:05 [PATCH v4 0/3] sun8i: r40: second ethernet support Evgeny Boger
2022-01-11 16:05 ` [PATCH v4 1/3] net: allwinner: reset control support Evgeny Boger
2022-01-12 9:09 ` Corentin Labbe
2022-01-11 16:05 ` [PATCH v4 2/3] dt-bindings: net: support for Allwinner R40 EMAC controller Evgeny Boger
2022-01-12 9:04 ` Maxime Ripard [this message]
2022-01-11 16:06 ` [PATCH v4 3/3] ARM: dts: sun8i: r40: add second ethernet support Evgeny Boger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112090401.vbwhqudqvdce7jm4@houat \
--to=maxime@cerno.tech \
--cc=boger@wirenboard.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox