From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA43DC433EF for ; Wed, 12 Jan 2022 16:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qOVpMh7dI9yjS4wdzexx0MPITZTAYk3EzdJo7MwL3k8=; b=WAOpOQ4f3Nnbmi OYWvenfqowipNwcDXzGTglo9RsCPQ9uuQKD6gJLqozWGJWT0plzDHL6J7NegXBRFLxGSKtfx7NURh sPtwSxNbrAUeYn5eBRjhc3dGIm9HWEy8YpuVNS35zpwRYsHdlOvRvJx8qr0XInVYRWkOAE0wZ4w/J sDQkFElDA6CIzEGorlnRcbDLMng9BnoEcLiOXA8rU0B44tGOrccwOXg5Dzfa4izkqBy51YbPw1dtR 86M9blvEGRui8berwbKtVJmELPrJfBH/TlasaDDthUkILr45jIHCzT0PySUPFr3X5qJ6eWzESoz7q 9Zk32YHfaf8oMEuzK9ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7gC4-0032zg-K7; Wed, 12 Jan 2022 16:09:48 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7gC3-0032yU-CT for linux-arm-kernel@bombadil.infradead.org; Wed, 12 Jan 2022 16:09:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MPt/j8Iib7I9r8TWZQvLyQttOCeT/qbIdZJ86PX3N7M=; b=Hi7ipzMMkIXrgu5yBMWCFjSNG+ S5LxTBgRUpzxEx8/OGniTfNPwRqWxRtIUluAvauRBKsysb+eZSyVtVpCfL4Y3yMh5vYMq8lV8Abha i4p4rjEEbg959i/jvCZ6Gh7+d6OLVJy5H6EEjsodj2B2UerVpmqBVaoJ4CVbdTiSU+1Uph2YaqSun dYgtoQkZjeqx66jw2SAQHJdS9MCw5zXiNhM17IGzt7AViyCXqVE1hK3yFTzONTzIgWyHxkGupHgF5 gY4z6m5Ox2RVnmLNXhMvU/8SzhbT1R4uqAnU7eGOj40/0P6UUZKpKUJvpeowbwOZFV3RkdBlVUDlG KVY9sKCA==; Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7gBz-000pMt-TL for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 16:09:45 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3EE0868AFE; Wed, 12 Jan 2022 17:09:36 +0100 (CET) Date: Wed, 12 Jan 2022 17:09:35 +0100 From: Christoph Hellwig To: Arnd Bergmann Cc: Jeff Layton , Christoph Hellwig , Guo Ren , the arch/x86 maintainers , Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-arch , "J. Bruce Fields" Subject: Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h Message-ID: <20220112160935.GA3684@lst.de> References: <20220111083515.502308-1-hch@lst.de> <20220111083515.502308-5-hch@lst.de> <20220112075609.GA4854@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_160944_051436_1222453F X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 12, 2022 at 01:08:24PM +0100, Arnd Bergmann wrote: > > I don't have a strong opinion here. If we were taking symbols away that > > were previously visible to userland it would be one thing, but since > > we're just adding symbols that may not have been there before, this > > seems less likely to break anything. > > Changing > > #ifndef CONFIG_64BIT > > to > > #if __BITS_PER_LONG==32 || defined(__KERNEL__), > > would take symbols away, since the CONFIG_64BIT macro is never > set in user space. Yes. > > I probably lean toward Christoph's original solution instead of keeping > > the conditional definitions. It's hard to imagine there are many > > programs that care whether these other symbols are defined or not. > > > > You can add this to the original patch: > > > > Acked-by: Jeff Layton > > Sounds good, thanks So should we go ahead with the series as-is? Or respin it? Or add the above change ontop? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel