From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E721CC433EF for ; Wed, 12 Jan 2022 20:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lA+uYzXtEQVjgvkuar5rCkepTL36yX+LH0x7QhR7l5k=; b=JzrlbIizwZGPtk HJCKLQge8OZ5wwdv377WTEZi9e2m5Yi9Y5jh+CW98SK5rHTAiwyT38xaZIbBKquIBJoPkFo0VX+Dw 7xe0uO5+EcXaWfjzt1A4HtPjCJxry89WYHTmAYiqkIWg8sOQr8Y31bF0jqxkQ0ViMrmm6+egkg9P8 PZD76+vGxSNze/v1qClq/wkUoas2+37AqtA4i25GtZKin1880/P9aAxn6tPuFTm7rfLKwMEmdVjMH aAGI0qzK3dXAnOC8azi4lIUpo1egsLA1YhHym1kgP3AIbAOEhVXAaAJauo75XfQQPP49r5u+aQunE oBwHSXMAVpIEQ4ZwGtxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7kFa-003k9B-R6; Wed, 12 Jan 2022 20:29:42 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7kFX-003k8i-HJ for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 20:29:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 44F99B82040; Wed, 12 Jan 2022 20:29:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 034D9C36AE5; Wed, 12 Jan 2022 20:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642019377; bh=MgUd3EYLnW0KjTcDkuqg/Pl+jyjGh6I0FIMsqOvro9s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ie6lRZFWFIr0yrkC3/o2ZdMok9f+yT6PFi4funImCHWOZBjRcyI+RQBOGyRAqXN5c zUc0KXeODKHFaZSYUFhKr4WfsOW9yKxFdt4+vwRJ6XTJv6Hvsfay3ABF6nEatrUFW+ CBqeOoI3ngZKofa3AE/ZYczD8Hhx5At2KwfAEAIaMSslhrfjleBfEAtVv1nYWgsNLW oihJcf4cxMcSnP0pqEEmmCpQNl/Dhha29ZGga+QzNJ9of/7Ba6/2ag2IvMcW8aPZD0 m5f9Jx2XzqfEKsPjqCNEmHcRSLXTCxoHEOMUPGSpoJOc5xncnGsCxMB6LzVf9141oY Xvqwe9iX1Z5PQ== MIME-Version: 1.0 In-Reply-To: <20220112141229.700708-1-m.tretter@pengutronix.de> References: <20220112141229.700708-1-m.tretter@pengutronix.de> Subject: Re: [PATCH] clk: zynqmp: warn always when a clock op fails From: Stephen Boyd Cc: mturquette@baylibre.com, michal.simek@xilinx.com, rajan.vaja@xilinx.com, kernel@pengutronix.de, m.tretter@pengutronix.de To: Michael Tretter , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Date: Wed, 12 Jan 2022 12:29:35 -0800 User-Agent: alot/0.9.1 Message-Id: <20220112202937.034D9C36AE5@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_122939_740143_C80B3541 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Michael Tretter (2022-01-12 06:12:29) > The warning that a clock operation failed is only printed once. However, > the function is called for various different clocks. The limit hides > warnings if different clock are affected by the failures. > > Print the warning every time when a clock operation fails. > > Signed-off-by: Michael Tretter > --- > drivers/clk/zynqmp/clk-gate-zynqmp.c | 12 +++++------ > drivers/clk/zynqmp/clk-mux-zynqmp.c | 8 +++---- > drivers/clk/zynqmp/divider.c | 12 +++++------ > drivers/clk/zynqmp/pll.c | 32 ++++++++++++++-------------- > 4 files changed, 32 insertions(+), 32 deletions(-) > > diff --git a/drivers/clk/zynqmp/clk-gate-zynqmp.c b/drivers/clk/zynqmp/clk-gate-zynqmp.c > index 565ed67a0430..0d9a39110f29 100644 > --- a/drivers/clk/zynqmp/clk-gate-zynqmp.c > +++ b/drivers/clk/zynqmp/clk-gate-zynqmp.c > @@ -41,8 +41,8 @@ static int zynqmp_clk_gate_enable(struct clk_hw *hw) > ret = zynqmp_pm_clock_enable(clk_id); > > if (ret) > - pr_warn_once("%s() clock enabled failed for %s, ret = %d\n", > - __func__, clk_name, ret); > + pr_warn("%s() clock enable failed for %s (id %d), ret = %d\n", > + __func__, clk_name, clk_id, ret); Can we just remove these prints entirely? The driver that calls clk_enable() should be checking the return value and taking proper action. What is the user going to do with these messages? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel