From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49345C433F5 for ; Fri, 14 Jan 2022 15:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oFRNI9F4kEUB/gq/z7+Bramx3lZL1A9o4yf2r49fejc=; b=HRlxiFoG490jVT k0C7A7d6YKjDjsS8yYE4pcYs2jjj0xhvWbu+dgwIET/zjS0tRItWer6+TCjmXrXzQXhfB3wOVQYKK yw/z8sfuyw0a2tJS9eiLZv3lFDH/SOWTUE8SL5GRL2gfq9/1nHDnR+kO9E3irpe6/J66i59uIBEUR fsJBRKME5hBArpVxwRc8sOk085DglPvV/SFRydPShHeELRM7DUhgq3nMId2V65NUpHqbMqnvjlhQP l3sJxmIV1mRHffBkuvEgAJ9q+gGnfakm97OYRMU82CWkOe2jZPh3uglsejS/DdEXbcAZ656fPnlGC s+VnLZVlDP1ERBzah+wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Oqf-009ehg-M6; Fri, 14 Jan 2022 15:50:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Oqc-009ehG-7t for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 15:50:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D4376D; Fri, 14 Jan 2022 07:50:36 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D23D3F766; Fri, 14 Jan 2022 07:50:35 -0800 (PST) Date: Fri, 14 Jan 2022 15:50:32 +0000 From: Andre Przywara To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, Jaxson.Han@arm.com, robin.murphy@arm.com, vladimir.murzin@arm.com, Wei.Chen@arm.com Subject: Re: [bootwrapper PATCH v2 05/13] aarch64: add mov_64 macro Message-ID: <20220114155032.2d5bab06@donnerap.cambridge.arm.com> In-Reply-To: <20220114105653.3003399-6-mark.rutland@arm.com> References: <20220114105653.3003399-1-mark.rutland@arm.com> <20220114105653.3003399-6-mark.rutland@arm.com> Organization: ARM X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_075038_364423_E5C83FCD X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 14 Jan 2022 10:56:45 +0000 Mark Rutland wrote: Hi Mark, > In subsequent patches we'll need to load 64-bit values into GPRs before > the CPU is in a known endianness, where we cannot use literal pools. > > In preparation for that, this patch adds a new `mov_64` macro to load a > 64-bit value into a GPR using a sequence of MOV and MOVKs, which will > function the same regardless of the CPU's endianness. > > At the same time, move the `cpuid` macro to use `mov_64` internally. > > Signed-off-by: Mark Rutland Not sure that's worth it, but there is a simpler version of that TF-A macro, along the lines of: .if ((\val) >> 16) & 0xffff movk \dest, #(((\val) >> 16) & 0xffff), lsl #16 .endif It's a bit less optimal in a corner case than the TF-A version, but avoids the few pointless " movk x0, #0x0, lsl #..." I found in the code. But that's an optimisation detail, so anyway: Reviewed-by: Andre Przywara Cheers, Andre > --- > arch/aarch64/common.S | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/aarch64/common.S b/arch/aarch64/common.S > index c7171a9..3279fa9 100644 > --- a/arch/aarch64/common.S > +++ b/arch/aarch64/common.S > @@ -9,9 +9,17 @@ > > #include > > + /* Load a 64-bit value using immediates */ > + .macro mov_64 dest, val > + mov \dest, #(((\val) >> 0) & 0xffff) > + movk \dest, #(((\val) >> 16) & 0xffff), lsl #16 > + movk \dest, #(((\val) >> 32) & 0xffff), lsl #32 > + movk \dest, #(((\val) >> 48) & 0xffff), lsl #48 > + .endm > + > /* Put MPIDR into \dest, clobber \tmp and flags */ > .macro cpuid dest, tmp > mrs \dest, mpidr_el1 > - ldr \tmp, =MPIDR_ID_BITS > + mov_64 \tmp, MPIDR_ID_BITS > ands \dest, \dest, \tmp > .endm _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel