From: Yong Wu <yong.wu@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil@xs4all.nl>, Joerg Roedel <jroedel@suse.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
David Airlie <airlied@linux.ie>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>
Cc: Evan Green <evgreen@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
Will Deacon <will.deacon@arm.com>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux-foundation.org>, <yong.wu@mediatek.com>,
<youlin.pei@mediatek.com>, Matthias Kaehlcke <mka@chromium.org>,
<anan.sun@mediatek.com>, <yi.kuo@mediatek.com>,
<acourbot@chromium.org>, <linux-media@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Tiffany Lin <tiffany.lin@mediatek.com>,
"Dafna Hirschfeld" <dafna.hirschfeld@collabora.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Eizan Miyamoto <eizan@chromium.org>, <anthony.huang@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
<mingyuan.ma@mediatek.com>, <yf.wang@mediatek.com>,
<libo.kang@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: [PATCH v10 03/13] iommu/mediatek: Return ENODEV if the device is NULL
Date: Mon, 17 Jan 2022 15:05:00 +0800 [thread overview]
Message-ID: <20220117070510.17642-4-yong.wu@mediatek.com> (raw)
In-Reply-To: <20220117070510.17642-1-yong.wu@mediatek.com>
The platform device is created at:
of_platform_default_populate_init: arch_initcall_sync
->of_platform_populate
->of_platform_device_create_pdata
When entering our probe, all the devices should be already created.
if it is null, means NODEV. Currently we don't get the fail case.
It's a minor fix, no need add fixes tags.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Acked-by: Joerg Roedel <jroedel@suse.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/iommu/mtk_iommu.c | 2 +-
drivers/iommu/mtk_iommu_v1.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 25b834104790..77ae20ff9b35 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -848,7 +848,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
plarbdev = of_find_device_by_node(larbnode);
if (!plarbdev) {
of_node_put(larbnode);
- return -EPROBE_DEFER;
+ return -ENODEV;
}
data->larb_imu[id].dev = &plarbdev->dev;
diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c
index 1467ba1e4417..68bf02f87cfd 100644
--- a/drivers/iommu/mtk_iommu_v1.c
+++ b/drivers/iommu/mtk_iommu_v1.c
@@ -604,7 +604,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
plarbdev = of_find_device_by_node(larbnode);
if (!plarbdev) {
of_node_put(larbnode);
- return -EPROBE_DEFER;
+ return -ENODEV;
}
data->larb_imu[i].dev = &plarbdev->dev;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-17 7:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 7:04 [PATCH v10 00/13] Clean up "mediatek,larb" Yong Wu
2022-01-17 7:04 ` [PATCH v10 01/13] dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW Yong Wu
2022-01-17 7:04 ` [PATCH v10 02/13] iommu/mediatek-v1: Free the existed fwspec if the master dev already has Yong Wu
2022-01-28 12:40 ` Mauro Carvalho Chehab
2022-01-28 12:45 ` Mauro Carvalho Chehab
2022-01-31 12:29 ` Matthias Brugger
2022-01-17 7:05 ` Yong Wu [this message]
2022-01-17 7:05 ` [PATCH v10 04/13] iommu/mediatek: Add probe_defer for smi-larb Yong Wu
2022-01-17 7:05 ` [PATCH v10 05/13] iommu/mediatek: Add device_link between the consumer and the larb devices Yong Wu
2022-01-17 7:05 ` [PATCH v10 06/13] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put Yong Wu
2022-01-17 7:05 ` [PATCH v10 07/13] media: mtk-mdp: " Yong Wu
2022-01-17 7:05 ` [PATCH v10 08/13] drm/mediatek: Add pm runtime support for ovl and rdma Yong Wu
2022-01-17 7:05 ` [PATCH v10 09/13] drm/mediatek: Get rid of mtk_smi_larb_get/put Yong Wu
2022-01-17 7:05 ` [PATCH v10 10/13] media: mtk-vcodec: " Yong Wu
2022-01-17 7:05 ` [PATCH v10 11/13] memory: mtk-smi: " Yong Wu
2022-01-17 7:05 ` [PATCH v10 12/13] arm: dts: mediatek: Get rid of mediatek, larb for MM nodes Yong Wu
2022-01-17 7:05 ` [PATCH v10 13/13] arm64: " Yong Wu
2022-01-17 10:27 ` [PATCH v10 00/13] Clean up "mediatek,larb" AngeloGioacchino Del Regno
2022-01-17 11:49 ` Matthias Brugger
2022-01-17 12:04 ` Hans Verkuil
2022-01-31 9:47 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117070510.17642-4-yong.wu@mediatek.com \
--to=yong.wu@mediatek.com \
--cc=acourbot@chromium.org \
--cc=airlied@linux.ie \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=anthony.huang@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eizan@chromium.org \
--cc=evgreen@chromium.org \
--cc=frank-w@public-files.de \
--cc=hsinyi@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mingyuan.ma@mediatek.com \
--cc=mka@chromium.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=will.deacon@arm.com \
--cc=yf.wang@mediatek.com \
--cc=yi.kuo@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).