From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33EC8C433F5 for ; Tue, 18 Jan 2022 09:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jReW6qk7W+LB8khr0qJ7xrBgUkxX/eNg11zZEg5D+To=; b=uGU0YaVeh7OGlM NAtVis8nz0j9qRgxDC5xQ5Z6MqDsvkt36fiq2eo1jitXJ4BU2+3UR7VxefOu05VEs5elIxOO2kE08 /7QJwMZ7XA5JtlCyA3+5GwO/PRKVemAfVMhqHDnnIVAISLlP9RuUaqg0Sdi5FrP1QFGJblLrU0TYG E5ioLX8dp/krUDkMpWLZ3rssRCaaSme/LkkXbqVAzAnDSEzEDrtRbkIGlnjHmqBhYLOcweOqAElJg rUggJLqjCwkr+LftzjYjta0XYxB0BVaqxsC6/cy173MZnPmyrr70dVojhOWMtvS5wQmQBKg+Nknvl XUO8Zkqevs6UI3qBesIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9kdV-000rX6-4e; Tue, 18 Jan 2022 09:18:41 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9kdQ-000rWL-5h for linux-arm-kernel@lists.infradead.org; Tue, 18 Jan 2022 09:18:37 +0000 Received: by mail-ed1-x529.google.com with SMTP id q25so76604809edb.2 for ; Tue, 18 Jan 2022 01:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=epXjxVZYGdrS5V2vncnZJ3QtAgAqtwFKvMdQBktjbpw=; b=IFjPIDyeHD1pa5vazociaIVltQeXFZP1IdZTMMldhbplf7rS2ghHX6lhePpdxZDlN4 pyD/vK623ixNxbD156KLjuu+xovW29aHl7KMyPjoM8UHmrx0T7gaExFrg5dtNLneIk05 8lHTr3rAmRDP7a2x25z+hqUWZb4eJTe1/KLbmMqJCuvy5aEcVQaoFB9Y/IbA/Cl7yQu5 BkkBu3jJR9BBK5r3tgF2Me27nwdmkXjKyBULFKE08+siXHIPY9zyLt/FdMe23siMG10V 7HfCoKachHeLruBO0zJHVKKgNXN+sGZ/jOnJqWyjKFs2zwicoBfakSbE6GN7QxVFweur WZag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=epXjxVZYGdrS5V2vncnZJ3QtAgAqtwFKvMdQBktjbpw=; b=tU8cuuzHd+7MgZtKDTJXgR+77KRS4IfaBcmcnOUh2rI3g71vmRKw4JI31tV/m3ONFR qzh4/i2lslldxDWdcMMrVQqRHS1XikLXZbpQXaxdHpeIojU0PrAsZyr0KiNzLggIqzes IzC0Gij8SFb81ac3zso28/UJMdjGFwlL570TmK9pbVo81zbSuy5ad6ApmaMv+Pa4HxCw UsWqSz8jhHEY3U+6i2Q7JmQdvLPp6by8uYNNrjyXrQV5MStuY+ki3OCXw+6/sbXN4PXN Ifj4DzqHUBgng447Slp43yEdGpeBsposQgmoWvcl/V6sCrApFOAY9uEeCD3I/br69A7q DLGw== X-Gm-Message-State: AOAM5300bpJV0Ug0S4FqTNiiaExBR//5MOHwgCHBjoczPePy6+kPJ2l2 UIYCWPVr9mQM1NvauP3zkrgfsw== X-Google-Smtp-Source: ABdhPJzdwWCxEjIeT5KJlR/Ba2GZ8dPe4vxd5ULvLy5WwNe9MrQCFdDTOTcEXmSEqqi1EyMCLYF1kA== X-Received: by 2002:a05:6402:158:: with SMTP id s24mr25490055edu.144.1642497513890; Tue, 18 Jan 2022 01:18:33 -0800 (PST) Received: from leoy-ThinkPad-X240s ([104.245.96.239]) by smtp.gmail.com with ESMTPSA id w22sm3411723eji.87.2022.01.18.01.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 01:18:33 -0800 (PST) Date: Tue, 18 Jan 2022 17:18:27 +0800 From: Leo Yan To: John Garry Cc: Marco Elver , Thomas Richter , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, svens@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com, Will Deacon , Mark Rutland , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] perf test: Test 73 Sig_trap fails on s390 Message-ID: <20220118091827.GA98966@leoy-ThinkPad-X240s> References: <20211216151454.752066-1-tmricht@linux.ibm.com> <90efb5a9-612a-919e-cf2f-c528692d61e2@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <90efb5a9-612a-919e-cf2f-c528692d61e2@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_011836_308675_12E159B8 X-CRM114-Status: GOOD ( 21.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 17, 2022 at 03:39:10PM +0000, John Garry wrote: > On 16/12/2021 15:48, Marco Elver wrote: > > + > > > On Thu, 16 Dec 2021 at 16:15, Thomas Richter wrote: > > > In Linux next kernel > > > Commit 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling") > > > introduced the new test which uses breakpoint events. > > > These events are not supported on s390 and PowerPC and always fail: > > > > > > # perf test -F 73 > > > 73: Sigtrap : FAILED! > > > # > > > > > > Fix it the same way as in the breakpoint tests in file > > > tests/bp_account.c where these type of tests are skipped on > > > s390 and PowerPC platforms. > > > > > > With this patch skip this test on both platforms. > > > > > > Output after: > > > # ./perf test -F 73 > > > 73: Sigtrap > > > > > > Fixes: 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling") > > > > > > Cc: Marco Elver > > > Signed-off-by: Thomas Richter > > Acked-by: Marco Elver > > > > Thanks, and sorry for missing this case! > > > > I am finding that this test hangs on my arm64 machine: > > john@debian:~/kernel-dev2/tools/perf$ sudo ./perf test -vvv 73 > 73: Sigtrap: > --- start --- > test child forked, pid 45193 Both Arm and Arm64 platforms cannot support signal handler with breakpoint, please see the details in [1]. So I think we need something like below: static int test__sigtrap(struct test_suite *test __maybe_unused, int subtest __maybe_unused) { ... if (!BP_SIGNAL_IS_SUPPORTED) { pr_debug("Test not supported on this architecture"); return TEST_SKIP; } ... } Since we have defined BP_SIGNAL_IS_SUPPORTED, I think we can reuse it at here. [1] https://lore.kernel.org/lkml/157169993406.29376.12473771029179755767.tip-bot2@tip-bot2/ > And fails on my x86 broadwell machine: > > john@localhost:~/kernel-dev2/tools/perf> sudo ./perf test -v 73 > 73: Sigtrap : > --- start --- > test child forked, pid 22255 > FAILED sys_perf_event_open(): Argument list too long > test child finished with -1 > ---- end ---- > Sigtrap: FAILED! > john@localhost:~/kernel-dev2/tools/perf> It is a bit suprise for the failure on x86, as I remembered x86 platform can support signal handler with hw breakpoint. And from the error "Argument list too long", it should be a different issue from other archs. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel