linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2] drivers/virtio: Enable virtio mem for ARM64
       [not found] <20220118084858.175305-1-gshan@redhat.com>
@ 2022-01-18  9:38 ` Gavin Shan
  2022-01-18 16:05   ` Michael S. Tsirkin
  0 siblings, 1 reply; 3+ messages in thread
From: Gavin Shan @ 2022-01-18  9:38 UTC (permalink / raw)
  To: virtualization
  Cc: linux-arm-kernel, David Hildenbrand, Jonathan Cameron,
	Michael S. Tsirkin, Shan Gavin

On 1/18/22 4:48 PM, Gavin Shan wrote:
> This enables virtio-mem device support by allowing to enable the
> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
> architecture.
> 
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> ---
> v2: Improved the comments about the kernel config option (David)
> ---
>   drivers/virtio/Kconfig | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)

My git-sendemail should have been broken. A list of receivers are
dropped automatically though they were explicitly specified, but
linux-arm-kernel@lists.infradead.org was missed to be copied.
Fixing all of them through thunderbird :)

Thanks,
Gavin

> 
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 34f80b7a8a64..74c8b0c7bc33 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
>   config VIRTIO_MEM
>   	tristate "Virtio mem driver"
>   	default m
> -	depends on X86_64
> +	depends on X86_64 || ARM64
>   	depends on VIRTIO
>   	depends on MEMORY_HOTPLUG
>   	depends on MEMORY_HOTREMOVE
> @@ -116,8 +116,9 @@ config VIRTIO_MEM
>   	 This driver provides access to virtio-mem paravirtualized memory
>   	 devices, allowing to hotplug and hotunplug memory.
>   
> -	 This driver was only tested under x86-64, but should theoretically
> -	 work on all architectures that support memory hotplug and hotremove.
> +	 This driver was only tested under x86-64 and arm64, but should
> +	 theoretically work on all architectures that support memory hotplug
> +	 and hotremove.
>   
>   	 If unsure, say M.
>   
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] drivers/virtio: Enable virtio mem for ARM64
  2022-01-18  9:38 ` [PATCH v2] drivers/virtio: Enable virtio mem for ARM64 Gavin Shan
@ 2022-01-18 16:05   ` Michael S. Tsirkin
  2022-01-19  1:08     ` Gavin Shan
  0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2022-01-18 16:05 UTC (permalink / raw)
  To: Gavin Shan
  Cc: virtualization, linux-arm-kernel, David Hildenbrand,
	Jonathan Cameron, Shan Gavin

On Tue, Jan 18, 2022 at 05:38:20PM +0800, Gavin Shan wrote:
> On 1/18/22 4:48 PM, Gavin Shan wrote:
> > This enables virtio-mem device support by allowing to enable the
> > corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
> > architecture.
> > 
> > Signed-off-by: Gavin Shan <gshan@redhat.com>
> > Acked-by: David Hildenbrand <david@redhat.com>
> > ---
> > v2: Improved the comments about the kernel config option (David)
> > ---
> >   drivers/virtio/Kconfig | 7 ++++---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> My git-sendemail should have been broken. A list of receivers are
> dropped automatically though they were explicitly specified, but
> linux-arm-kernel@lists.infradead.org was missed to be copied.
> Fixing all of them through thunderbird :)
> 
> Thanks,
> Gavin

Pls bounce the original patch to me so I can queue it.


> > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > index 34f80b7a8a64..74c8b0c7bc33 100644
> > --- a/drivers/virtio/Kconfig
> > +++ b/drivers/virtio/Kconfig
> > @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
> >   config VIRTIO_MEM
> >   	tristate "Virtio mem driver"
> >   	default m
> > -	depends on X86_64
> > +	depends on X86_64 || ARM64
> >   	depends on VIRTIO
> >   	depends on MEMORY_HOTPLUG
> >   	depends on MEMORY_HOTREMOVE
> > @@ -116,8 +116,9 @@ config VIRTIO_MEM
> >   	 This driver provides access to virtio-mem paravirtualized memory
> >   	 devices, allowing to hotplug and hotunplug memory.
> > -	 This driver was only tested under x86-64, but should theoretically
> > -	 work on all architectures that support memory hotplug and hotremove.
> > +	 This driver was only tested under x86-64 and arm64, but should
> > +	 theoretically work on all architectures that support memory hotplug
> > +	 and hotremove.
> >   	 If unsure, say M.
> > 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] drivers/virtio: Enable virtio mem for ARM64
  2022-01-18 16:05   ` Michael S. Tsirkin
@ 2022-01-19  1:08     ` Gavin Shan
  0 siblings, 0 replies; 3+ messages in thread
From: Gavin Shan @ 2022-01-19  1:08 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: virtualization, linux-arm-kernel, David Hildenbrand,
	Jonathan Cameron, Shan Gavin

On 1/19/22 12:05 AM, Michael S. Tsirkin wrote:
> On Tue, Jan 18, 2022 at 05:38:20PM +0800, Gavin Shan wrote:
>> On 1/18/22 4:48 PM, Gavin Shan wrote:
>>> This enables virtio-mem device support by allowing to enable the
>>> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
>>> architecture.
>>>
>>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>>> Acked-by: David Hildenbrand <david@redhat.com>
>>> ---
>>> v2: Improved the comments about the kernel config option (David)
>>> ---
>>>    drivers/virtio/Kconfig | 7 ++++---
>>>    1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> My git-sendemail should have been broken. A list of receivers are
>> dropped automatically though they were explicitly specified, but
>> linux-arm-kernel@lists.infradead.org was missed to be copied.
>> Fixing all of them through thunderbird :)
>>
>> Thanks,
>> Gavin
> 
> Pls bounce the original patch to me so I can queue it.
> 

Yes, Please merge the following one, which was just posted. The ack-by
tags from Jonathan and you are also added to v3.

[PATCH v3] drivers/virtio: Enable virtio mem for ARM64

Thanks,
Gavin

> 
>>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>>> index 34f80b7a8a64..74c8b0c7bc33 100644
>>> --- a/drivers/virtio/Kconfig
>>> +++ b/drivers/virtio/Kconfig
>>> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
>>>    config VIRTIO_MEM
>>>    	tristate "Virtio mem driver"
>>>    	default m
>>> -	depends on X86_64
>>> +	depends on X86_64 || ARM64
>>>    	depends on VIRTIO
>>>    	depends on MEMORY_HOTPLUG
>>>    	depends on MEMORY_HOTREMOVE
>>> @@ -116,8 +116,9 @@ config VIRTIO_MEM
>>>    	 This driver provides access to virtio-mem paravirtualized memory
>>>    	 devices, allowing to hotplug and hotunplug memory.
>>> -	 This driver was only tested under x86-64, but should theoretically
>>> -	 work on all architectures that support memory hotplug and hotremove.
>>> +	 This driver was only tested under x86-64 and arm64, but should
>>> +	 theoretically work on all architectures that support memory hotplug
>>> +	 and hotremove.
>>>    	 If unsure, say M.
>>>
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-19  1:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20220118084858.175305-1-gshan@redhat.com>
2022-01-18  9:38 ` [PATCH v2] drivers/virtio: Enable virtio mem for ARM64 Gavin Shan
2022-01-18 16:05   ` Michael S. Tsirkin
2022-01-19  1:08     ` Gavin Shan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).