From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DE4BC433F5 for ; Tue, 18 Jan 2022 12:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IKezJqjlzG4xBa1a8zfeAn/50s8/bXYV2mdCNooSKAo=; b=gEwA9b+ot7M7K8 PitxsP7o2g1T7Z4YFYV0wqaCtXN5PDM7I0NQmON19ECflhVqvdAWpdsrBNHv4yJDZEw/ANmNLx7cJ rfgYDrasmLXZsL1JG78nsF57PFfJaOxbtCN+/ldwSbLfGP2MqiU6KTssrFPdjxrTM7yMk3O6MCuvk ZZZebeEs+leM6V9n59PT2rz4KYBg8Vi771JJV4Kri3VJcyaVxJiCw2w0qx+2KJKTadZLFuVABBJI7 WDQwRs34w+UKfEeilMkd+jnM2b21g2xs+E9VJ4Mu8TeTUU2Uo767A2t2/zfEaeQRtQL2loroDxB4h t7wRgxVea22DI1u13Z4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9nqE-001VL3-LY; Tue, 18 Jan 2022 12:44:02 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9nqA-001VJr-FA for linux-arm-kernel@lists.infradead.org; Tue, 18 Jan 2022 12:44:00 +0000 Received: by mail-ed1-x536.google.com with SMTP id cx27so5391369edb.1 for ; Tue, 18 Jan 2022 04:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rTGN2etA9k5qiSP7ZrVqfOL8gvgrJ9M1T4KKkJp0QWM=; b=GgxT31tFLd4a+OUKWDBAd70k8Yeeis6kDp5b2gHUS0rGPxK22UFqKkvQHm0U5/YGny WAI5UQZMbjfqyfhFAt3GUf5SW/PEDJsiYw9N45rxF6tP6Nh4J+6RNR/2alpDopSkfSN5 RcCdPiKochKA+ids16pdZwSQcj+xwNyCSwtpYaGzUTt7zdlLTEcvMm+itvOKBadIBs1C SN3Gf7iQ9Hcld3vlEWzY64gJGltq3voMpToPLBCArLOUrq4cgEzzjVDZvnFrgRvmwASO fY40TU7it9R2XzyyGOKm4uZft57FbbxvdnfMULLZTfa4jjfoJoBfeGtJAbQtw1czcSDM PsdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rTGN2etA9k5qiSP7ZrVqfOL8gvgrJ9M1T4KKkJp0QWM=; b=gFK5levs526KMHZ40THwf/D/DzHYSr9O0W3kDKbQReUMQHiTigMRfkEp0uoj/kNev/ zssaRHtyHFHwISWphYQZxpmJhx4Z3mhKhJts57EDu8IT/6eKQkreLU4JHkqOmrNGlKW3 HoIynhtPYEBcdhXK4pAQGTPN+330a7hqiiW7eUMM3i/MCnIQFe7+ICbQejroHzmSkwlQ elR1FRlOIMxdi3gNrBSg8FkQj+fjsqMUlALD9QM02ikOo5Nfhn2tOwbj08HtoX+3OrpY Oy/XV3YpS0RbPURLEmqMhYMCpCS1gWm3A2sucuwiIcmYPqTm2ymnLB9k3TZRY00259DY Ummg== X-Gm-Message-State: AOAM532KgcHPWjkdDaz2FpKyDAb2685Kri12NaQp7xxNTJ/MUn7EQZQb iJYL3H3iCYqRk1VpGOLcfUixgA== X-Google-Smtp-Source: ABdhPJz18wxKnoCux8+DSsMS7vloPGlf4s5356a/BEFnwnKL4xDDaTm/Qma52lDPuXb9GXYfzIVi+w== X-Received: by 2002:a17:906:9b87:: with SMTP id dd7mr19839112ejc.178.1642509830140; Tue, 18 Jan 2022 04:43:50 -0800 (PST) Received: from leoy-ThinkPad-X240s ([104.245.96.239]) by smtp.gmail.com with ESMTPSA id r27sm2379066ejc.42.2022.01.18.04.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 04:43:49 -0800 (PST) Date: Tue, 18 Jan 2022 20:43:43 +0800 From: Leo Yan To: Marco Elver Cc: John Garry , Thomas Richter , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, svens@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com, Will Deacon , Mark Rutland , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] perf test: Test 73 Sig_trap fails on s390 Message-ID: <20220118124343.GC98966@leoy-ThinkPad-X240s> References: <20211216151454.752066-1-tmricht@linux.ibm.com> <90efb5a9-612a-919e-cf2f-c528692d61e2@huawei.com> <20220118091827.GA98966@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_044358_540208_BDD34AA7 X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 18, 2022 at 12:40:04PM +0100, Marco Elver wrote: [...] > > Both Arm and Arm64 platforms cannot support signal handler with > > breakpoint, please see the details in [1]. So I think we need > > something like below: > > > > static int test__sigtrap(struct test_suite *test __maybe_unused, int subtest __maybe_unused) > > { > > ... > > > > if (!BP_SIGNAL_IS_SUPPORTED) { > > pr_debug("Test not supported on this architecture"); > > return TEST_SKIP; > > } > > > > ... > > } > > > > Since we have defined BP_SIGNAL_IS_SUPPORTED, I think we can reuse it at > > here. > > > > [1] https://lore.kernel.org/lkml/157169993406.29376.12473771029179755767.tip-bot2@tip-bot2/ > > Does this limitation also exist for address watchpoints? The sigtrap > test does not make use of instruction breakpoints, but instead just > sets up a watchpoint on access to a data address. Yes, after reading the code, the flow for either instrution breakpoint or watchpoint both use the single step [1], thus the signal handler will take the single step execution and lead to the infinite loop. I am not the best person to answer this question; @Will, could you confirm for this? Thanks! Leo [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/kernel/hw_breakpoint.c _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel