From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18138C433EF for ; Tue, 18 Jan 2022 18:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C0B/WaKqhWDDurLYwxk0n7eBhM8qvtMh6hCXpESbNdA=; b=C1pTeeiP/n2r+f +u5jmFeuu7LiH5CikMyFK1/KzYg4babmA0jFDIe4uOx2/FSsZA+XpXiFdF4XfCx6wDjglcdj3CcTB gerd73Y1eBpYf5mYXK7yItrRR/4PR0bwsd35Ct3Ynfx2EV8gBq1GHzTsxyGZ1PA/NUaVzh/vPd2yz RYjj9THVgcarZ4P4zbLA1Cs6tiUGNllGrS3mdHMimWsB+xVf9ZOEgwL0nfmTGGQv2rV96aXiXsXwr aET6OA04ZQ80NgKcAaymlmRBnkQn/U7mQGrlBIyYIJKbCLr22nfCu7M2Ut/yF1FQ4A7XrEZd6ZY+J nyry25r6HpggTmL/NDqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9tYp-002edK-DY; Tue, 18 Jan 2022 18:50:27 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9tYk-002ebx-QR for linux-arm-kernel@lists.infradead.org; Tue, 18 Jan 2022 18:50:24 +0000 Received: by mail-pj1-x1029.google.com with SMTP id d12-20020a17090a628c00b001b4f47e2f51so417718pjj.3 for ; Tue, 18 Jan 2022 10:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hyUFOt/DRN/Ski8ME3oR/RR/GlHotAPBehInw4A8rwg=; b=y0uHrHAf2EdqIaf/AqU82TqNKrpbwUkXwrbqc6KO03IC76LIlrawu1QkyCK7VawJIr ayt647OaYmn2qHUROh/897uhEy0KbOrkrbqej+Q5WoqiRb0TiG6py3+iYqHDWf1V8X7V PCPCCfXKm3viwQEnTbnqe9Hmvx1VxNUkOa0NwoTmfUAtHQ7xNDJVaeY7TbE2SJ6J5kuu 75U8FZSMBUPGqizJxOentmcFNl7FOnpt5ykfIxpmzOPW+81qsNoHASPIiv9Ag0m91pYO A7PMhk6fvhY2M+gk3AqzeeVbmDAR4ZQbksIaWPq0JOO6KlRRJ7BkspSL/eeHwxGWWUuR 0W9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hyUFOt/DRN/Ski8ME3oR/RR/GlHotAPBehInw4A8rwg=; b=UORlWiRjEUrVxIXqYC4DyeukHXLJKAlMflWe1fR5P7L8HrPae8YQJedRLZL2tQwA+W texlHhzK6QWRXRL8rOK8e2PRrotn1LvoyHaTzkD1fXi8H6SzWBOgvbh5CwSRfTWgVkiX g1HcRTamuWRTAEtieciJ6hfFqHQGSRBRlULJGM/WCkOOjkaD8MXFoWY0pIukZfGfocgC Ya+qAXAcJscjsJHF4i4PlnaXCVpf/8R4olR2q4i8+NepB3aow8Jv0vmLqIHyE8++pzKf FS227BkDMP4ssm0z7mpzq6uS7UCEYCRgWb5RbIkS00CbrVy8DlOPKIEWxHmT0ScgDuR7 3/Hg== X-Gm-Message-State: AOAM5300tWRxNONMZlBqQpLzXzilKIFhTJNvvOVwPAknMFymse9kq4RR y8YRasLm87hfCZH9Br71PgQE2Q== X-Google-Smtp-Source: ABdhPJyENdKr8qIAthVQEawv5CUFjquAyiYxPmTNdkS3Ztf2vdRDQRZu+ZJIjFg7sqSDSNJxNt8pNQ== X-Received: by 2002:a17:902:b598:b0:14a:ca21:9737 with SMTP id a24-20020a170902b59800b0014aca219737mr7192664pls.73.1642531822281; Tue, 18 Jan 2022 10:50:22 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id q64sm3472329pjk.8.2022.01.18.10.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 10:50:21 -0800 (PST) Date: Tue, 18 Jan 2022 11:50:19 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 5/9] remoteproc: imx_rproc: make clk optional Message-ID: <20220118185019.GG1119324@p14s> References: <20220111033333.403448-1-peng.fan@oss.nxp.com> <20220111033333.403448-8-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220111033333.403448-8-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_105022_884034_C401AA09 X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 11, 2022 at 11:33:29AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > To i.MX8QXP/QM/ULP and i.MX7ULP, Mcore maybe out of control of Linux. > And in such case, no need clk, so make clk optional with has_clk. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 7b2578177ea8..0e99a3ca6fbc 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -89,6 +89,7 @@ struct imx_rproc { > struct work_struct rproc_work; > struct workqueue_struct *workqueue; > void __iomem *rsc_table; > + bool has_clk; I am usually weary of bloating structures with flags. I suggest achieving the same functionality with a macro that compares priv->dcfg with the right imx_rproc_dcfg structure. > }; > > static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { > @@ -724,6 +725,9 @@ static int imx_rproc_clk_enable(struct imx_rproc *priv) > if (dcfg->method == IMX_RPROC_NONE) > return 0; > > + if (!priv->has_clk) > + return 0; > + > priv->clk = devm_clk_get(dev, NULL); > if (IS_ERR(priv->clk)) { > dev_err(dev, "Failed to get clock\n"); > @@ -768,6 +772,7 @@ static int imx_rproc_probe(struct platform_device *pdev) > priv->rproc = rproc; > priv->dcfg = dcfg; > priv->dev = dev; > + priv->has_clk = true; > > dev_set_drvdata(dev, rproc); > priv->workqueue = create_workqueue(dev_name(dev)); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel