From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57BFDC433F5 for ; Tue, 18 Jan 2022 23:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mzUQY7wasyo0FfcPooOUFP8H4ENpLLTQLRK7EzbkFLc=; b=gqkwP2rHxyjp6Z TISkCBYvooMLZRtbt/KNOGH3rxc/PqRDkBFGmIl2QtuJMjRbDzepMEn/Y62RUuHMh1O0H1vskZQzI +R6hkkkT6StScWI+SzJ3tCK1cS+24joLtxUBEvkGzg2pkh9XxIE2L4o6dKluOkmB8yWsA0kadr0yA awdAmrQHz+td0cl3L7mPk47+xiJA4l53OpcD3hDq5BKJPsuj13IvwzWi69s0rSMD2+cyefZ5aEpeW 0frz3ddEknB4LEK6mJc42MFFXYib/f/UmYj5p0HuTpPpx/StcyYz6gNoV9F0+5ycEzxEY7wYVVjG9 AoEWoyxmNvI6KLUqoUbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9yHY-003I2U-5H; Tue, 18 Jan 2022 23:52:56 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9yHU-003I1l-QF for linux-arm-kernel@lists.infradead.org; Tue, 18 Jan 2022 23:52:54 +0000 Received: by mail-pj1-x102d.google.com with SMTP id pf13so850720pjb.0 for ; Tue, 18 Jan 2022 15:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4/RjK8BN3JSAYkOl/QC9o65LtcnAhU3UXdD1BgVr6Dc=; b=I3JK5GxKJNosEutNRJEjnFEOYFwZ1QUsNrU8p+R6GhPQVxZou96OUTOJJJNUYvUXlI djYqsWuuEpIwlotwaIt6WThuRViY62QjMtOAC3oESQLeE07JPBa7iENB1R8NVtCdVozp KPhBoyoOoL+vLpnNDQRI2pTsZRefcPiWZD+vMtgXegOqwK8dmBlhC1pKrzn2n33WalQ6 u8I5lEIHn3e2WkVkySHo1yLDA/aqfeiJdTWy/oT2R7IK5/7BoD4gUBn88IlHzHMIwl5L tFptvPjevkIe/BK90fAKEO/eaOhkO2+zfCLCyHh4/USxnftehM/1SGXMrANgce6HlDQx gWXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4/RjK8BN3JSAYkOl/QC9o65LtcnAhU3UXdD1BgVr6Dc=; b=s1Gr3b2QddPxo4u0f58rrfQ8bTyE0IxY8hQ8zMjV4an8w0LX0+ZO9Ju+a15C2H3S4N zI5xEq75ZsIiAMkf8CZdVNsKriLAigAAcaJO1eND5hh+vN7hISYhWR6B2gHkKyqBKt4f SW89iPfpEb0PA6rzs1Q1R6fGY5Fr3/9dn7J6o2HmwP8Mo6UvOWOkFns1kOYOi+Fr9c14 fZL5vnLzYz90pXbYuB4qorVI9blF8jUKNpBALlB1ylZTpBu6myrLBElU9Pj74oxWXWrW TGPYhwjYSrSk2GqDen7VoZ3XBm9oYbrYz1iEMRa8YBWuuxVQ33sra97BkGztdXK4d3it HV6Q== X-Gm-Message-State: AOAM532e0G3ts41dzsT3vVBczHF/iDNUpXusYcQuLB8MZT5KA30UFDZV mgErewExKaB8Jdxf2YMydZ0= X-Google-Smtp-Source: ABdhPJxiD2bVrhbvfdZNgIib+nJd6p1sFBUR9Rc3MGJm0eXE85gtCHvnl1zU6KKl3ctqvAbPK7LMAA== X-Received: by 2002:a17:903:32c4:b0:14a:67ae:3e03 with SMTP id i4-20020a17090332c400b0014a67ae3e03mr29666243plr.111.1642549971771; Tue, 18 Jan 2022 15:52:51 -0800 (PST) Received: from localhost (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id h4sm18962329pfi.79.2022.01.18.15.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 15:52:51 -0800 (PST) From: Yury Norov To: Catalin Marinas , Will Deacon , Andrew Morton , Nicholas Piggin , Ding Tianhong , Anshuman Khandual , Matthew Wilcox , Alexey Klimov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Yury Norov Subject: [PATCH] vmap(): don't allow invalid pages Date: Tue, 18 Jan 2022 15:52:44 -0800 Message-Id: <20220118235244.540103-1-yury.norov@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_155252_907727_E1D80691 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org vmap() takes struct page *pages as one of arguments, and user may provide an invalid pointer which would lead to DABT at address translation later. Currently, kernel checks the pages against NULL. In my case, however, the address was not NULL, and was big enough so that the hardware generated Address Size Abort on arm64. Interestingly, this abort happens even if copy_from_kernel_nofault() is used, which is quite inconvenient for debugging purposes. This patch adds a pfn_valid() check into vmap() path, so that invalid mapping will not be created. RFC: https://lkml.org/lkml/2022/1/18/815 v1: use pfn_valid() instead of adding an arch-specific arch_vmap_page_valid(). Thanks to Matthew Wilcox for the hint. Signed-off-by: Yury Norov --- mm/vmalloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index d2a00ad4e1dd..a4134ee56b10 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -477,6 +477,8 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, return -EBUSY; if (WARN_ON(!page)) return -ENOMEM; + if (WARN_ON(!pfn_valid(page_to_pfn(page)))) + return -EINVAL; set_pte_at(&init_mm, addr, pte, mk_pte(page, prot)); (*nr)++; } while (pte++, addr += PAGE_SIZE, addr != end); -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel