From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4A53C433EF for ; Thu, 20 Jan 2022 17:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qs4X9j+UBRsPqEKNas4gzMEGQmDhzoAI9idlaZR/6oQ=; b=yhM2j4s2I+hh8b dSOzENPe/CAmXh91uSCESJdonqqfX17y4YkcLKtUOxmnUBt/k1numoJIa+1L+hx5FUZgncSJSNDGq SLHDSXiP+vegXiPyXgUs3li1nTTQFtPQdDhpJifdy2sjTed2JTKtstyKwhxGtvzHWwLiofcQB20jw Ju5VC1pvzbmJxSKYRbUP4VXjzDBeXz23i0XzalVS0cw9XzZnNo7mXseVw/Borlkb0zAgmLjKShNl6 6Tnq/fgWJKUZDV59ULEinMSjTee9k/CSS4npsQCx5r1bAazF4VJ/ai0818RAcRpeqCt81NnTKqSf0 5EVAmlNeWVPWXLrqUI7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAbWb-00Cdlf-Oa; Thu, 20 Jan 2022 17:47:05 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAbWX-00CdkJ-Le for linux-arm-kernel@lists.infradead.org; Thu, 20 Jan 2022 17:47:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 58C5EB81D84; Thu, 20 Jan 2022 17:47:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03D39C340E0; Thu, 20 Jan 2022 17:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642700819; bh=wSf8OiMW4H7ZByPYpbf7xGHEeGKTbXxwwwZCQd5TYeM=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=VXMuBhfX4fLq81QPayP6nFp9cMohHmJYH7Addm7wUCo8AAD4JVJcDm0xEoB7hENbt oTGVcKMR41/kugSUkzi07ry3cWsNSPvfTdOFcwV1Qj675Av9KYEz7xG6Et2Say7+nQ Dp8mCxp+j8xL2w7YwETJ2cReSRIBD7m+edE7+fwgl2RbditWdC8VchD6a6ze+KkMFf MGGKkLepaGi4GxGsTzOhJnQ7M9RbyQZiYpf2zkGyeLygz15oxf+wnYayQ8Z2iOgxb2 iI9aJPLMFZWq0RxUUY3tU6+rgM+ok9oddgC6xjVx1kvnJoYRo+0i+YofgidBgMOiYx rKYoP0mi2gpYA== MIME-Version: 1.0 In-Reply-To: <016c01d80e05$1ef9eab0$5cedc010$@samsung.com> References: <20220118144851.69537-1-alim.akhtar@samsung.com> <20220118144851.69537-5-alim.akhtar@samsung.com> <20220119201509.6220FC004E1@smtp.kernel.org> <016c01d80e05$1ef9eab0$5cedc010$@samsung.com> Subject: RE: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support From: Stephen Boyd Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, arnd@arndb.de, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com, 'Jayati Sahu' , 'Ajay Kumar' To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 20 Jan 2022 09:46:57 -0800 User-Agent: alot/0.10 Message-Id: <20220120174659.03D39C340E0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220120_094702_008752_A591859D X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Alim Akhtar (2022-01-20 05:53:31) > Hi Stephen > > >-----Original Message----- > >From: Stephen Boyd [mailto:sboyd@kernel.org] > >Sent: Thursday, January 20, 2022 1:45 AM > >To: Alim Akhtar ; linux-arm- > >kernel@lists.infradead.org; linux-kernel@vger.kernel.org > >Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; > >olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org; > >catalin.marinas@arm.com; robh+dt@kernel.org; > >krzysztof.kozlowski@canonical.com; s.nawrocki@samsung.com; linux- > >samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; Alim Akhtar > >; linux-fsd@tesla.com; Jayati Sahu > >; Ajay Kumar > >Subject: Re: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support > > > >Quoting Alim Akhtar (2022-01-18 06:48:39) > >> diff --git a/drivers/clk/samsung/clk-fsd.c > >> b/drivers/clk/samsung/clk-fsd.c new file mode 100644 index > >> 000000000000..2669396d81b9 > >> --- /dev/null > >> +++ b/drivers/clk/samsung/clk-fsd.c > >> @@ -0,0 +1,308 @@ > >> +// SPDX-License-Identifier: GPL-2.0-only > >> +/* > >> + * Copyright (c) 2017-2022 Samsung Electronics Co., Ltd. > >> + * https://www.samsung.com > >> + * Copyright (c) 2017-2022 Tesla, Inc. > >> + * https://www.tesla.com > >> + * > >> + * Common Clock Framework support for FSD SoC. > >> + */ > >> + > >> +#include > >> +#include > > > >include init.h for __initconst and kernel.h for ARRAY_SIZE > > > I did not face any compilation error. > Do I need to explicitly add these header files in driver? I see clk.h implicitly includes kernel.h > Same is the case of other driver in this directory. Yes they should be included. Depending on implicit includes leads to pain later when that include is moved out of the header and compilation breaks here. Include what you use, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel