From: Leo Yan <leo.yan@linaro.org>
To: Jiankang Chen <jkchen@linux.alibaba.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki.Poulose@arm.com, linux-arm-kernel@lists.infradead.org,
coresight@lists.linaro.org, mike.leach@linaro.org,
zhangliguang@linux.alibaba.com
Subject: Re: [PATCH] coresight: tmc: change device registration from misc to cdev
Date: Tue, 25 Jan 2022 14:54:32 +0800 [thread overview]
Message-ID: <20220125065432.GA370774@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <117e6569-bd2e-830a-70e3-dd26dfae26c8@linux.alibaba.com>
Hi Jay,
On Tue, Jan 25, 2022 at 10:33:45AM +0800, Jiankang Chen wrote:
> Hi Mathieu
>
> 在 2022/1/25 04:08, Mathieu Poirier 写道:
> > On Mon, 24 Jan 2022 at 04:00, Jay Chen <jkchen@linux.alibaba.com> wrote:
> > > Currently, there are 130 etr and etf on our machine,
> > > but the current coresight tmc driver uses misc_register
> > > to register the device, which leads to the error that
> > > the device number is not enough.
> > >
> > > coresight-tmc: probe of xxxxx failed with error -16
> > >
> > > This patch changes the device registration method
> > > to cdev's dynamic registration method to solve the
> > > problem of insufficient device numbers.
> > This patch is still not labelled properly and as such being dropped.
>
> Hello, about the label of this patch, what kind of patch should I add?
You could use "git format" command with option "-v" to add the version
number, e.g. if you are committing patch version 4, so you can generate
patch like:
$ git format-patch HEAD~1 -v4
Or if you want to generate patch for a specific commit:
$ git format-patch -1 patch_commit -v4
Every time when you generate a new version's patch, you could
increment the version number with option "-v4", "-v5", and so on.
P.s. I strongly suggest Marc Zyngier's great talk for how to upstream
kernel patch in a good way:
https://events19.linuxfoundation.org/wp-content/uploads/2017/12/Getting-Your-Patches-in-Mainline-Linux-What-Not-To-Do-and-a-Few-Things-You-Could-Try-Instead-Marc-Zyngier-ARM.pdf
Thanks,
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-25 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 11:00 [PATCH] coresight: tmc: change device registration from misc to cdev Jay Chen
2022-01-24 20:08 ` Mathieu Poirier
2022-01-25 2:33 ` Jiankang Chen
2022-01-25 6:54 ` Leo Yan [this message]
2022-01-25 16:46 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125065432.GA370774@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=Suzuki.Poulose@arm.com \
--cc=coresight@lists.linaro.org \
--cc=jkchen@linux.alibaba.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox