From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F4FCC433F5 for ; Tue, 25 Jan 2022 08:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fqgyXaZjf/pYA7gVEPYUp0JAk7x9x9k1cHjBtHGGbT8=; b=Gb29itJZAZPc+X Pg1Pys2r1YcWpuX3PqanJesjs1E65tOqB7erAgcc3ywgFepTwCj7GwBYNCl9/sRE07ggMIYi1TWi1 MsbR1gOdgd+xiLlRaagWAeZG+4ZORsEVxGD1U25G/6sNpXeNrooJ0pXe8STa9vWlbA3SbxRCFdeJd cZnotjGAgz6KUi0X5ttgDp5xJw1921cJTxGfoXZDa8yIZl3RCUjmBmskAffpnA1McuAwu6yVFDzgg nTC7KmZmTseX+IxAwGtVEl3kumX5ymTsa913C60Pe+AVDZqybCWC3U7o7pMhFGBsiygNVEpb2iIdp CY++KW7XafzOnKv6CANg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCH4t-006qYy-Fh; Tue, 25 Jan 2022 08:21:23 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCH4q-006qYH-3e for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 08:21:21 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCH4f-0000Fb-LA; Tue, 25 Jan 2022 09:21:09 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nCH4e-0001We-GG; Tue, 25 Jan 2022 09:21:08 +0100 Date: Tue, 25 Jan 2022 09:21:08 +0100 From: Michael Tretter To: Robert Hancock Cc: linux-iio@vger.kernel.org, robh+dt@kernel.org, michal.simek@xilinx.com, anand.ashok.dumbre@xilinx.com, jic23@kernel.org, lars@metafoo.de, manish.narani@xilinx.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings Message-ID: <20220125082108.GE25856@pengutronix.de> References: <20220120010246.3794962-1-robert.hancock@calian.com> <20220120010246.3794962-4-robert.hancock@calian.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220120010246.3794962-4-robert.hancock@calian.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:17:51 up 45 days, 17:03, 75 users, load average: 0.09, 0.13, 0.22 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_002120_171644_1EA32D5E X-CRM114-Status: GOOD ( 20.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 19 Jan 2022 19:02:45 -0600, Robert Hancock wrote: > Register settings used for the sequencer configuration register > were incorrect, causing some inputs to not be read properly. > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > Signed-off-by: Robert Hancock > --- > drivers/iio/adc/xilinx-ams.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > index b93864362dac..199027c93cdc 100644 > --- a/drivers/iio/adc/xilinx-ams.c > +++ b/drivers/iio/adc/xilinx-ams.c > @@ -91,8 +91,8 @@ > > #define AMS_CONF1_SEQ_MASK GENMASK(15, 12) > #define AMS_CONF1_SEQ_DEFAULT FIELD_PREP(AMS_CONF1_SEQ_MASK, 0) > -#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 1) > -#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) > +#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) > +#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, 3) The TRM states that Continuous Loop Mode is 2, but Single Pass Sequence Mode is 1, not 3. Is there a reason, why you need to set both bits? Michael > > #define AMS_REG_SEQ0_MASK GENMASK(15, 0) > #define AMS_REG_SEQ2_MASK GENMASK(21, 16) > -- > 2.31.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel