From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8ACEC28CF5 for ; Wed, 26 Jan 2022 07:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U0+gdB1xZmOtcVRHZK3im6+zPSxLX1FN8MdUHa8n+z4=; b=xMLs6uc9ya4DXJ f4sf7jRXFu0nBJ7w2LHzW6q/Un+2pWT1+xi1D+pUYL2+vdTkp0cKEhksmUOWYqxbxg7410oV/DUib kM6h3ApKZRaBUE3stfzBg2h7lAcqSi5gnulJ8dPNfdv9wBsBC27YbAlB0Lx0ewKMd+yBVKUs4eTyq NherlHiNJN9CRRTeQhSHuaV4RFzlF46olXW6ynT+2c3k5QVWUjaDpx/yWZXJYipjQlyMMj5EeGNLY DQXV7JvNTP526ZXnnJeWAizJU0BuZFLf/MazGw+EoL6jDLXW6DmI6huwJJmzinUbSYMxqrgK8Cua9 I8yf2SEjVMoZJP8kVUqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCcVI-00ARvW-HM; Wed, 26 Jan 2022 07:14:04 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCcV9-00ARtX-U1; Wed, 26 Jan 2022 07:13:57 +0000 X-UUID: 9e939d29a36e4d4fad877e19f338b55f-20220126 X-UUID: 9e939d29a36e4d4fad877e19f338b55f-20220126 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1563888255; Wed, 26 Jan 2022 00:13:52 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 25 Jan 2022 23:13:51 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 26 Jan 2022 15:13:49 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 26 Jan 2022 15:13:49 +0800 From: Miles Chen To: CC: , , , , , , , Subject: Re: [PATCH 19/31] clk: mediatek: Add mtk_clk_simple_remove() Date: Wed, 26 Jan 2022 15:13:49 +0800 Message-ID: <20220126071349.1118-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220122091731.283592-20-wenst@chromium.org> References: <20220122091731.283592-20-wenst@chromium.org> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_231356_008617_93783A41 X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > In commit c58cd0e40ffa ("clk: mediatek: Add mtk_clk_simple_probe() to > simplify clock providers"), a generic probe function was added to > simplify clk drivers that only needed to support clk gates. However due > to the lack of unregister APIs, a corresponding remove function was not > added. > > Now that the unregister APIs have been implemented, add aforementioned > remove function to make it complete. > > Signed-off-by: Chen-Yu Tsai Reviewed-by: Miles Chen > --- > drivers/clk/mediatek/clk-mtk.c | 15 +++++++++++++++ > drivers/clk/mediatek/clk-mtk.h | 1 + > 2 files changed, 16 insertions(+) > > diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c > index 2150ed8678e0..cd76e1d80242 100644 > --- a/drivers/clk/mediatek/clk-mtk.c > +++ b/drivers/clk/mediatek/clk-mtk.c > @@ -369,6 +369,8 @@ int mtk_clk_simple_probe(struct platform_device *pdev) > if (r) > goto free_data; > > + platform_set_drvdata(pdev, clk_data); > + > return r; > > free_data: > @@ -376,4 +378,17 @@ int mtk_clk_simple_probe(struct platform_device *pdev) > return r; > } > > +int mtk_clk_simple_remove(struct platform_device *pdev) > +{ > + const struct mtk_clk_desc *mcd = of_device_get_match_data(&pdev->dev); > + struct clk_onecell_data *clk_data = platform_get_drvdata(pdev); > + struct device_node *node = pdev->dev.of_node; > + > + of_clk_del_provider(node); > + mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data); > + mtk_free_clk_data(clk_data); > + > + return 0; > +} > + > MODULE_LICENSE("GPL"); > diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h > index 3c3a934f53cd..4fa658f5d934 100644 > --- a/drivers/clk/mediatek/clk-mtk.h > +++ b/drivers/clk/mediatek/clk-mtk.h > @@ -202,5 +202,6 @@ struct mtk_clk_desc { > }; > > int mtk_clk_simple_probe(struct platform_device *pdev); > +int mtk_clk_simple_remove(struct platform_device *pdev); > > #endif /* __DRV_CLK_MTK_H */ > -- > 2.35.0.rc0.227.g00780c9af4-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel