From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4504EC63684 for ; Wed, 26 Jan 2022 07:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IidYMW0RI2Ir01ocjznupvUsTVaIyhCby2U/SiMSLvk=; b=Jfn12MOqFDLM+I 29blOh9w0dppnuWnIK11bPzkG5+zjFViFs83GHPdpkf8a2a/MDgWX7rMtkdQGVhpN+wZikqri0RNM S9rNyajz3MA+kCy0L3Fso1mw3QFxhSlUU45vHovtGLeC1n06I236ksBfLTST/CmPv3Ulu5QhQ5RzX 63eYVknDpNhlmg+E79r//AxBdBh8vpjhj7ZxFfoYPNFACYnWeXdNV0dLtTAtvQrOXRGaXcapaXdU4 z3tYqtAtQ4TXVAi1qM/WSN7ktpO/yVbTIcmVCF1AozqshIFSsj/tQORhayHIm7rQWs0Of8UdgiO/q 7o+Ncxtz3v3mJH8JRNKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCcrZ-00AZst-Ov; Wed, 26 Jan 2022 07:37:06 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCcrT-00AZqu-Jq; Wed, 26 Jan 2022 07:37:03 +0000 X-UUID: bccfde4bdf604cdea64d51f3869f98b2-20220126 X-UUID: bccfde4bdf604cdea64d51f3869f98b2-20220126 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 649893314; Wed, 26 Jan 2022 00:36:56 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 25 Jan 2022 23:26:54 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Wed, 26 Jan 2022 15:26:47 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 26 Jan 2022 15:26:47 +0800 From: Miles Chen To: CC: , , , , , , , Subject: Re: [PATCH 20/31] clk: mediatek: mtk: Clean up included headers Date: Wed, 26 Jan 2022 15:26:47 +0800 Message-ID: <20220126072647.8794-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220122091731.283592-21-wenst@chromium.org> References: <20220122091731.283592-21-wenst@chromium.org> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_233659_698056_AA487B87 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Some included headers aren't actually used anywhere, while other headers > with the declaration of functions and structures aren't directly > included. > > Get rid of the unused ones, and add the ones that should be included > directly. > > On the header side, replace headers that are included purely for data > structure definitions with forward declarations. This decreases the > amount of preprocessing and compilation effort required for each > inclusion. > > Signed-off-by: Chen-Yu Tsai Reviewed-by: Miles Chen > --- > drivers/clk/mediatek/clk-mtk.c | 13 ++++++------- > drivers/clk/mediatek/clk-mtk.h | 12 ++++++------ > 2 files changed, 12 insertions(+), 13 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c > index cd76e1d80242..d2c50186cceb 100644 > --- a/drivers/clk/mediatek/clk-mtk.c > +++ b/drivers/clk/mediatek/clk-mtk.c > @@ -4,17 +4,16 @@ > * Author: James Liao > */ > > -#include > -#include > +#include > +#include > #include > #include > -#include > -#include > -#include > -#include > #include > -#include > +#include > +#include > #include > +#include > +#include > > #include "clk-mtk.h" > #include "clk-gate.h" > diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h > index 4fa658f5d934..7f902581a115 100644 > --- a/drivers/clk/mediatek/clk-mtk.h > +++ b/drivers/clk/mediatek/clk-mtk.h > @@ -7,19 +7,19 @@ > #ifndef __DRV_CLK_MTK_H > #define __DRV_CLK_MTK_H > > -#include > -#include > #include > -#include > - > -struct clk; > -struct clk_onecell_data; > +#include > +#include > +#include > +#include > > #define MAX_MUX_GATE_BIT 31 > #define INVALID_MUX_GATE_BIT (MAX_MUX_GATE_BIT + 1) > > #define MHZ (1000 * 1000) > > +struct platform_device; > + > struct mtk_fixed_clk { > int id; > const char *name; > -- > 2.35.0.rc0.227.g00780c9af4-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel