From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82A52C28CF5 for ; Wed, 26 Jan 2022 09:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x3GrBJHQhh9Y3Gnp6ndML1pUxvEfcaGSo38WXRNl6AQ=; b=nCjQxsdJSjod+C vmWx3Rl1/JkFcoi3pGJSqjGFwL+YcKxHIpdcNpzx93228zFetR7clYhM3CxifPEqkrSOw8/MJjW7q Y8rvzgdiYaj0ObHa4tDVAEUOpi+Hptqf3cIdvhy5UvghT3KjG0l+95hLdMhWBhuoZzLUiRcBb67BP Apgg8eCpwKuXb84suaH29kYUrcL/pm15yiH9q/QgnjEnuigH1UI1v47k70Rt7FIE1EvmVz18t3/MF x9HJ62ef6JA++YoGF5v8WomMp/N+OXIN+4GucjJEUM7nGH4BLXw40mEx9PlpMdpww7xXq0X+LQxzT mVvcP6ZBAybO5Rv4rGsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCeMb-00Asxd-Fe; Wed, 26 Jan 2022 09:13:14 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCeMV-00Asuu-S4 for linux-arm-kernel@lists.infradead.org; Wed, 26 Jan 2022 09:13:09 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCeMH-0002MY-Kx; Wed, 26 Jan 2022 10:12:53 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nCeME-00026i-OU; Wed, 26 Jan 2022 10:12:50 +0100 Date: Wed, 26 Jan 2022 10:12:50 +0100 From: Michael Tretter To: Robert Hancock Cc: "lars@metafoo.de" , "robh+dt@kernel.org" , "jic23@kernel.org" , "devicetree@vger.kernel.org" , "michal.simek@xilinx.com" , "linux-iio@vger.kernel.org" , "manish.narani@xilinx.com" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "anand.ashok.dumbre@xilinx.com" Subject: Re: [PATCH 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings Message-ID: <20220126091250.GC2550@pengutronix.de> References: <20220120010246.3794962-1-robert.hancock@calian.com> <20220120010246.3794962-4-robert.hancock@calian.com> <20220125082108.GE25856@pengutronix.de> <4c5fb3899a8aafa34106a668bcb2807b6f073036.camel@calian.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4c5fb3899a8aafa34106a668bcb2807b6f073036.camel@calian.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:10:37 up 46 days, 17:56, 80 users, load average: 0.43, 0.21, 0.19 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_011307_944586_AE599267 X-CRM114-Status: GOOD ( 27.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 25 Jan 2022 16:15:05 +0000, Robert Hancock wrote: > On Tue, 2022-01-25 at 09:21 +0100, Michael Tretter wrote: > > On Wed, 19 Jan 2022 19:02:45 -0600, Robert Hancock wrote: > > > Register settings used for the sequencer configuration register > > > were incorrect, causing some inputs to not be read properly. > > > > > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > > > Signed-off-by: Robert Hancock > > > --- > > > drivers/iio/adc/xilinx-ams.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > > > index b93864362dac..199027c93cdc 100644 > > > --- a/drivers/iio/adc/xilinx-ams.c > > > +++ b/drivers/iio/adc/xilinx-ams.c > > > @@ -91,8 +91,8 @@ > > > > > > #define AMS_CONF1_SEQ_MASK GENMASK(15, 12) > > > #define AMS_CONF1_SEQ_DEFAULT FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > 0) > > > -#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 1) > > > -#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > 2) > > > +#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) > > > +#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > 3) > > > > The TRM states that Continuous Loop Mode is 2, but Single Pass Sequence Mode > > is 1, not 3. Is there a reason, why you need to set both bits? > > Single pass sequence mode (1) just runs the same sequence only once. To read > these values it needs to switch to single channel mode (3). > > The register bits are defined in Table 3-8 of > https://www.xilinx.com/support/documentation/user_guides/ug580-ultrascale-sysmon.pdf > . Thanks for the clarification. Reviewed-by: Michael Tretter > > > > > Michael > > > > > > > > #define AMS_REG_SEQ0_MASK GENMASK(15, 0) > > > #define AMS_REG_SEQ2_MASK GENMASK(21, 16) > > > -- > > > 2.31.1 > > > > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-arm-kernel__;!!IOGos0k!yGFEjSC1BL20lwurby914len0HCLXyzarwxKJP9Jx30qv_qrERSkRJUiVo_2MdusMVA$ > > > > -- > Robert Hancock > Senior Hardware Designer, Calian Advanced Technologies > www.calian.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel