From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo
Date: Wed, 26 Jan 2022 21:02:56 +0800 [thread overview]
Message-ID: <20220126130255.GU4686@dragon> (raw)
In-Reply-To: <24f1010a-a722-c931-57e1-ee26e74296d4@denx.de>
On Wed, Jan 26, 2022 at 01:39:00PM +0100, Marek Vasut wrote:
> On 1/26/22 13:19, Shawn Guo wrote:
> > On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:
> > > The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
> > > Describe this bridge in DT, otherwise the DT incorrectly describes
> > > DPI panel attached directly to LVDS source.
> > >
> > > Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > ---
> > > arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
> > > 1 file changed, 25 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> > > index 4f88e96d81dd..a1eb36229ef8 100644
> > > --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> > > +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> > > @@ -53,6 +53,29 @@ eth {
> > > };
> > > };
> > > + lvds-decoder {
> > > + compatible = "ti,ds90cf364a", "lvds-decoder";
> >
> > Is this "ti,ds90cf364a" documented anywhere?
>
> Here is a RB'd patch, currently waiting for someone from dri-devel to pick
> it:
>
> https://patchwork.freedesktop.org/series/98203/
I will have to wait till it lands.
Shawn
>
> > > +
> > > + ports {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + port@0 {
> > > + reg = <0>;
> >
> > Please have a newline between property and child node.
>
> Maybe you can fix this up when applying ?
>
> Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-26 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 15:25 [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo Marek Vasut
2021-12-18 15:36 ` Fabio Estevam
2022-01-26 12:19 ` Shawn Guo
2022-01-26 12:39 ` Marek Vasut
2022-01-26 13:02 ` Shawn Guo [this message]
2022-01-26 13:35 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126130255.GU4686@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).