From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 014B4C433F5 for ; Thu, 27 Jan 2022 01:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XE34qQ1IFt59wm5+eSZndJ3gHPiI3YL4IUqL0hAXS3k=; b=WMT6vWeXpSeIb7 6MHAdJywtP0tb5hDWW23gGkRJumjnloMP8chQDFIFpY6v0K/G752MApFG/s7Jdb8NECPqyIMZtQnH T3pLZEFbClfgQIEKtI9IpSBblHpNfLcwODTco6vdrAS6RaalfmGloUBtT0MMADH+aBwDAW02JCSYx SPECLvCUDClguaLCxT45fmNadYIGvX5GRPpu8JVuTjyv9QK+R6BCCc3q/j6kJxUFJ9/Q7TqnBhbkD rnojUnmFtNsKV+v+g90Wmf+3qaHm0vWPHR+gYE6YPU98PdRoS/cnfc46ooikzI4Qz2bNkSttdG8Zm Z8ABP6BHENKWA4F8q/jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCtqA-00Dzyc-Cb; Thu, 27 Jan 2022 01:44:46 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCtq6-00Dzxh-2k; Thu, 27 Jan 2022 01:44:43 +0000 Received: by mail-qt1-x82b.google.com with SMTP id h25so395881qtm.1; Wed, 26 Jan 2022 17:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fkZRVSlN4OVqtWVL7pewLYQ6zSvcJSeKEV0uiFIaRLk=; b=dH5AjtjcUNRW+nbSzvOeXBjGXOwYbtL3LGiDQxPOv2Jd0Xz8ZpG66rlr80WsqXfIxS IeVSSkW0TY+us/IaD+OJr90QsyPSqiBM9QbHlWVUfzdZquhT7Fw9RNYnZzzFL8ZfZbJo 0nanawA37PuhwHwyemb9WmwmD5T0mML991BB/sYoysqrr8VtNKr3AjVUkxqHtvAlgqYM defAdyrdpcVU6/xUWtn6SmGrdVGp+fOPxF6iLOwMXuFOOmqnvaCP4KARYbtZ+zWe7xlT VjQjAVVUBzq+t+szZ1wG+87BFZZtobEtRReSCKtBPI0cHjsOogAjfu3tLOFD6Ch5izPd 2CmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fkZRVSlN4OVqtWVL7pewLYQ6zSvcJSeKEV0uiFIaRLk=; b=vmjwFUs7GYvz7TPP7MXBvUp5kWQc22qvGjoulBiwDs/HbCE5JoZ5wBK8vDU9MOB7pT TLIvmxTBSR73P7hsN3Xzazs4SOCNYzNaM+LBcq6I/hKzfXqmTJEPkxJxXkUSjLpUICVg PsuXU0swTBpYr/KlatGhLPc/t+9AB1nFw3CL8KF8uaGbHK5PMjJjGp6yHbhlrQ0PwmFf eGth2T1cZbWscT3TBlhSJ1m+MpB57Ujj1c3Cx8tN5i93e0Bg9la3BTWXcx0TzsPFJ0Jz ESPIO4E4pDSqmeFifcAFBgNEZROnA/dMr8MBniwk8e1AVVKzLPugTZAH5cKAr0RlsUmr h4wg== X-Gm-Message-State: AOAM531YSWDWhQZa3+Ai5C+8w5+2DUZRUKUNTZGlC50pV46CR2htZDIN lTeWGsOwdUF9lB3EbmItmyo= X-Google-Smtp-Source: ABdhPJy4vAwIjbPf59Lgx5QWmb2pX3lLzFpQDOjoRe8jLEPWzH36QASNhH77p7m6WXw3/OOm9bkHAQ== X-Received: by 2002:a05:622a:1008:: with SMTP id d8mr1201056qte.222.1643247880468; Wed, 26 Jan 2022 17:44:40 -0800 (PST) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id h6sm730432qko.7.2022.01.26.17.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 17:44:40 -0800 (PST) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: nsaenz@kernel.org Cc: rdunlap@infradead.org, unixbhaskar@gmail.com, stefan.wahren@i2se.com, dave.stevenson@raspberrypi.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Minghao Chi (CGEL ZTE)" , Zeal Robot , CGEL ZTE Subject: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls Date: Thu, 27 Jan 2022 01:44:32 +0000 Message-Id: <20220127014432.1185206-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_174442_147016_E9C76CFC X-CRM114-Status: UNSURE ( 8.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: "Minghao Chi (CGEL ZTE)" 'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. Reported-by: Zeal Robot Signed-off-by: Minghao Chi (CGEL ZTE) Signed-off-by: CGEL ZTE --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 76d3f0399964..60305c63c6f6 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1844,7 +1844,6 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance) mutex_unlock(&instance->vchiq_mutex); vchiq_shutdown(instance->vchiq_instance); - flush_workqueue(instance->bulk_wq); destroy_workqueue(instance->bulk_wq); vfree(instance->bulk_scratch); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel