From: Bjorn Helgaas <helgaas@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Selvam Sathappan Periakaruppan <speriaka@codeaurora.org>,
Kathiravan T <kathirav@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Robert Marko <robert.marko@sartura.hr>,
Bryan O'Donoghue <pure.logic@nexus-software.ie>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v5 3/3] PCI: qcom: add support for IPQ60xx PCIe controller
Date: Thu, 27 Jan 2022 09:16:30 -0600 [thread overview]
Message-ID: <20220127151630.GA100574@bhelgaas> (raw)
In-Reply-To: <8735lc9r9d.fsf@tarshish>
On Tue, Jan 25, 2022 at 09:41:45AM +0200, Baruch Siach wrote:
> On Mon, Jan 24 2022, Bjorn Helgaas wrote:
> > On Mon, Jan 24, 2022 at 06:27:31PM +0200, Baruch Siach wrote:
> >> +static int qcom_pcie_init_2_9_0(struct qcom_pcie *pcie)
> >> +{
> >> + struct qcom_pcie_resources_2_9_0 *res = &pcie->res.v2_9_0;
> >> + struct device *dev = pcie->pci->dev;
> >> + int ret;
> >> +
> >> + ret = reset_control_assert(res->rst);
> >> + if (ret) {
> >> + dev_err(dev, "reset assert failed (%d)\n", ret);
> >> + return ret;
> >> + }
> >> +
> >> + usleep_range(2000, 2500);
> >
> > Where do these sleep durations come from? If they're specified
> > somewhere by PCIe, can you include a citation, e.g., a section number
> > in the spec.
>
> As I mentioned before, I have no access to hardware documentation. I'm
> only porting working code from downstream kernel.
>
> In a comment on v4 Bjorn Andersson mentioned "datasheet stating the
> minimum timing of the operations to be performed to get the PCIe
> controller into a known (clean) state".
Sorry if I'm repeating questions. We can help avoid that by adding a
brief comment here like "black magic copied from working code at X" or
whatever you *do* know. Repeated questions are wasted effort for both
the author and reviewers.
Sleeps with unsourced durations are always suspect because nobody
wants to wait longer than necessary, and if all we have is a bare
number and nobody knows how it was derived, we can't be confident
about changing it.
> https://lore.kernel.org/all/Ydd5Wh0KeADBQ%2Fh1@ripper/
>
> I have no further details.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-01-27 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 16:27 [PATCH v5 0/3] arm64: IPQ6018 PCIe support Baruch Siach
2022-01-24 16:27 ` [PATCH v5 1/3] arm64: dts: qcom: ipq6018: add pcie max-link-speed Baruch Siach
2022-01-24 16:27 ` [PATCH v5 2/3] PCI: dwc: tegra: move GEN3_RELATED DBI register to common header Baruch Siach
2022-01-24 16:27 ` [PATCH v5 3/3] PCI: qcom: add support for IPQ60xx PCIe controller Baruch Siach
2022-01-24 20:42 ` Bjorn Helgaas
2022-01-25 7:41 ` Baruch Siach
2022-01-27 15:16 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127151630.GA100574@bhelgaas \
--to=helgaas@kernel.org \
--cc=agross@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kathirav@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=speriaka@codeaurora.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).