From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D2ECC433F5 for ; Thu, 27 Jan 2022 18:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SiWEf0HM1020VGou98CU5rTDKvOQWYXqQMXxaAxV1Ng=; b=SW5BpADhm4mTPF OjslUOOxaBznqcbKCRkQxHf/aq/6bxwOCbuWtIcmItQkBzaK8vTA24oZI6de81ndmuPRIq/TcnMKi FSOgmyUa0Nmw2TowZtiirf77Fr3F2faNCjVwy+ZD2kScAb82hDhmi9qTLC3FUbjCg1WlDK4PN930Y vOz4B5FOko0jyiNLkhLFfUIJaocou6wdheGDw4d1FG93zxsNx/SjmJZ2rSD8MfdeJWrVNOw8yxO0Y S/NvKE5ky/1ZcIvLg8qmGxbwgkhhWuFb93uz1QVTdUniQMpBWC20qd+i2uVmogRxBL7gI1D6Mvx5o ltq4YlbKwABft5B9LjNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD9J7-00GoZh-3V; Thu, 27 Jan 2022 18:15:41 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD9J3-00GoYV-MS for linux-arm-kernel@lists.infradead.org; Thu, 27 Jan 2022 18:15:39 +0000 Received: by mail-pj1-x1031.google.com with SMTP id h20-20020a17090adb9400b001b518bf99ffso8304251pjv.1 for ; Thu, 27 Jan 2022 10:15:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=e6rcQvJTHLKMBKCYT0j91fjAO+zteSS7tQ7m4bwnFeU=; b=ZCIymVscBIgfKujs+Ipz8pgQYkv7ZPkdvlX1TtOQzr4xjZ7exKIPYJ0ROjQ69eCG2c kYUpz/anyhzG5atX4s0Qw+FkaxDNQ7BmkHhxaOImsBv9hK+4AAqECoe3YPGkiEYuHt2s pXul64A38dr4Wm6O8yiY1e+wA081cpc39sJjEk26bvvr3yOPIqQkak/ERexeok6mURtR 3NicaVS2QtSSRxZ/gDclIplbzJHiyB+rrVD3E2NreUFq7pBgQw0fVzDFmbHYv3DXX6e3 6U4KWw2ZP+ii/20vrGXMjXhTTzBFamXuXBTFTAY4lj2Mqs74y4bmqp6X0Lqv+UySi9Q0 HmLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=e6rcQvJTHLKMBKCYT0j91fjAO+zteSS7tQ7m4bwnFeU=; b=CIavAp+WBwjRssObvxVxpayamldTK3nLFcvWwLX6OMcEPhGG50oLIny/HI6OGG123T mbQpxQGmhieES4xsxuWQyTHa5Jb9x8qegQkK/QB3TA2nMQqMwB0nXnx778SjV0HJ8KjE mVz5gneAF3u3GD6KF8MBfrR/DeRe4jjUN1hZR5ULsZ+1VV+x9jtqP33YNgpP6hIar//A PeAM684X8oz+pg6fD+LsS7dzU87QFRc9fTz8mjwyO5UIy4sXQsFCvoJDGCZAnC/A7D7M BevPQ/vhmNrRFVjlLFMiZ83eNgDGxKr23MjR0waH5nNjXqZc6r+lhUcHTIyVw/jqTdLN I4qA== X-Gm-Message-State: AOAM531SxBCoMgSpyzzFu+TcN1tSwkgGlB27IK91DPMcZdsrKl7PO3Et vMIuzO45vPop0DJ2ojK7lf07mwCC/kt+9Q== X-Google-Smtp-Source: ABdhPJwSdTetod5K3VGf5Sv5610FZ/F8QioeIvUFfLr1xIxKpDH7V/5ofoXIzazZM29ypwPCyGzHtg== X-Received: by 2002:a17:902:8c81:: with SMTP id t1mr4591015plo.16.1643307335671; Thu, 27 Jan 2022 10:15:35 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id b6sm6512270pfl.126.2022.01.27.10.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 10:15:34 -0800 (PST) Date: Thu, 27 Jan 2022 11:15:31 -0700 From: Mathieu Poirier To: Jinlong Mao Cc: Mike Leach , Suzuki K Poulose , Alexander Shishkin , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 2/9] Coresight: Add coresight TPDM source driver Message-ID: <20220127181531.GA2189869@p14s> References: <20211209141543.21314-1-quic_jinlmao@quicinc.com> <20211209141543.21314-3-quic_jinlmao@quicinc.com> <20211214185714.GB1549991@p14s> <85ad17fb-c885-831d-d841-4c6f10920355@quicinc.com> <20211216190223.GA78825@p14s> <2703bf83-3a87-e69f-2392-7e0568e91712@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2703bf83-3a87-e69f-2392-7e0568e91712@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_101537_776565_D315910B X-CRM114-Status: GOOD ( 58.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jinlong, On Fri, Jan 21, 2022 at 10:01:47PM +0800, Jinlong Mao wrote: > Hi Mathieu, > = > Good Day. > = > On 12/17/2021 3:02 AM, Mathieu Poirier wrote: > > [...] > > = > > > > > > + > > > > > > +static void tpdm_init_default_data(struct tpdm_drvdata *drvdat= a) > > > > > > +{ > > > > > > + static int traceid =3D TPDM_TRACE_ID_START; > > > > > > + > > > > > > + drvdata->traceid =3D traceid++; > > > > > > +} > > > > > I have been specific on how to properly do this in the last revis= ion. Given the > > > > > above about the MAINTAINERS file, I am not sure that I will conti= nue reviewing this set. > > > > > = > > > > > There is also no need to rush another revision as I won't have th= e bandwidth to > > > > > process it before the holidays. > > > > > = > > > > > Thanks, > > > > > Mathieu > > > > Hi Mathieu, > > > > = > > > > Sorry, not addressed your previous comments here. > > > > = > > > > For the trace id, each coresight component has 7 bits to store the = trace > > > > id. So the trace id should be from 1 to 127 as 0 is invalid. > > > IDs 0x70 - 0x7F (`112 - 127 ) are reserved - see the ARM Coresight > > > Architecture specification v3.0 > > > = > > Correct > > = > > > > Apart from TPDMs/STM/ETMs, we also have other coresight components = in > > > > our internal device. About 80 ids are already used. > > > > = > > > > Some components have fixed trace id in HW. If we use functions belo= w to > > > > count the trace id, there will be conflict to other components. > > > > = > > > > Can we use 1-15 for etm trace ids and 16 - 127 for other coresight > > > > components ? And handle trace ids in its' own driver ? > > > > = > > > This will limit systems to 15 cores - some have more! > > > = > > Correct > > = > > > > static inline int coresight_get_system_trace_id(int id) > > > > { > > > > /* Start system IDs above the highest per CPU trace ID. */ > > > > return coresigth_get_trace_id(cpumask_last(cpu_possible_m= ask) + 1); > > > > } > > Looking at my own suggestion again this won't work since it returns the= same traceID > > when called multiple times. > > = > > For this patchset and _without_ taking into account internal devices th= at have > > their traceID set in HW: > > = > > 1. Define a bitmask that is 7 bit wide. > Should it be a 128 bit wide bitmask=A0 (0--127)? > > 2. By default, set bits under 0x10 and between 0x70 - 0x7F. > > 3. In coresight_get_system_trace_id(), drop the @id parameter and alloc= ate the > > first available bit after cpumask_last(cpu_possible_mask) + 1. > = > Should it allocate the first available bit after (cpumask_last(cpu_possib= le_mask) *2 ) + 0x10 ? > Return the first zero bit position as the trace id and set the bit. Please ignore my email from January 26th and proceed exactly as you stated above. I had conversations with Suzuki and Mike and providing an appropriate fix f= or this issue needs more investigation. = Aplogies for the flip-flopping, as I said earlier this is a complex problem we've been restling with for quite some time now. Thanks, Mathieu > = > > 4. Define a new function called coresight_put_system_trace_id(int id) t= hat > > clears the bit in the mask corresponding to @id. > > = > > For now that should work. > > = > > > > static inline int coresight_get_trace_id(int cpu) > > > > { > > > > /* > > > > * A trace ID of value 0 is invalid, so let's start at some > > > > * random value that fits in 7 bits and go from there. Since > > > > * the common convention is to have data trace IDs be I(N) + = 1, > > > > * set instruction trace IDs as a function of the CPU number. > > > > */ > > > > return (CORESIGHT_ETM_PMU_SEED + (cpu * 2)); > > > > } > > > > = > > > This fixed relationship between cpu and trace ID is used in the perf > > > tooling to populate the elements in the perf.data file to correctly > > > allow association between CPU and trace data, and thus allow correct > > > trace decode. > > TraceIDs associated to CPUs are communicated to the perf tooling by way= of the > > perf header - theoretically we should be able to change the allocation = scheme > > without impacting the decoding process. > > = > > > It should be possible to create another more dynamic mapping scheme - > > > but this must include a way to support the perf requirements too. > > > = > > TraceIDs have been a lurking problem for as long as the subsystem has e= xisted. > > For now what I have suggested above should be sufficient to provide an > > in-between solution that doesn't hold back this patchset. > > = > > That being said, we need to start thinking about the best way to do thi= s. I > > will put a patchset together in the new year that aims in that directio= n. > > = > > > Regards > > > = > > > Mike > > > = > > > > Thanks > > > > = > > > > Jinlong Mao > > > > = > > > > > > + > > > > > > +static int tpdm_probe(struct amba_device *adev, const struct a= mba_id *id) > > > > > > +{ > > > > > > + struct device *dev =3D &adev->dev; > > > > > > + struct coresight_platform_data *pdata; > > > > > > + struct tpdm_drvdata *drvdata; > > > > > > + struct coresight_desc desc =3D { 0 }; > > > > > > + > > > > > > + desc.name =3D coresight_alloc_device_name(&tpdm_devs, dev); > > > > > > + if (!desc.name) > > > > > > + return -ENOMEM; > > > > > > + pdata =3D coresight_get_platform_data(dev); > > > > > > + if (IS_ERR(pdata)) > > > > > > + return PTR_ERR(pdata); > > > > > > + adev->dev.platform_data =3D pdata; > > > > > > + > > > > > > + drvdata =3D devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL= ); > > > > > > + if (!drvdata) > > > > > > + return -ENOMEM; > > > > > > + drvdata->dev =3D &adev->dev; > > > > > > + dev_set_drvdata(dev, drvdata); > > > > > > + > > > > > > + drvdata->base =3D devm_ioremap_resource(dev, &adev->res); > > > > > > + if (!drvdata->base) > > > > > > + return -ENOMEM; > > > > > > + > > > > > > + mutex_init(&drvdata->lock); > > > > > > + > > > > > > + desc.type =3D CORESIGHT_DEV_TYPE_SOURCE; > > > > > > + desc.subtype.source_subtype =3D CORESIGHT_DEV_SUBTYPE_SOUR= CE_SYS; > > > > > > + desc.ops =3D &tpdm_cs_ops; > > > > > > + desc.pdata =3D adev->dev.platform_data; > > > > > > + desc.dev =3D &adev->dev; > > > > > > + drvdata->csdev =3D coresight_register(&desc); > > > > > > + if (IS_ERR(drvdata->csdev)) > > > > > > + return PTR_ERR(drvdata->csdev); > > > > > > + > > > > > > + tpdm_init_default_data(drvdata); > > > > > > + pm_runtime_put(&adev->dev); > > > > > > + > > > > > > + return 0; > > > > > > +} > > > > > > + > > > > > > +static void __exit tpdm_remove(struct amba_device *adev) > > > > > > +{ > > > > > > + struct tpdm_drvdata *drvdata =3D dev_get_drvdata(&adev->de= v); > > > > > > + > > > > > > + coresight_unregister(drvdata->csdev); > > > > > > +} > > > > > > + > > > > > > +static struct amba_id tpdm_ids[] =3D { > > > > > > + { > > > > > > + .id =3D 0x000f0e00, > > > > > > + .mask =3D 0x000fff00, > > > > > > + }, > > > > > > + { 0, 0}, > > > > > > +}; > > > > > > + > > > > > > +static struct amba_driver tpdm_driver =3D { > > > > > > + .drv =3D { > > > > > > + .name =3D "coresight-tpdm", > > > > > > + .owner =3D THIS_MODULE, > > > > > > + .suppress_bind_attrs =3D true, > > > > > > + }, > > > > > > + .probe =3D tpdm_probe, > > > > > > + .id_table =3D tpdm_ids, > > > > > > +}; > > > > > > + > > > > > > +module_amba_driver(tpdm_driver); > > > > > > + > > > > > > +MODULE_LICENSE("GPL v2"); > > > > > > +MODULE_DESCRIPTION("Trace, Profiling & Diagnostic Monitor driv= er"); > > > > > > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.h b/dri= vers/hwtracing/coresight/coresight-tpdm.h > > > > > > new file mode 100644 > > > > > > index 000000000000..980ae90ff1c8 > > > > > > --- /dev/null > > > > > > +++ b/drivers/hwtracing/coresight/coresight-tpdm.h > > > > > > @@ -0,0 +1,31 @@ > > > > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > > > +/* > > > > > > + * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rig= hts reserved. > > > > > > + */ > > > > > > + > > > > > > +#ifndef _CORESIGHT_CORESIGHT_TPDM_H > > > > > > +#define _CORESIGHT_CORESIGHT_TPDM_H > > > > > > + > > > > > > +/* Default value of the traceid */ > > > > > > +#define TPDM_TRACE_ID_START 128 > > > > > > + > > > > > > +/** > > > > > > + * struct tpdm_drvdata - specifics associated to an TPDM compo= nent > > > > > > + * @base: memory mapped base address for this component. > > > > > > + * @dev: The device entity associated to this component. > > > > > > + * @csdev: component vitals needed by the framework. > > > > > > + * @lock: lock for the enable value. > > > > > > + * @enable: enable status of the component. > > > > > > + * @traceid: value of the current ID for this component. > > > > > > + */ > > > > > > + > > > > > > +struct tpdm_drvdata { > > > > > > + void __iomem *base; > > > > > > + struct device *dev; > > > > > > + struct coresight_device *csdev; > > > > > > + struct mutex lock; > > > > > > + bool enable; > > > > > > + int traceid; > > > > > > +}; > > > > > > + > > > > > > +#endif /* _CORESIGHT_CORESIGHT_TPDM_H */ > > > > > > diff --git a/include/linux/coresight.h b/include/linux/coresigh= t.h > > > > > > index 93a2922b7653..e48d463be63b 100644 > > > > > > --- a/include/linux/coresight.h > > > > > > +++ b/include/linux/coresight.h > > > > > > @@ -65,6 +65,7 @@ enum coresight_dev_subtype_source { > > > > > > CORESIGHT_DEV_SUBTYPE_SOURCE_PROC, > > > > > > CORESIGHT_DEV_SUBTYPE_SOURCE_BUS, > > > > > > CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE, > > > > > > + CORESIGHT_DEV_SUBTYPE_SOURCE_SYS, > > > > > > }; > > > > > > = > > > > > > enum coresight_dev_subtype_helper { > > > > > > -- > > > > > > 2.17.1 > > > > > > = > > > = > > > = > > > -- = > > > Mike Leach > > > Principal Engineer, ARM Ltd. > > > Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel