[PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers

[PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers

[Marek Vasut]

Include missing headers, since this DT source uses symbolic names defined
in those headers. If an external DT includes this dtsi without including
the headers as well, the DT becomes unbuildable.

Three headers are included:
dt-bindings/gpio/gpio.h -- because this DT contains GPIO_ACTIVE_HIGH
dt-bindings/input/input.h -- because this DT contains KEY_A
dt-bindings/pwm/pwm.h -- because this DT contains PWM_POLARITY_INVERTED

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: kernel@dh-electronics.com
---
 arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi b/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi
index dc89b554e694e..fe72650295a5b 100644
--- a/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi
@@ -4,7 +4,10 @@
  * Copyright (C) 2018 Marek Vasut <marex@denx.de>
  */
 
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 #include <dt-bindings/leds/common.h>
+#include <dt-bindings/pwm/pwm.h>
 
 / {
 	chosen {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers

[Fabio Estevam]

Hi Marek,

On Thu, Dec 30, 2021 at 9:12 PM Marek Vasut <marex@denx.de> wrote:
>
> Include missing headers, since this DT source uses symbolic names defined
> in those headers. If an external DT includes this dtsi without including
> the headers as well, the DT becomes unbuildable.
>
> Three headers are included:
> dt-bindings/gpio/gpio.h -- because this DT contains GPIO_ACTIVE_HIGH
> dt-bindings/input/input.h -- because this DT contains KEY_A
> dt-bindings/pwm/pwm.h -- because this DT contains PWM_POLARITY_INVERTED

This makes sense:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers

[Shawn Guo]

On Fri, Dec 31, 2021 at 01:12:14AM +0100, Marek Vasut wrote:
> Include missing headers, since this DT source uses symbolic names defined
> in those headers. If an external DT includes this dtsi without including
> the headers as well, the DT becomes unbuildable.
> 
> Three headers are included:
> dt-bindings/gpio/gpio.h -- because this DT contains GPIO_ACTIVE_HIGH
> dt-bindings/input/input.h -- because this DT contains KEY_A
> dt-bindings/pwm/pwm.h -- because this DT contains PWM_POLARITY_INVERTED
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: kernel@dh-electronics.com

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel