From: Jonathan Cameron <jic23@kernel.org>
To: Michael Tretter <m.tretter@pengutronix.de>
Cc: linux-iio@vger.kernel.org, anand.ashok.dumbre@xilinx.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] iio: adc: xilinx-ams: Fix num_channels for PS channels
Date: Sun, 30 Jan 2022 12:30:25 +0000 [thread overview]
Message-ID: <20220130123025.5ff021d9@jic23-huawei> (raw)
In-Reply-To: <20220119114513.2035609-1-m.tretter@pengutronix.de>
On Wed, 19 Jan 2022 12:45:13 +0100
Michael Tretter <m.tretter@pengutronix.de> wrote:
> The IIO channels of the PS are not provided in the sysfs even if the
> ams_ps is enabled in the device tree. The reason is that the channels of
> the PS are not added to the overall number of IIO channels.
>
> The line somehow got lost between v11 and v12 of the patch series.
>
> Add the number of ams_ps_channels to the number of channels to correctly
> register all channels.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Applied to the fixes togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/adc/xilinx-ams.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index 8343c5f74121..ede968efb77f 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -1224,6 +1224,7 @@ static int ams_init_module(struct iio_dev *indio_dev,
>
> /* add PS channels to iio device channels */
> memcpy(channels, ams_ps_channels, sizeof(ams_ps_channels));
> + num_channels += ARRAY_SIZE(ams_ps_channels);
> } else if (fwnode_property_match_string(fwnode, "compatible",
> "xlnx,zynqmp-ams-pl") == 0) {
> ams->pl_base = fwnode_iomap(fwnode, 0);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-30 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 11:45 [PATCH] iio: adc: xilinx-ams: Fix num_channels for PS channels Michael Tretter
2022-01-30 12:30 ` Jonathan Cameron [this message]
2022-01-30 12:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130123025.5ff021d9@jic23-huawei \
--to=jic23@kernel.org \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox