From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEF9EC433EF for ; Sun, 30 Jan 2022 12:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WHE58pHDNmFKokFoXlTGBfGf3wHxpPPxh4LuuieOw7Q=; b=m9a/4iFg3431dN iZAmFDCi9/8NvjvgT8JbqiRafbq8MdqKYtolc69764gpAU3sra5b6jmGQ/by8Qaa9bVl934MPE2FB N7DqwkP5H7r60YcncBU1G3dsIqj466wvM5/x38Cvlp8uSJcY2fBSEu4skNx38yJFHyyUgcVzfE5YJ eY4xWGoNLLM//YGW1fODZngQdw9I+IHEhinv/VA5P97cybsKJqtuuQHPZRnB8v+bV+mKy4kqbMNdP N+f5571VlRGlKJect/b4/Ibe7S+wc6ZsOTQfi769MxMxy82jBKEQHO7Fp59/n7frsghb98DKjFcmS BXq6fLPg5DqGz3yA9sOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nE9TT-006W68-Ib; Sun, 30 Jan 2022 12:38:31 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nE9TP-006W5Z-V4 for linux-arm-kernel@lists.infradead.org; Sun, 30 Jan 2022 12:38:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5DD85B82922; Sun, 30 Jan 2022 12:38:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EF46C340E4; Sun, 30 Jan 2022 12:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643546301; bh=z4EkGHSSzUXo5U3w1mUhpT3Hr3SpgVBh6HSkNvnGFtY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Zsmboc7zegZ+VhghlKn8op6HVHmLmV4Gri9HxS/0TCPjJhbdHQeq+QSvBxx07rtk0 pFyO2ILEvGU5qBslLg2uKEtuNdzL4JO/A1Wo1VKiqV9AGYg6uGGAOWmryWuGlN8bav fMKrMnq/5zpZ3u9/NYZWSh61+miJiGDucOyr3WmsZdcH3t21vW1q50FeX7G+GgsURX ieaFB1FvwfqX3CWj9FeIPa7EWgrdJ1UTf1pC/7IoNcFoS6AZeiG6ZLoK3gJVqTrBud RSLhnTezskGarRxoGoaUPgw9/JVyryPP48j+lFa0amSGzYJdawjKQUXd3gwei7Sd1O PALto98ybtCIQ== Date: Sun, 30 Jan 2022 12:44:45 +0000 From: Jonathan Cameron To: Michael Tretter Cc: linux-iio@vger.kernel.org, anand.ashok.dumbre@xilinx.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH] iio: adc: xilinx-ams: Fix num_channels for PS channels Message-ID: <20220130124445.22a34873@jic23-huawei> In-Reply-To: <20220130123025.5ff021d9@jic23-huawei> References: <20220119114513.2035609-1-m.tretter@pengutronix.de> <20220130123025.5ff021d9@jic23-huawei> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220130_043828_207080_45D2C34E X-CRM114-Status: GOOD ( 23.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 30 Jan 2022 12:30:25 +0000 Jonathan Cameron wrote: > On Wed, 19 Jan 2022 12:45:13 +0100 > Michael Tretter wrote: > > > The IIO channels of the PS are not provided in the sysfs even if the > > ams_ps is enabled in the device tree. The reason is that the channels of > > the PS are not added to the overall number of IIO channels. > > > > The line somehow got lost between v11 and v12 of the patch series. > > > > Add the number of ams_ps_channels to the number of channels to correctly > > register all channels. > > > > Signed-off-by: Michael Tretter > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > Applied to the fixes togreg branch of iio.git. > Actually change of plan . I'll just pick up the v2 fixes set from Robert as otherwise I'll loose track of where we are with these. Thanks, Jonathan > Thanks, > > Jonathan > > > --- > > drivers/iio/adc/xilinx-ams.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > > index 8343c5f74121..ede968efb77f 100644 > > --- a/drivers/iio/adc/xilinx-ams.c > > +++ b/drivers/iio/adc/xilinx-ams.c > > @@ -1224,6 +1224,7 @@ static int ams_init_module(struct iio_dev *indio_dev, > > > > /* add PS channels to iio device channels */ > > memcpy(channels, ams_ps_channels, sizeof(ams_ps_channels)); > > + num_channels += ARRAY_SIZE(ams_ps_channels); > > } else if (fwnode_property_match_string(fwnode, "compatible", > > "xlnx,zynqmp-ams-pl") == 0) { > > ams->pl_base = fwnode_iomap(fwnode, 0); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel