From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 912E0C433F5 for ; Mon, 31 Jan 2022 17:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kawicIVIFpGwZyHwIdBDz4JIZY+dhQ6poqlf5/g/VK0=; b=q2IErVZR5ZzBnt nNFY0KMsBoz5lYXgV1oHPgIc52N6MWKhXAeXzq/wC7hQ2CYCGXoUQbzKUrHLH+qXxlqWYyIUWQmvv Zf215Sx14RMorF6v4aqeEmAKramH6WVpsFj3fudhfc+gPN6xyXR5fRiVVY/5aGybc3fFqbylGraQv NLCqUHZoWH6myaLrA34QMSoyRlWN524863ObLWcLlB/Pvg9evVDihBr5N7CRLPmVWrrcrAIVf5/PU fnpl89uX3nq33Q5IP3tgyQDXjnSLMdacPE59z2Zesnwz6NH7cSMbw8bnQXHlmRhTA70gSKUo3eMos Du4ZPZxBBhwLZjC4kzLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEagR-00ABwu-7y; Mon, 31 Jan 2022 17:41:47 +0000 Received: from mail-mw2nam10on2124.outbound.protection.outlook.com ([40.107.94.124] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEaXs-00A8xW-Qc for linux-arm-kernel@lists.infradead.org; Mon, 31 Jan 2022 17:32:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LUr6M819xU0W84MmXWmJ4N64u1GQD5PCvlf0KGJ8ZyJ1+zgj8JR/jjLqwHlOL2N+t/mYDLnZnkDFCCkACV6qHp7f42FYIjxfgUYPLFxzPQjv63M+s/coV0b/ptZ0y9Z/EhkZWcprN+/CBVARMVydDWAOf8aXwJopB9QgUuv8ehhw6TM9Fcbqf1KtnXownouQYARiM2DKy7o3imdi+OD90YJWGnHwDH7kixjpNklLK6hFs5N4PFnn8ZB1f7nTGWziad6X46yTD6YO/aIO60dv6etEawxCxoN5jq4UKkyeicO2o+hMbYcKrX6uDiJfcrcU0ET12zM9iFPo8r7GsWZ2RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6yjDTEykRe0l/vfQ+RV2PieS3wBvX/e0SdrlhVdYvug=; b=CB0jbYKmCyRikToowTKeKJFXtlZwR4ipDIVWhfj53cwtOOBIBgltH2XgGqXcPUYHpdwXWHZnH2Qv1sbont9Xdul1ZBDhHm2Umz0cwbOhH6a9smUKaOAkrRAyx1oDGWH9PF3NLRBOq5HOETyaa6/dMynMb8+Vkf6j9Ux3pMa0IwjFtUHzoz44u76KTCwGBamLGTDjvC2j/HBkvRGn/XGlvo5RuKnerCe4UnrA+NIV0aC9zCEkfVMPdu2ZrNqcYmpVzep2VhX19BDLTAdxLmCjzoW3iV6R+C6Bm9yVVpk9zMFKQxmp5F7mImHcbhd4gbKi+i2pj1TvHyW1RDBsitZ6Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6yjDTEykRe0l/vfQ+RV2PieS3wBvX/e0SdrlhVdYvug=; b=wUInG+UbxFfJsfucdX/E5tgD35Da9rQG6hpx+SgzVRBmsB0rVUmn+SeriUoBlkkEVI5FbwdUXf62VtVATwsOt6Trpg60XnyInfVMagCoMyhPHMmNf6tdjhgTUGzD1pxcmWD9CxwcvGDbDrDj+OLdMTQATNmE37FONUCgEFFVdM8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BN6PR1001MB2178.namprd10.prod.outlook.com (2603:10b6:405:2e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Mon, 31 Jan 2022 17:32:50 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::2d52:2a96:7e6c:460f]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::2d52:2a96:7e6c:460f%4]) with mapi id 15.20.4930.020; Mon, 31 Jan 2022 17:32:50 +0000 Date: Mon, 31 Jan 2022 09:32:58 -0800 From: Colin Foster To: Vladimir Oltean Cc: "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Jakub Kicinski , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , "UNGLinuxDriver@microchip.com" , Alexandre Belloni , Claudiu Manoil , Lee Jones , "katie.morris@in-advantage.com" Subject: Re: [RFC v6 net-next 4/9] net: mdio: mscc-miim: add ability to externally register phy reset control Message-ID: <20220131173258.GA28216@COLIN-DESKTOP1.localdomain> References: <20220129220221.2823127-1-colin.foster@in-advantage.com> <20220129220221.2823127-5-colin.foster@in-advantage.com> <20220131171318.ryule6y6ffowbrsm@skbuf> Content-Disposition: inline In-Reply-To: <20220131171318.ryule6y6ffowbrsm@skbuf> X-ClientProxiedBy: CO2PR04CA0112.namprd04.prod.outlook.com (2603:10b6:104:7::14) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19723e15-cbb9-4ea7-ff7e-08d9e4dfb40d X-MS-TrafficTypeDiagnostic: BN6PR1001MB2178:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HHt4rqIoK28wUGzC2/lSvyxar8L/muWXO4HI1HPLpgH5xi/Vl6w5wwm2mC6Q2xC+/ZToVtRXW9jVK6sCrt2YPdO9EJRPFqBzvhi8x0ym36VKeo8+xY+sZopTIqaF6XL+uv/48eewwXDeV0wJUVMU2aRuhcqvIuzc8OnN9PeTcqx81hD318ZprkOg2wSj78/SvteCyx3fm+OE3j4TBkEnBLkhK+MPtG0YWyp+/UDzUD1ywJiikGaL6v+Y+hxBOM/cryrCD/yBFBUDkkUsM/fHyMukGUyIkHzNBZcRty9Y5KFV9LB4dIh0qfo5kFmFb7TXeLV560PoaJQB5eIr2khkeJ9eA7N7c4A2tOyJ+3iD56bjJx1jTR8a+ZHaBVJEbU+AHd4putQ14XgST6Ds2mXmOGHau0SokEYwPi4ulhcmQxR9yZk+g9g/e1sgCLvryhG4I5gSoxjJUisE92+wLsZENGGK81bevPpyeZbSdXQjshK2pY6Rt6VJ4Wxm7Ou2ZxGUx4JJ2KvaiuMhnKcKBch2tayGbpQmZ2q7xglwmLU2f797CEFneG8n2Bk09lviDNfcfxOGq/H71GmBRiUik/OeOoGlZ/aY2ydMEv9HReeo/ZQaPpHtND5BqDIO4wVwMCEmPCzAi6oKYTwmnYt4zh/4K5h6uOEmci4xNn0xmOwttFUBb+8ofcc0gxaNn/oKQ5+Cmlj2n8By0gCNDENf1zGYoA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(136003)(42606007)(366004)(39830400003)(376002)(396003)(346002)(26005)(1076003)(186003)(38350700002)(6486002)(38100700002)(5660300002)(508600001)(107886003)(9686003)(6506007)(86362001)(6512007)(52116002)(83380400001)(316002)(44832011)(54906003)(8936002)(4326008)(8676002)(66556008)(6916009)(66476007)(2906002)(66946007)(7416002)(33656002)(4744005)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ckwmohITuBMnL3awEr3jzX76UzJ91GfQg4Q4IDGDLYBP6hfO/vZHSBuSvL4N?= =?us-ascii?Q?0D3+8t9zQeTpH2ILNALpWquHxiiF7MsK534HI1nBnjPOI7ox10aBEMZPFoSl?= =?us-ascii?Q?CgXIlh4sPExXti78FJvNn74MQT7K+7sImQQZ1ZkWqS3G6HwmOB9PDt0QFwys?= =?us-ascii?Q?cCCI2GvehnbLMa1KdgNulUrSt/qA/5Ld79Vvo/7IK3XTWIcZ7qmdMkZQpbuY?= =?us-ascii?Q?ZY5+no00ruZ2NGj7/oI03mdshl+BzMbW0QIF8QZWAV38pv7cruvCBM1QA8z7?= =?us-ascii?Q?lw0CcxOsYxOLjIGY7I4dZriUAzMf5k0uJPV1dW6/O/V8HBs1jZE9G3nVFDzJ?= =?us-ascii?Q?y6ToCuQ+gkuLMCUpoM3xs4e1w3+aMr/r2oOAjqdeRLk+9iXT8YsOzWQlRbvs?= =?us-ascii?Q?2WO2luhrTCEEv3VunzG1ijtQBhUyb057CKnP1EW2uSWOTKJXAs2i+FnXf98V?= =?us-ascii?Q?9aLluPLLyYM+G9N8LJcHVMqBHuFFGMttYmli2yHvWSoKH5e//HdaHV7lVH9G?= =?us-ascii?Q?5c/BeEVrNRCkg5ZcmGppuIaUkMdRBvnbysueIXKFKq2FG8x6Vv/cYbAkVzIS?= =?us-ascii?Q?xd6yxW3omSd9wp0xULxvdeGehPLWO0Z1Fail1UXjpf9hB55Bp7Dm+BpgayRk?= =?us-ascii?Q?h2mFWa3e6qW+EX2x3Pl3+prrJ2vGjsv+iE0Li9tqPtNKrrD2p68cT6UYGtU7?= =?us-ascii?Q?SWLnyrKfYIDkopLGPsEAdzjM+1WnSz+BpGCSu4VYV5EWirWZLys+3IAKIA+Z?= =?us-ascii?Q?ZArpYrcNWqDGWs9mXKc8izeZQzxpSxnHC1WPjcVVVNVLJndyrqMq+GuF0g2F?= =?us-ascii?Q?mpWmOJQDckssbiXoUuENXSfobUBHzRLVrFua+lGiyJjXbgJWFV3AdpsKRJ0E?= =?us-ascii?Q?DCfed80CpWIWE8c7UxT1GBfbwmlGWVmQMYd+uC6woEMiL01w5Dw/aWEVg2oK?= =?us-ascii?Q?/Rmhy5J+fs3OjPcGVUOiP/6nHKMCi5uHdX2jd8AFqRVHEnRIg8XJ593BntLb?= =?us-ascii?Q?fUs4osVT8MTCbrYnghleYDtq3L4anNTkeLsir4FNNmR0iksLCv4wcL7eitrj?= =?us-ascii?Q?lfG7O//SuGpkf3JrzLLn7uMh/3Hk93wBxO6p8iS+//AO4cfVbBE8nwwfiBHE?= =?us-ascii?Q?gcaKGpyerO2PE1vhDCZq44TOZMS8xHCD1Of45wn4dj5DwMIem+PkisO80VPM?= =?us-ascii?Q?VU4H34UmczDFnZvfEIn33IOVMbsfCuZoP6ZZbNQWWC9OosilyMxV+/nwFOTY?= =?us-ascii?Q?83okQVeyk9hwSDhSOIzP+UYGhxJGkgsz30LC8/152YofNE0v0+s1T4rw0vDG?= =?us-ascii?Q?LGj+bwYN0Y6q/n4RPkQBEdn3sGeVZXbz4tN17qkuGv7qeTinBjfL53I9U9o7?= =?us-ascii?Q?2oqxrEohua7/KqKtJgIw7eIq2PmDoSoUGPsWW1L2D+j8/FC2N18odTwEvF/6?= =?us-ascii?Q?BXDNC28eIIPUFuVzencmfnMa74F+iujv/pImFWNpn0QV1U+xkort13lx0Be5?= =?us-ascii?Q?eiQNMnaCNxvGVvd76W6RoStyobXGwOHU3SDIUO4vIcTXX+hNtAVdhloYZAbD?= =?us-ascii?Q?9yGwyLVfcZu7dpxCy9PBS9Wx79ouamo+rquwzzWwTc7k69Ti2awd95iI1P4A?= =?us-ascii?Q?pVnioDHGNMpmc4/ReRrMvXlzhnFvShcGO7hd6lec0mEi8MD6yqcJDhKOvOPF?= =?us-ascii?Q?KpFU2w=3D=3D?= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19723e15-cbb9-4ea7-ff7e-08d9e4dfb40d X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 17:32:50.0698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BP/9ByIWZWos8jB8ugOTKR9x1OtT75eP6KCpsorxvtlu/gP0Dkm/pj0NezZPTihcQpRzFXO875Oo9U/pcg82ZzGTtfan23Gk92wnpOuVduc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2178 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220131_093252_915175_B9EB7F7E X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vladimir, On Mon, Jan 31, 2022 at 05:13:19PM +0000, Vladimir Oltean wrote: > On Sat, Jan 29, 2022 at 02:02:16PM -0800, Colin Foster wrote: > > @@ -257,15 +260,14 @@ static int mscc_miim_probe(struct platform_device *pdev) > > } > > } > > > > - ret = mscc_miim_setup(dev, &bus, "mscc_miim", mii_regmap, 0); > > + ret = mscc_miim_setup(&pdev->dev, &bus, "mscc_miim", mii_regmap, 0, > > + phy_regmap, 0); > > if (ret < 0) { > > dev_err(dev, "Unable to setup the MDIO bus\n"); > > return ret; > > } > > > > miim = bus->priv; > > You left this variable set but not used. Please delete it. Correct. Good catch. There were a couple of these in v6 that kernel-test-robot is happy to point out to me :-) Already fixed in my v7 branch. > > > - miim->phy_regs = phy_regmap; > > - miim->phy_reset_offset = 0; > > > > ret = of_mdiobus_register(bus, dev->of_node); > > if (ret < 0) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel