Re: [RFC v6 net-next 4/9] net: mdio: mscc-miim: add ability to externally register phy reset control

Colin Foster
2022-01-31T17:43:52Z

Hi Vladimir,

On Mon, Jan 31, 2022 at 05:13:19PM +0000, Vladimir Oltean wrote:
> On Sat, Jan 29, 2022 at 02:02:16PM -0800, Colin Foster wrote:
> > @@ -257,15 +260,14 @@ static int mscc_miim_probe(struct platform_device *pdev)
> > }
> > }
> >
> > - ret = mscc_miim_setup(dev, &bus, "mscc_miim", mii_regmap, 0);
> > + ret = mscc_miim_setup(&pdev->dev, &bus, "mscc_miim", mii_regmap, 0,
> > + phy_regmap, 0);
> > if (ret < 0) {
> > dev_err(dev, "Unable to setup the MDIO bus\n");
> > return ret;
> > }
> >
> > miim = bus->priv;
>
> You left this variable set but not used. Please delete it.

Correct. Good catch. There were a couple of these in v6 that
kernel-test-robot is happy to point out to me :-)

Already fixed in my v7 branch.

>
> > - miim->phy_regs = phy_regmap;
> > - miim->phy_reset_offset = 0;
> >
> > ret = of_mdiobus_register(bus, dev->of_node);
> > if (ret < 0) {