From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 476A0C433EF for ; Mon, 31 Jan 2022 11:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zktnXxVRU0MwTGjcPMEmeJsLj6atSnWMjNLsXI6AJck=; b=e15dWCwJ/r8W+5 2NytLSMYHsXxZSIN1qa5CX7RPcis1s972Y9ZuLCgm0XMFoLvmdPCZsKGfUUe7Xh4ypT3pThjHzCPl OlBE990JoC1AqeXWmZj8lf8dJAyYEMUthHQznb3Uq1k9y6BLt9/lWSf6XPzm6Xjfwhd5E1KFnHOij jCjIY4olrfai8/d9Om9b53wl6soIZzfb9WEUz+3Sb6x+3QX3imERhU5HWyUJSQCxREc09N12NlatU M+kS5IXL2pFtPfrO/riyRcD+oeHjlTx/WBRLFLFuh82e7pu0Nn+ksaFwNTxfL3WJwj5aWFRvcjWTu tV1bzCeF8Y3M8MFHQucQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEUff-0096Gl-OE; Mon, 31 Jan 2022 11:16:32 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEUfZ-0096Dn-SF; Mon, 31 Jan 2022 11:16:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643627785; x=1675163785; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=P5JrPttF53yk0cR8vMW+WeMw6didWDvy3oIQC4TtgCQ=; b=gHPYFyq3n8hQK5BvTNmuEFVzrqU/2gbYuIdhE+FfJF5YOf/6jXQT+s1u wsTwA0LJ7og+VMQrjJVpHODGSScXCgQVVj8WqS4fQ1i8ncS/RyoGMNA36 kkKKBaO6OPFfl7rVJrC0DG/5DTfGcZsaPxeAubsLnIVzksXJkafZ3K4N4 /db5i2vQD0JzeLHPsx8kVg7OvzDs2/afZlbGDd8Iv6pDJZRtW8jspOjSw GDXAQ6rH3J+dSyCtXUw9+lz41dZ6hzvP0Xw1OAXn9MP9eavTP6Qmvfdhy cnmCAvOkmVoVywJbOOuI/fPTXlsDDKxsdl9etvakmNWsRZ6sWn+HwGUQi Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10243"; a="247394454" X-IronPort-AV: E=Sophos;i="5.88,330,1635231600"; d="scan'208";a="247394454" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2022 03:16:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,330,1635231600"; d="scan'208";a="619350847" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 31 Jan 2022 03:16:22 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nEUfV-000Rpa-9J; Mon, 31 Jan 2022 11:16:21 +0000 Date: Mon, 31 Jan 2022 19:16:01 +0800 From: kernel test robot To: Nguyen Dinh Phi , Nicolas Saenz Julienne , Greg Kroah-Hartman Cc: kbuild-all@lists.01.org, Nguyen Dinh Phi , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vc04_services: make a couple of functions static Message-ID: <202201311901.HT4PtVja-lkp@intel.com> References: <20220131071006.1764343-1-phind.uet@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220131071006.1764343-1-phind.uet@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220131_031626_006627_068E0921 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nguyen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Nguyen-Dinh-Phi/staging-vc04_services-make-a-couple-of-functions-static/20220131-151209 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 64b2d6ffff862c0e7278198b4229e42e1abb3bb1 config: arm-randconfig-r002-20220130 (https://download.01.org/0day-ci/archive/20220131/202201311901.HT4PtVja-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1b64825a2b5b3312ae309c1714239df049b018ac git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nguyen-Dinh-Phi/staging-vc04_services-make-a-couple-of-functions-static/20220131-151209 git checkout 1b64825a2b5b3312ae309c1714239df049b018ac # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/staging/vc04_services/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function 'free_pagelist': >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:434:25: warning: argument 2 null where non-null expected [-Wnonnull] 434 | memcpy((char *)kmap(pages[0]) + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 435 | pagelist->offset, | ~~~~~~~~~~~~~~~~~ 436 | fragments, | ~~~~~~~~~~ 437 | head_bytes); | ~~~~~~~~~~~ In file included from include/linux/string.h:20, from include/linux/bitmap.h:11, from include/linux/cpumask.h:12, from include/linux/mm_types_task.h:14, from include/linux/mm_types.h:5, from include/linux/buildid.h:5, from include/linux/module.h:14, from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:8: arch/arm/include/asm/string.h:20:15: note: in a call to function 'memcpy' declared 'nonnull' 20 | extern void * memcpy(void *, const void *, __kernel_size_t); | ^~~~~~ vim +434 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 398 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 399 static void 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 400 free_pagelist(struct vchiq_pagelist_info *pagelistinfo, 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 401 int actual) 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 402 { 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 403 struct pagelist *pagelist = pagelistinfo->pagelist; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 404 struct page **pages = pagelistinfo->pages; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 405 unsigned int num_pages = pagelistinfo->num_pages; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 406 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 407 vchiq_log_trace(vchiq_arm_log_level, "%s - %pK, %d", 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 408 __func__, pagelistinfo->pagelist, actual); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 409 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 410 /* 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 411 * NOTE: dma_unmap_sg must be called before the 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 412 * cpu can touch any of the data/pages. 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 413 */ 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 414 dma_unmap_sg(g_dev, pagelistinfo->scatterlist, 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 415 pagelistinfo->num_pages, pagelistinfo->dma_dir); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 416 pagelistinfo->scatterlist_mapped = 0; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 417 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 418 /* Deal with any partial cache lines (fragments) */ 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 419 if (pagelist->type >= PAGELIST_READ_WITH_FRAGMENTS) { 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 420 char *fragments = g_fragments_base + 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 421 (pagelist->type - PAGELIST_READ_WITH_FRAGMENTS) * 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 422 g_fragments_size; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 423 int head_bytes, tail_bytes; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 424 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 425 head_bytes = (g_cache_line_size - pagelist->offset) & 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 426 (g_cache_line_size - 1); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 427 tail_bytes = (pagelist->offset + actual) & 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 428 (g_cache_line_size - 1); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 429 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 430 if ((actual >= 0) && (head_bytes != 0)) { 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 431 if (head_bytes > actual) 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 432 head_bytes = actual; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 433 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 @434 memcpy((char *)kmap(pages[0]) + 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 435 pagelist->offset, 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 436 fragments, 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 437 head_bytes); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 438 kunmap(pages[0]); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 439 } 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 440 if ((actual >= 0) && (head_bytes < actual) && 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 441 (tail_bytes != 0)) { 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 442 memcpy((char *)kmap(pages[num_pages - 1]) + 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 443 ((pagelist->offset + actual) & 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 444 (PAGE_SIZE - 1) & ~(g_cache_line_size - 1)), 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 445 fragments + g_cache_line_size, 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 446 tail_bytes); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 447 kunmap(pages[num_pages - 1]); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 448 } 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 449 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 450 down(&g_free_fragments_mutex); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 451 *(char **)fragments = g_free_fragments; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 452 g_free_fragments = fragments; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 453 up(&g_free_fragments_mutex); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 454 up(&g_free_fragments_sema); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 455 } 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 456 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 457 /* Need to mark all the pages dirty. */ 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 458 if (pagelist->type != PAGELIST_WRITE && 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 459 pagelistinfo->pages_need_release) { 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 460 unsigned int i; 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 461 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 462 for (i = 0; i < num_pages; i++) 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 463 set_page_dirty(pages[i]); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 464 } 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 465 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 466 cleanup_pagelistinfo(pagelistinfo); 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 467 } 7b9148dcb74a00 Ojaswin Mujoo 2021-07-21 468 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel