From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89EF9C433EF for ; Tue, 1 Feb 2022 17:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gHIOIyxZL1eXDVAiyHDHrJIvwGhl98YLPOn+F2NthpI=; b=YCyHfXRGZChx8H vfb2Ek7DM4VabzFCqb5l0Dh/M862wRZILaTWEbIh2soq/VsMR/AM2g4ddVVBXAKhVesH5+93Kt3MV FMOqGPgd/nMxlFW2UY18AmhWRH/EWZVAlG4E6HOjAnTah6kGWWmfgVb1Q+uBHA3xpM/4pipOSGbO9 DqCqWmna1a8uhEJr2HgmQVeeNJfZ33mZT2vwz9OdRdxmxsdgPl+EZK2q+V57Dpw07BQbnAZSwh3v9 Sp6yNG2k2cA2SyA+W8vhCu3gy5q96Se0j8p5B3rggvBKXtftu1Bd9+0hbzO5nrtNMImNsUZ6YvW73 ofEV+yZa52rC8r4lKcVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwiQ-00D5nQ-AE; Tue, 01 Feb 2022 17:13:14 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwiM-00D5mR-HM for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 17:13:11 +0000 Received: by mail-pj1-x1029.google.com with SMTP id y5-20020a17090aca8500b001b8127e3d3aso3172151pjt.3 for ; Tue, 01 Feb 2022 09:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GOTW49dkatvM+333ev58XzmJGJGpPe+Z89sc7+xSJjo=; b=wuvvP0gdVgZs1A/Wxt5ap2DV8ui/vAGBipNuDcKGDCYcwe6WAq6sPm3j0WCUfD9Lr0 caum9JUDupSfKFFJ+B7s1kloeUVTj8qj04Ow+T34j2MeTG9JOATCNW67W9c5mk2H5Rm/ 8IWOmLnyI1OanJEtsko1eLc0Sv+iX5xstLj/NPhB3Kj1ac+IpoBtL9+60aCPgfyhuzrU 7F4xgaAChfOMtavqslzy8wfskfw8BCsf7FvCy5S1h6JimYZ3/Y47aRFe0dThCXKZ0wj2 4vdnoVu3/K1tAiQvFYZJeD56BqF1eibPvhpDsV+eX8+9vnzSKyPWLszpaLwSjmN61b4w qCRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GOTW49dkatvM+333ev58XzmJGJGpPe+Z89sc7+xSJjo=; b=HbpqT2uapPVMNRWJKqh9Kzup3TAEcENcU0ff8VVvjd6qPB6eIcDMPQ5nIDCqNEXVeX 0X2MqbBNlpFTujoOKW9K0zevKZ9vEJfJG15+B0wU7B4vqYZih0RYnPvtlQvO8ORpmhU8 KHe58cLiboThZQyNOmfi5LPkd8gm3TQoopwCKgzyKmhgtkzQg/NzYuqKqI3gLS/tj92j zcp4H5p3wv7ldQeJZnOnjAUt8rirOJxqLCgbgc6Bjmh3agd9/cXOZAZmYDAciyvQJWZQ TZXycq0FHWhtT+iWr5YKFgfBh+cgeAInOwmVQkW8KnMPEd4dj86wULMFdPAHn+dcmgd6 YPZQ== X-Gm-Message-State: AOAM532EvK1oSnv+L0ICrmi23po0k6ZeKeLUCT/WaHOIdoj2qsvAHMnk fOLYYi5cwL/xFv0TYErmUYLq+g== X-Google-Smtp-Source: ABdhPJzrR5tNGJO1MpLKd5EJaHkefJxDXaOyvaYpafZQ4Mnt1nlV2uCN7KUlpMtMkAcx7lU8+yXsWQ== X-Received: by 2002:a17:90b:4f4e:: with SMTP id pj14mr3422943pjb.220.1643735589737; Tue, 01 Feb 2022 09:13:09 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 38sm32163145pgm.37.2022.02.01.09.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 09:13:08 -0800 (PST) Date: Tue, 1 Feb 2022 10:13:06 -0700 From: Mathieu Poirier To: Miaoqian Lin Cc: alexander.shishkin@linux.intel.com, coresight@lists.linaro.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike.leach@linaro.org, suzuki.poulose@arm.com Subject: Re: [PATCH v2] coresight: syscfg: Fix memleak on registration failure in cscfg_create_device Message-ID: <20220201171306.GB2490199@p14s> References: <20220120182822.GA1342128@p14s> <20220124124121.8888-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220124124121.8888-1-linmq006@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_091310_605888_D1288935 X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 24, 2022 at 12:41:21PM +0000, Miaoqian Lin wrote: > device_register() calls device_initialize(), > according to doc of device_initialize: > > Use put_device() to give up your reference instead of freeing > * @dev directly once you have called this function. > > To prevent potential memleak, use put_device() for error handling. > > Signed-off-by: Miaoqian Lin > --- > Changes in v2: > - simply call put_device() instead of cscfg_dev_release() in the error > path of cscfg_create_device. > --- > drivers/hwtracing/coresight/coresight-syscfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c > index 43054568430f..c30989e0675f 100644 > --- a/drivers/hwtracing/coresight/coresight-syscfg.c > +++ b/drivers/hwtracing/coresight/coresight-syscfg.c > @@ -791,7 +791,7 @@ static int cscfg_create_device(void) > > err = device_register(dev); > if (err) > - cscfg_dev_release(dev); > + put_device(dev); Applied. Thanks, Mathieu > > create_dev_exit_unlock: > mutex_unlock(&cscfg_mutex); > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel