From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C25E6C433EF for ; Wed, 2 Feb 2022 14:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oHhNv8s1L2osIc1/tKwclOAHA2HmhsqqDSmxLBTBer8=; b=cNa9+PUUzCVTu+ jCawPLhnWn29m4E9WmgWUliRrpEMv8gw+L8BrDeNHTKNkCiKiMa3nrAFrJsuzrE8WbHVnAA6edg6U 3epLfTffu7JP2dgImcqznFoX9Xtan2bYpaSz1yb2vnvBPFMq0yDCst8t5nWP3ZHAYsZ7ziiQbIW5p 6rx8m1WyXsTw6L1yNWtetZ56WpRsiZDs+i97Y1TgcU41kPHZPhOH0VCX4nv4bFx743vcD0J8knFUU tLDjhjGAJ0PnKu09sc86Yvk9iOeb1/Ze6eTjj+pk8VFrvmetlP3CXjIeQrjqgnzZWg/LyCrxWYItA sqyjsKP+YLcO3ParNP8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFGMD-00FZnC-WA; Wed, 02 Feb 2022 14:11:38 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFG1p-00FPUw-FJ for linux-arm-kernel@lists.infradead.org; Wed, 02 Feb 2022 13:50:35 +0000 Received: by mail-pf1-x432.google.com with SMTP id u130so18851966pfc.2 for ; Wed, 02 Feb 2022 05:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+daluWI6BZRIIo6jD7cHJViSYXk0pP6IWtsEBRin450=; b=Tpd1Y5ycji6S6pWD2XDf2SPMtoJdCSlWpqa5WQ0rz036vkv6p90/OEXloIQ1CsAkGL buh3iG4TyghoF0YDogBgAeLC2VzMf1iYDwfXL6Vf9G6tOqVf1CLVbGsBl/FZOAP822jB VuhIm7GlgM3Uqijk5XMVny+frQUbsvt0GJ/P0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+daluWI6BZRIIo6jD7cHJViSYXk0pP6IWtsEBRin450=; b=8P6kJ8b/kD+vlHZ5wJRfgL8K51mm7Tr0M2byS2+YCjBQT4ocTzSx0JhJx3ZpzJ8xTb Ntz+HmOspPX6gSClAIi32ikYTD4OuVkZ7v9dDtn57wW0jhZvgUU+GZvdj3rmXdffWDew 571Q9yV5Mk2EOdJ/SfL5IAL0cuvMoyt6Ha62BgAr7HK1ixy97kRliVMhqK8JNmkZHmOI ESRvuTVZOD3Q5Xm+h1y9RJ/YT4EFVzSGqEPBAevqn3JCKt4hrBIi9AD+v+KCxblCnbCG VLMkaXwFHcueUnFpjRVNJcK1cbfwo883XbgF++3lwH9Mw1hesM+41HBYLbbjFQgiSg4b L9dA== X-Gm-Message-State: AOAM5318YnkukRYvdObPCNfbPspeiDp71/g3CNXgpAHlurkHcI9EGe4D ZrDy76rSgx5+MuAZPW5Xa1FtOw== X-Google-Smtp-Source: ABdhPJwgB9Kfv9ToZpcQLJRwpxFqkgMwlv0Lnc1Fod0ARERNSW52V7MEPKDRm9oXXveifEe8s/FX+A== X-Received: by 2002:aa7:9498:: with SMTP id z24mr29584316pfk.80.1643809832727; Wed, 02 Feb 2022 05:50:32 -0800 (PST) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:78b5:214c:c81:b9aa]) by smtp.gmail.com with ESMTPSA id w19sm27335684pfu.47.2022.02.02.05.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 05:50:32 -0800 (PST) From: Chen-Yu Tsai To: Stephen Boyd , Michael Turquette , Matthias Brugger Cc: Chen-Yu Tsai , Chun-Jie Chen , Miles Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 27/31] clk: mediatek: Unregister clks in mtk_clk_simple_probe() error path Date: Wed, 2 Feb 2022 21:48:30 +0800 Message-Id: <20220202134834.690675-28-wenst@chromium.org> X-Mailer: git-send-email 2.35.0.rc2.247.g8bbb082509-goog In-Reply-To: <20220202134834.690675-1-wenst@chromium.org> References: <20220202134834.690675-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220202_055033_554189_4A5A347B X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Until now the mediatek clk driver library did not have any way to unregister clks, and so all drivers did not do proper cleanup in their error paths. Now that the library does have APIs to unregister clks, use them in the error path of mtk_clk_simple_probe() to do proper cleanup. Signed-off-by: Chen-Yu Tsai Reviewed-by: Miles Chen --- drivers/clk/mediatek/clk-mtk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c index 8f15e9de742e..0e027be0d5fc 100644 --- a/drivers/clk/mediatek/clk-mtk.c +++ b/drivers/clk/mediatek/clk-mtk.c @@ -439,12 +439,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev) r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); if (r) - goto free_data; + goto unregister_clks; platform_set_drvdata(pdev, clk_data); return r; +unregister_clks: + mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data); free_data: mtk_free_clk_data(clk_data); return r; -- 2.35.0.rc2.247.g8bbb082509-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel