From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 463CCC433EF for ; Thu, 3 Feb 2022 16:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mjm6EBn8H6CtHW4vKp1w7EELcSJnBBeyyKrGS0r8vH8=; b=tBqxKYCQMdB8Bg JNHNE91TVhJcB1wq4s0gbZ76Zkg+/b6Em9sBYZlOk2q+7ap/Os+G8NRAA9e/O+DMPZH9T5ZhQZ/ov NoanAhOQO+D9nEVkh7BDJdRfUfZUVIzbLIXu8KBbY39fA+9KQQqS5DSnBrwP71j3Cm6bji3SGVQFN luKrQyVGyVBEgos9uPpjj9Bcie1MwouJLkaIX7avC/GMcnE0X9Qm6lSzHLCqzin4tN/1UgW0PCkm5 /z0VxUeKLaJuFS0lIJeQcm3xwobbbALDBCNh/F3Qa3/6tTWxufsnL88OCBZPjDFSDxeublOHpQywB lT/XTbU8LiYotBgKlcEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFeii-001xYm-L3; Thu, 03 Feb 2022 16:12:28 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFeid-001xWw-Uz; Thu, 03 Feb 2022 16:12:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 513BACE205C; Thu, 3 Feb 2022 16:12:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7A7BC340EF; Thu, 3 Feb 2022 16:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643904738; bh=tHVZdpOeaDUJxjE7UYVAKrIDf5NQfx3p8v5KExnPRz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NRtSFsbtCY6tw10trp0cRyK09ca2gwiH/rIdXiTLJzjOGCzluAwBbkC/FOneKXb4m wyu4NLQe1771JC36tpnNVoatGhSIQBdAMx4NcHdmEH51GeEvrvf93g1McL0a8Jhjaj DfNlgXSmy9+Z626IupK/gzi9yYKOyVLgRAddCvd61yiEhYPS0ltjVAd3HmAkDgXhZA XH2tEtfQ0aPHT7W4E1jbkjBuIWG9J6a2mPnLw1mOU8wsFu14bGHddJw6OpXodxsDX9 WpVAI0ZTszicK8BqmkjzHK/QUy3gvA1cpgwneme6SvipZ9tDTww+vwcWixC/vI3gvi hNdmx75bfd68Q== Date: Thu, 3 Feb 2022 21:42:10 +0530 From: Manivannan Sadhasivam To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Michael Turquette , Stephen Boyd , Andreas =?iso-8859-1?Q?F=E4rber?= , Saravanan Sekar , Parthiban Nallathambi , linux-actions@lists.infradead.org Subject: Re: [PATCH v2 1/4] clk: actions: Terminate clk_div_table with sentinel element Message-ID: <20220203161210.GA138829@thinkpad> References: <20220203142153.260720-1-j.neuschaefer@gmx.net> <20220203142153.260720-2-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220203142153.260720-2-j.neuschaefer@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220203_081224_267209_3D9362B7 X-CRM114-Status: GOOD ( 22.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 03, 2022 at 03:21:50PM +0100, Jonathan Neusch=E4fer wrote: > In order that the end of a clk_div_table can be detected, it must be > terminated with a sentinel element (.div =3D 0). > = > Fixes: d47317ca4ade1 ("clk: actions: Add S700 SoC clock support") > Fixes: d85d20053e195 ("clk: actions: Add S900 SoC clock support") > Signed-off-by: Jonathan Neusch=E4fer > --- > = > I'm not so sure about usb3_mac_div_table. Maybe the { 0, 8 } element was > meant to be { 0, 0 }? I'd appreciate if someone with access to the > datasheet or hardware could verify what's correct. USB3 factor table is not documented in the datasheet I have access to. But = by looking at the value, it looks to be a typo. So please change the last entr= y. With that, Reviewed-by: Manivannan Sadhasivam Thanks, Mani > = > v2: > - Add Fixes tags > --- > drivers/clk/actions/owl-s700.c | 1 + > drivers/clk/actions/owl-s900.c | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > = > diff --git a/drivers/clk/actions/owl-s700.c b/drivers/clk/actions/owl-s70= 0.c > index a2f34d13fb543..617174644f728 100644 > --- a/drivers/clk/actions/owl-s700.c > +++ b/drivers/clk/actions/owl-s700.c > @@ -162,6 +162,7 @@ static struct clk_div_table hdmia_div_table[] =3D { > = > static struct clk_div_table rmii_div_table[] =3D { > {0, 4}, {1, 10}, > + {0, 0}, > }; > = > /* divider clocks */ > diff --git a/drivers/clk/actions/owl-s900.c b/drivers/clk/actions/owl-s90= 0.c > index 790890978424a..f6f49100a865b 100644 > --- a/drivers/clk/actions/owl-s900.c > +++ b/drivers/clk/actions/owl-s900.c > @@ -139,8 +139,8 @@ static struct clk_div_table rmii_ref_div_table[] =3D { > }; > = > static struct clk_div_table usb3_mac_div_table[] =3D { > - { 1, 2 }, { 2, 3 }, { 3, 4 }, > - { 0, 8 }, > + { 1, 2 }, { 2, 3 }, { 3, 4 }, { 0, 8 }, > + { 0, 0 }, > }; > = > static struct clk_div_table i2s_div_table[] =3D { > -- > 2.34.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel