Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@suse.de>
To: Wolfram Sang <wsa@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH] i2c: bcm2835: Set clock-stretch timeout to 35ms
Date: Mon, 7 Feb 2022 17:41:50 +0200	[thread overview]
Message-ID: <20220207154150.yigvhzjvskzzmqpu@suse> (raw)
In-Reply-To: <YgE3jMkzisFZFHb5@shikoro>

On 02-07 16:15, Wolfram Sang wrote:
> Date: Mon, 7 Feb 2022 16:15:24 +0100
> From: Wolfram Sang <wsa@kernel.org>
> To: "Ivan T. Ivanov" <iivanov@suse.de>, Florian Fainelli
>  <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden
>  <sbranden@broadcom.com>, Nicolas Saenz Julienne <nsaenz@kernel.org>,
>  linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Phil
>  Elwell <phil@raspberrypi.org>
> Subject: Re: [PATCH] i2c: bcm2835: Set clock-stretch timeout to 35ms
> Message-ID: <YgE3jMkzisFZFHb5@shikoro>
Tags: all arm i2c linux me ring rpi
> 
> 
> > By default, busses are I2C and not SMBus, so it looks like we should
> > finally apply this patch which disables CLKT:
> > 
> > http://patchwork.ozlabs.org/project/linux-i2c/patch/1519422151-6218-1-git-send-email-stefan.wahren@i2se.com/
> 
> I applied this now to for-current and added stable. That should avoid
> unwanted timeouts.

Thanks! Unfortunately reporter went silent after I have prepared for him
kernel package with _this_ patch [1], so it will be difficult to verify
above change on my side.

> 
> > If you really want the SMBus timeout applied, you can check for a
> > "smbus" property in DT and then set CLKT accordingly in a seperate
> > patch.
> 
> This still holds.

Sure, will keep it in mind.

Regards,
Ivan

[1] https://bugzilla.suse.com/show_bug.cgi?id=1192976


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2022-02-07 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 10:25 [PATCH] i2c: bcm2835: Set clock-stretch timeout to 35ms Ivan T. Ivanov
2022-01-28  8:47 ` Ivan T . Ivanov
2022-01-28 10:37 ` Wolfram Sang
2022-02-07 15:15   ` Wolfram Sang
2022-02-07 15:41     ` Ivan T. Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220207154150.yigvhzjvskzzmqpu@suse \
    --to=iivanov@suse.de \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox