public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com,
	james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com,
	etienne.carriere@linaro.org, vincent.guittot@linaro.org,
	souvik.chakravarty@arm.com, peter.hilber@opensynergy.com,
	igor.skalkin@opensynergy.com, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/8] dt-bindings: firmware: arm,scmi: Add atomic_threshold optional property
Date: Tue, 8 Feb 2022 17:00:21 +0000	[thread overview]
Message-ID: <20220208170021.GE2535@e120937-lin> (raw)
In-Reply-To: <681e31c1-54d8-8a3e-ff0f-683cd5156685@gmail.com>

On Tue, Feb 08, 2022 at 08:12:39AM -0800, Florian Fainelli wrote:
> 
> 
> On 2/8/2022 7:44 AM, Cristian Marussi wrote:
> > SCMI protocols in the platform can optionally signal to the OSPM agent
> > the expected execution latency for a specific resource/operation pair.
> > 
> > Introduce an SCMI system wide optional property to describe a global time
> > threshold which can be configured on a per-platform base to determine the
> > opportunity, or not, for an SCMI command advertised to have a higher
> > latency than the threshold, to be considered for atomic operations:
> > high-latency SCMI synchronous commands should be preferably issued in the
> > usual non-atomic mode.
> > 

Hi Florian,

thanks for the feedback first of all.

> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > ---
> > v1 --> v2
> > - rephrased the property description
> > ---
> >   .../devicetree/bindings/firmware/arm,scmi.yaml        | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > index eae15df36eef..646bdf2873b5 100644
> > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > @@ -81,6 +81,15 @@ properties:
> >     '#size-cells':
> >       const: 0
> > +  atomic_threshold:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      An optional time value, expressed in microseconds, representing, on this
> > +      platform, the threshold above which any SCMI command, advertised to have
> > +      an higher-than-threshold execution latency, should not be considered for
> > +      atomic mode of operation, even if requested.
> > +      If left unconfigured defaults to zero.
> 
> Underscores in properties is not usually something that is desired, and it
> might be a good idea to put the unit in the property name, how about:
> atomic-threshold-us?
> 

I was indeed in doubt if it was desirable or not to have the units
embedded in the name ... thanks for the hint about the underscores too,

I'll fix nextV following your advice.

Thanks,
Cristian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-08 17:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 15:44 [PATCH v3 0/8] Add SCMI Virtio & Clock atomic support Cristian Marussi
2022-02-08 15:44 ` [PATCH v3 1/8] firmware: arm_scmi: Add a virtio channel refcount Cristian Marussi
2022-02-08 15:44 ` [PATCH v3 2/8] firmware: arm_scmi: Review virtio free_list handling Cristian Marussi
2022-02-08 15:44 ` [PATCH v3 3/8] firmware: arm_scmi: Add atomic mode support to virtio transport Cristian Marussi
2022-02-08 15:44 ` [PATCH v3 4/8] dt-bindings: firmware: arm, scmi: Add atomic_threshold optional property Cristian Marussi
2022-02-08 16:12   ` [PATCH v3 4/8] dt-bindings: firmware: arm,scmi: " Florian Fainelli
2022-02-08 17:00     ` Cristian Marussi [this message]
2022-02-08 15:44 ` [PATCH v3 5/8] firmware: arm_scmi: Support optional system wide atomic_threshold Cristian Marussi
2022-02-08 15:44 ` [PATCH v3 6/8] firmware: arm_scmi: Add atomic support to clock protocol Cristian Marussi
2022-02-08 15:44 ` [PATCH v3 7/8] firmware: arm_scmi: Add support for clock_enable_latency Cristian Marussi
2022-02-08 15:44 ` [PATCH v3 8/8] clk: scmi: Support atomic clock enable/disable API Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208170021.GE2535@e120937-lin \
    --to=cristian.marussi@arm.com \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=etienne.carriere@linaro.org \
    --cc=f.fainelli@gmail.com \
    --cc=igor.skalkin@opensynergy.com \
    --cc=james.quinlan@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hilber@opensynergy.com \
    --cc=robh+dt@kernel.org \
    --cc=souvik.chakravarty@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox