From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C8D4C433F5 for ; Tue, 8 Feb 2022 19:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FdjZEBaBUgR5McFniqpmVdnuxlfFpqXw8Xpi3K8jtLU=; b=cFasYUz9IoIjP0 f/bLt1X03PPyigT3Cgp+OBoi8llBBF01ArxS9DpZss6QsALLshkVJQ8Wm07U5W7hdhaS5npwtEU8G 3/1r1zosWm+nZOF1h+EnKby71wzpm/m7HWBgXNw7w3WU/hwO2vT/vB7314wlIeV+E0lelKmA4fJh4 vGvIeb0aCX1UBiXUTySiNy88plhnrpV0wv76lkynJF5L0cyNc2g51X+1r6yoWnWXqSb7W8AHKuPwz N8ywolU8xo8oqdS5ELbzSreYt2GV7Iy17uqRTHSJX4mzICSJtCYNJinKyFoJ0/B13MX+xTiLLSa3s 1qnXYuB8qPFbAQiYxvcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHVpL-00FMPf-6H; Tue, 08 Feb 2022 19:06:59 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHVpC-00FMMB-9D; Tue, 08 Feb 2022 19:06:53 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 218J6cbj046485; Tue, 8 Feb 2022 13:06:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1644347198; bh=6UqkATHFYuKMAaK02BGNEELKOaebX+fdRGwvNctEq64=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=opT1ONKvoXJeiWDy4C7+obV7cOaSEKXJp0DwOGZwB2jKBrjPCWqC3Kvh80OM4HrN5 PHjgX3pPUUhVAuJA9cA0M6669bUEwT8DUgejKSFMCEjCnofGhch26ZmzNP1Cv8jSJ5 o3QFhE2IOf9vzOSK6uCtXTtapOb0lYGVkgcuUM4Y= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 218J6caC084086 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Feb 2022 13:06:38 -0600 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 8 Feb 2022 13:06:37 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 8 Feb 2022 13:06:37 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 218J6axK108441; Tue, 8 Feb 2022 13:06:37 -0600 Date: Wed, 9 Feb 2022 00:36:36 +0530 From: Pratyush Yadav To: =?utf-8?Q?C=C3=A9dric?= Le Goater CC: Patrick Williams , Vignesh Raghavendra , , Tudor Ambarus , Richard Weinberger , Potin Lai , , Michael Walle , , Miquel Raynal , Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience Message-ID: <20220208190636.h6dubktkmuosvdxo@ti.com> References: <20211231102623.izaqlzjvracbbgmp@ti.com> <20220103171721.46c8e697@xps13> <20220105063244.lno3xur64uepa7i5@ti.com> <20220124153644.m3iwlvq5ld5cpbyz@ti.com> <20220124203708.lm23sgsub234wlhq@ti.com> <53d53523-7174-89fd-8661-550346d53141@kaod.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <53d53523-7174-89fd-8661-550346d53141@kaod.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_110650_461229_3B3DE418 X-CRM114-Status: GOOD ( 29.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/02/22 06:13PM, C=E9dric Le Goater wrote: > Hello, > = > On 1/24/22 21:37, Pratyush Yadav wrote: > > On 24/01/22 07:34PM, C=E9dric Le Goater wrote: > > > > > spimem needs an extension I think. Sorry I have not been able to > > > > > push that forward. Lack of time and other tasks to address on the > > > > > host side of the machine. This is really a software problem, we > > > > > have the HW procedures ready. If a spimem expert could get involv= ed > > > > > to make a few proposals, I would be happy to help and do some tes= ting. > > > > > QEMU models are good enough for the software part. We can do the > > > > > training validation on real HW when ready. > > > > = > > > > What information about the flash do you need for this training? > > > = > > > Last time I looked, we lacked some post_init handler to setup a slave: > > > configure the registers defining the AHB windows for each flash > > > slave and perform the read timing calibration. calibration should > > > only be done once. > > > = > > > See how the aspeed_spi_flash_init() routine doing the calibration > > > is hooked up under aspeed_spi_claim_bus() in the u-boot driver : > > = > > My patch series should provide a hook for doing the calibration _after_ > > the flash is initialized. > = > You can also use the .dirmap_create handler. The flash device has > been scanned when called and the size is available in the spi-mem > dirmap descriptor. I feel uncomfortable doing that since the API does not actually make = this guarantee. Who knows if a future change will violate that = assumption. That is why I added a new API call to explicitly mark the = flash as ready. I suppose you can get the op from the .dirmap_create = handler, but I guess we can debate that over the patches. > = > I reworked the current Aspeed driver with this approach and it > seems sufficient for read calibration. > = > Thanks, > = > C. > = -- = Regards, Pratyush Yadav Texas Instruments Inc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel