Re: [PATCH v3 07/31] clk: mediatek: cpumux: Internalize struct mtk_clk_cpumux

Chun-Jie Chen
2022-02-15T06:31:44Z

On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote:
> struct mtk_clk_cpumux is an implementation detail of the cpumux clk
> type, and is not used outside of the implementation.
>
> Internalize the definition to minimize leakage of details and shrink
> the header file.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>

Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> ---
> drivers/clk/mediatek/clk-cpumux.c | 8 ++++++++
> drivers/clk/mediatek/clk-cpumux.h | 8 --------
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-cpumux.c
> b/drivers/clk/mediatek/clk-cpumux.c
> index 99a819e3673f..344c6399b22f 100644
> --- a/drivers/clk/mediatek/clk-cpumux.c
> +++ b/drivers/clk/mediatek/clk-cpumux.c
> @@ -12,6 +12,14 @@
> #include "clk-mtk.h"
> #include "clk-cpumux.h"
>
> +struct mtk_clk_cpumux {
> + struct clk_hw hw;
> + struct regmap *regmap;
> + u32 reg;
> + u32 mask;
> + u8 shift;
> +};
> +
> static inline struct mtk_clk_cpumux *to_mtk_clk_cpumux(struct clk_hw
> *_hw)
> {
> return container_of(_hw, struct mtk_clk_cpumux, hw);
> diff --git a/drivers/clk/mediatek/clk-cpumux.h
> b/drivers/clk/mediatek/clk-cpumux.h
> index fda7770fd803..a538f2bbef0d 100644
> --- a/drivers/clk/mediatek/clk-cpumux.h
> +++ b/drivers/clk/mediatek/clk-cpumux.h
> @@ -7,14 +7,6 @@
> #ifndef __DRV_CLK_CPUMUX_H
> #define __DRV_CLK_CPUMUX_H
>
> -struct mtk_clk_cpumux {
> - struct clk_hw hw;
> - struct regmap *regmap;
> - u32 reg;
> - u32 mask;
> - u8 shift;
> -};
> -
> int mtk_clk_register_cpumuxes(struct device_node *node,
> const struct mtk_composite *clks, int
> num,
> struct clk_onecell_data *clk_data);