From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7215C4332F for ; Wed, 9 Feb 2022 09:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4xBXlSNNyccexcNVj8Dn+J9Mp/pJzdWIlq8HHdrNfio=; b=ctjWTAg6boMWwamzPNahKkATS5 Wlwxo9BLoG5BFFSRkOkb2bolTCE3DH44e1X0KR2rDK6Wxy9ApqMYyLsmAi30XqSsc3uQ9HYkWLpIU HocKGGQeQHZ1WgAEcXGzbOL1+i6KiHBJRuLenqTX9Fnv4Si+g6AOHBuwRnxkhN6Y8Do9A5nQlxS2w hlTS/HNXIdDq5MUa3QNtcrr3Agw54Gy4V5+BkJzUPPwZmMgYg6eACRUMkn8Zf53FQvcatg0TJ8JWC Moy+CavarjHcTAEJS8Z8EskBM7V9sIY2MQU9DNOzK26gbSbrE8+axEAzcpUrS9abIbdIeD/5Rnlse 0Rk/RLhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHj9g-00GsN1-NW; Wed, 09 Feb 2022 09:20:53 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHj9W-00GsLT-VT; Wed, 09 Feb 2022 09:20:45 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id B755D2B001F6; Wed, 9 Feb 2022 04:20:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 09 Feb 2022 04:20:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=SBTnBJKQIWPfpUR/56tNnSFnqOAge6wgqkQjX1 F+GWw=; b=CDpH6QDlK6etkYWwEufaBl86rsCLCUXcMo8QxESkub7gK+AFd4yqkb 6kBATCa0xGSUTrnFTWB2DgKWUcn2VOOo1B4/rGhPumCOmI815CwDKgYDmQJkn6eE JCSD1SyPZwknHxOLs5OpP/1Ky7yjerNewNl0+co96gyMNfKVibE/t45IAmiKT6U3 jJOwgU49qEiQ2QIAZZ72+TkTZ1W1b+pfNzutZ0nZeGu3iNguwhF2bfS4izy/8oSj I3V/B9OkThZYwYbZINt+rO9HeerVjk8Aacd5aLACXvceq5/LEaGe24C/Xfu2iIiq Qfd27O+bpPo+bAiwPEsfDEHYAi4cWfUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=SBTnBJKQIWPfpUR/5 6tNnSFnqOAge6wgqkQjX1F+GWw=; b=SuXPnSCidnnCw7+asKU9JhwD7CJo6XAmf RlC137mUb7s3vSeq/1VqjwOfxEa6wcMhGsRgKkskL75NP9aLUnE3Y8wzuG4w3pMe 4ozpoit7AylY8y1k90WXcD8563bbTh0JzGRWXTVqPWYJcDXg9Uoscs/ZH2OIGMlT W6JRy7mGxBBXVn7nCQ+JFMlyrZDxw1LPbsUynd27XAB6bWQhF9WLIn0AAumScQay xFxRLPiMm9aosDr5c7iqFqitBoP/oLCK/0hwA5DbYR9kWZ0I1p/B3YJ5x+ALo1tI DWoZkQL1FTdE25wc8drszHAEtcclHokxgmWl0Yz09tnej/utT/p3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheelgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Feb 2022 04:20:37 -0500 (EST) Date: Wed, 9 Feb 2022 10:20:35 +0100 From: Maxime Ripard To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Sakari Ailus , Hans Verkuil , Chen-Yu Tsai , Jernej Skrabec , Greg Kroah-Hartman , Helen Koike , Laurent Pinchart , Thomas Petazzoni Subject: Re: [PATCH v2 19/66] media: sun6i-csi: Grab bus clock instead of passing it to regmap Message-ID: <20220209092035.tz5ctosidpib47fq@houat> References: <20220205185429.2278860-1-paul.kocialkowski@bootlin.com> <20220205185429.2278860-20-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20220205185429.2278860-20-paul.kocialkowski@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_012043_155561_CCC93859 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1127202567780399495==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1127202567780399495== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yjjnfllv4wtw5ufd" Content-Disposition: inline --yjjnfllv4wtw5ufd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Feb 05, 2022 at 07:53:42PM +0100, Paul Kocialkowski wrote: > Since the bus clock alone is not enough to get access to the registers, > don't pass it to regmap and manage it instead just like the other > clocks. >=20 > Signed-off-by: Paul Kocialkowski I'm not really sure about this one. Sure, there's more resources involved than the clock to get access to the registers (like reset), but you can't have a functional device without the reset line deasserted. You can however have a functional device without the bus clock enabled, so it just seems much better to let regmap manage it. Unless there's a drawback to it of course, but it should be in your commit log if so. Maxime --yjjnfllv4wtw5ufd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYgOHYwAKCRDj7w1vZxhR xVdlAP9xWWz+r+5yqqSyDREBt4wUIYsOPLYBVd8MDdUu/WQGfgEAkFTtNt3mcKcT DWTcs0AATTN6+sept16oF0pNbheHkA0= =mR// -----END PGP SIGNATURE----- --yjjnfllv4wtw5ufd-- --===============1127202567780399495== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1127202567780399495==--