From: Leo Yan <leo.yan@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator
Date: Wed, 9 Feb 2022 17:33:04 +0800 [thread overview]
Message-ID: <20220209093304.GA334894@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <6b91293a-1149-2c77-04a4-421a45d4e1e0@arm.com>
Hi Suzuki,
On Wed, Feb 09, 2022 at 05:47:24AM +0000, Suzuki Kuruppassery Poulose wrote:
> Hi Leo
>
> On 04/02/2022 15:24, Leo Yan wrote:
> > Updates to the values and the index are protected via the spinlock.
> > Ensure we use the same lock to read the value safely.
> >
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> > ---
> > drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> > index 10ef2a29006e..2f3b4eef8261 100644
> > --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> > +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> > @@ -2111,7 +2111,9 @@ static ssize_t vmid_val_show(struct device *dev,
> > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent);
> > struct etmv4_config *config = &drvdata->config;
> > + spin_lock(&drvdata->spinlock);
> > val = (unsigned long)config->vmid_val[config->vmid_idx];
> > + spin_unlock(&drvdata->spinlock);
> > return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
> > }
>
>
> I have queued this patch.
Thanks!
> For the rest, we would need to wait until the helper lands in the rc.
The helper function patch has been landed on the mainline kernel,
it would be safe to merge the rest patches.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d7e4f8545b497b3f5687e592f1c355cbaee64c8c
BTW, I think you could pick another two refactoring patches:
https://lore.kernel.org/lkml/20220204135051.60639-2-leo.yan@linaro.org/
https://lore.kernel.org/lkml/20220204135051.60639-3-leo.yan@linaro.org/
Thanks,
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-09 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 15:23 [PATCH v2 RESEND 0/4] coresight: etm: Correct PID tracing for non-root namespace Leo Yan
2022-02-04 15:24 ` [PATCH v2 RESEND 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator Leo Yan
2022-02-09 5:47 ` Suzuki K Poulose
2022-02-09 9:33 ` Leo Yan [this message]
2022-02-09 9:42 ` Suzuki K Poulose
2022-02-09 16:58 ` Mathieu Poirier
2022-02-04 15:24 ` [PATCH v2 RESEND 2/4] coresight: etm4x: Don't use virtual contextID for non-root PID namespace Leo Yan
2022-02-04 15:24 ` [PATCH v2 RESEND 3/4] coresight: etm4x: Don't trace PID " Leo Yan
2022-02-04 15:24 ` [PATCH v2 RESEND 4/4] coresight: etm3x: " Leo Yan
2022-02-25 13:52 ` [PATCH v2 RESEND 0/4] coresight: etm: Correct PID tracing for non-root namespace Suzuki K Poulose
2022-02-28 6:17 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209093304.GA334894@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox