From: Nishanth Menon <nm@ti.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
linux-arm-kernel@lists.infradead.org,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tudor Ambarus" <Tudor.Ambarus@microchip.com>,
"Pratyush Yadav" <p.yadav@ti.com>,
"Michael Walle" <michael@walle.cc>,
linux-mtd@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] mtd/memory: omap: Fix build dependencies
Date: Wed, 9 Feb 2022 09:21:07 -0600 [thread overview]
Message-ID: <20220209152107.5h2zpcpe5gyqwmuj@bottom> (raw)
In-Reply-To: <7572e50b-3e6b-2888-a9e0-3ca5020c7e0e@kernel.org>
On 16:39-20220209, Roger Quadros wrote:
> >> config OMAP_GPMC
> >> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> >> - depends on OF_ADDRESS
> >
> > Thoughts Roger?
>
> OMAP_GPMC is not visible entry so someone has to select it.
> We first tried selecting it in ARCH_K3 but that was not accepted for fair reason.
> Then we tried to select it from MTD_NAND_OMAP2 and it caused the issue this patch is trying to fix.
>
> Only other option left is to make OMAP_GPMC a visible entry and just mark MTD_NAND_OMAP2 to depend on it?
> The relevant SoC defconfig files can enable OMAP_GPMC and MTD_NAND_OMAP2.
>
> Does this sound ok?
Given that of_address.h is handling OF_ADDRESS smartly, and the fact
that there are quite the many drivers that are actually OF only, I am
not entirely sure why the dependency is needed in Kconfig, but that is
just me..
I'd suggest to see with the randconfig that Randy provided in [1]
[1] https://lore.kernel.org/all/b18fc937-9cc2-bb7b-fb58-3ba2555371c7@infradead.org/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-02-09 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 10:56 [PATCH] mtd/memory: omap: Fix build dependencies Miquel Raynal
2022-02-09 13:57 ` Nishanth Menon
2022-02-09 14:10 ` Krzysztof Kozlowski
2022-02-09 14:39 ` Roger Quadros
2022-02-09 15:21 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209152107.5h2zpcpe5gyqwmuj@bottom \
--to=nm@ti.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=catalin.marinas@arm.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=rogerq@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox