From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC44FC433F5 for ; Thu, 10 Feb 2022 13:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nJwPaiHsnJTA98MoOwRcqBxaB7LN7oQzJH4YGMVF8qs=; b=HvCmeHOpJZ0/Kx LZUGVgDhIzuR/JZugi1g6jSiK4NN1spVEIcJH+R4N3Ni1kJb3lpdtO5Kxf5qdnFMXK7PjQ1AMRWL2 VCuBBJRxpkAQ5YmWgdGk/srr2BJWxa+ucreWHPe9qeee+PzIActgf824pjbMjblru3ZvLItgHibk5 sMF0e/vqQTyDirdn1lPELtmnMLqs1Qh93BRvJjXiRxoY9naY9cKDMGOz/hBz5vVKGsxyCh2fZWvfu 1oqggMnQU03lu5HjVVtXYd4Ts0QHcpK1Hhy6WWF1KzKLWAdSlvNTTBB1MMP1D5Zrt1VuHHwSLnODg SlO5iZ6XSoV6mQd+PIcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI9eD-003vAx-FT; Thu, 10 Feb 2022 13:38:09 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI9e9-003v9K-6c for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 13:38:06 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nI9e7-0002X5-78; Thu, 10 Feb 2022 14:38:03 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nI9e3-00033k-5d; Thu, 10 Feb 2022 14:37:59 +0100 Date: Thu, 10 Feb 2022 14:37:59 +0100 From: Sascha Hauer To: Johan Jonker Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Message-ID: <20220210133759.GZ18637@pengutronix.de> References: <20220209095350.2104049-1-s.hauer@pengutronix.de> <20220209095350.2104049-20-s.hauer@pengutronix.de> <3492afbf-b9fc-d5f5-6f7a-2157442d8209@gmail.com> <20220210114746.GX18637@pengutronix.de> <2fa2e53d-da1c-6957-33ed-f3e9806347cf@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2fa2e53d-da1c-6957-33ed-f3e9806347cf@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:33:40 up 61 days, 22:19, 81 users, load average: 0.13, 0.24, 0.25 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_053805_267342_9DBF7600 X-CRM114-Status: GOOD ( 37.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 10, 2022 at 02:15:17PM +0100, Johan Jonker wrote: > > > On 2/10/22 12:47, Sascha Hauer wrote: > > On Thu, Feb 10, 2022 at 01:10:32AM +0100, Johan Jonker wrote: > >> Hi Sascha, > >> > >> Something with port and endpoint gives notifications. > >> Somehow with the conversion of rockchip,dw-hdmi.txt to YAML not all SoC > >> options were checked/covered (see rk3328 and rk3568). > >> > >> Allow multiple vop: > >> port or > >> port@0 > >> 1x vop -> endpoint > >> > >> 2x vop -> endpoint@0 > >> -> endpoint@1 > >> > >> Also allow for connector: > >> (not all existing DT have this yet) > >> port@1 > >> -> endpoint > >> > >> See also at graph.yaml > > > > Ok, let me see if I get this right. The HDMI can either have one or two > > ports. It has one when the HDMI connector is not described in the device > > tree and two when it is. Also the first (or only) port can have one or > > two endpoints. It has one endpoint when the SoC has a single VOP and two > > endpoints when the SoC has two VOPs. > > > > It's been a painful morning because my YAML knowledge is fairly limited, > > but here's what I came up with: > > > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > unevaluatedProperties: false > > patternProperties: > > "^port(@0)?$": > > $ref: /schemas/graph.yaml#/properties/port > > description: Input of the DWC HDMI TX > > properties: > > endpoint: > > description: Connection to the VOP > > endpoint@0: > > description: Connection to the VOPB > > endpoint@1: > > description: Connection to the VOPL > > properties: > > port@1: > > $ref: /schemas/graph.yaml#/properties/port > > description: Output of the DWC HDMI TX > > > > Does this look sane to you? With this a make dtbs_check on this binding > > doesn't generate warnings anymore, and even better it does generate > > warnings when I add some wrong nodes/properties to the dts files. > > Hi, > > Send a patch to rob+dt and he will let you know... ;) ;) > > Also could you test the ARM branch as well just for sure with: > ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml That works fine except for iahb and isfr clocks in the wrong order in arch/arm/boot/dts/rk322x.dtsi. > > Could you group your serie a bit: > dt-bindings > drm patches > dts changes That's the order I originally had. Heiko asked me to put the bindings, dts changes and driver patches together dor each topic. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel