From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 805E2C433EF for ; Thu, 10 Feb 2022 18:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=At33LnSRCYUOHkfn2dBOO6LIyQ7kGplVo7q/QZ88sro=; b=bw2eANuMfjFLwX sO2IX0c/Ja73b2t/iON0ULrY8tBFg74Oe6U7xgxqBr/KZpIsl0SLatZXpNPfgNN4Plw5fdAodrf/C BArd4nu7XPl7l5++M4yjzdfqu+6H8YvZzCiFeIOobaECwn/4L4+6BSwYRv685AaoQz8MgyGwRqBcI ITgxPwQGukRvmYPaJ+MpqcVJ/6i0eO0gwXQhniDq5tfs5GUEgP93d7UKP6bUrnsa8m8sqW5nM5L74 tTY/UdHBKD01sOKTgEgdAhYAii+rKzfI9jxcLAfrnL87kTK4s5IPXdEarTA0TFkKiCwVVxRScwu9s lhkjceNFticnuv46UR9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIEc4-004gfR-JE; Thu, 10 Feb 2022 18:56:16 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIEc0-004gdo-JT; Thu, 10 Feb 2022 18:56:14 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 306371F46711 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644519369; bh=p879cBETubHXdemY/PEQK5hOnKUPCYkbBd8qPEuZydk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HUGcHd7Eryz+IswgcaQeXj1SE1zmzZPq8xlW/QQqmSZfcArilD7EgsPxJI4F7e4sY 3SifqfLzbqXCbpE5sGfmg+cpRFfmqzoT2Rglv6woYuhs2+gDO2b9Mefr+IBYx9Cetb jXDqwGj78rL6j/sTIGD71YEhycfwVcmMROXV5bu6MO523USIhayfBfuDSVhmE9WJEV m2GIVq4RscFBadbXfFU8JV5ROwmH13cp1p0sk8/iwscy7U6uQFSQDJYAjU9ENJk4b5 hMs9kdjtkVa9mwbrXz7JBGleZJ3zXxP0WBw5uoVLNniUYVxr1uZeuv/JGYBPTgYl+c Myk+Ebay3vFbQ== Date: Thu, 10 Feb 2022 13:56:03 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Andrew-sh.Cheng" Cc: Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH v2] arm64: dts: mediatek: Add Mediatek mt8192 cpufreq device nodes Message-ID: <20220210185603.lmgf4ppppe3ccscj@notapiano> References: <1609223471-24325-1-git-send-email-andrew-sh.cheng@mediatek.com> <20220210144659.2vkuuh74xagic3ud@notapiano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220210144659.2vkuuh74xagic3ud@notapiano> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_105613_008239_0B7E1FCA X-CRM114-Status: GOOD ( 23.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi again, please see my comment below. On Thu, Feb 10, 2022 at 09:47:04AM -0500, N=EDcolas F. R. A. Prado wrote: > Hi Andrew, > = > On Tue, Dec 29, 2020 at 02:31:11PM +0800, Andrew-sh.Cheng wrote: > > From: "Andrew-sh.Cheng" > > = > > Correct dts node name in patch v1: performance-domain > > This patch depends on [1] and [2]. > > = > > [1]http://lists.infradead.org/pipermail/linux-mediatek/2020-November/01= 9378.html > > [2]https://patchwork.kernel.org/project/linux-mediatek/patch/1607586516= -6547-3-git-send-email-hector.yuan@mediatek.com/ > = > Those two series are now merged, so no dependencies missing for this patc= h any > longer. > = > Please rebase this patch, as there are some conflicts. I've already verif= ied it, > and after you rebase I can send a reviewed-by. > = > Thanks, > N=EDcolas > = > > = > > Signed-off-by: Andrew-sh.Cheng > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > = > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot= /dts/mediatek/mt8192.dtsi > > index 69d45c7b31f1..a907ee7e650a 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -39,6 +39,7 @@ > > compatible =3D "arm,cortex-a55"; > > reg =3D <0x000>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 0>; > > clock-frequency =3D <1701000000>; > > next-level-cache =3D <&l2_0>; > > capacity-dmips-mhz =3D <530>; > > @@ -49,6 +50,7 @@ > > compatible =3D "arm,cortex-a55"; > > reg =3D <0x100>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 0>; > > clock-frequency =3D <1701000000>; > > next-level-cache =3D <&l2_0>; > > capacity-dmips-mhz =3D <530>; > > @@ -59,6 +61,7 @@ > > compatible =3D "arm,cortex-a55"; > > reg =3D <0x200>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 0>; > > clock-frequency =3D <1701000000>; > > next-level-cache =3D <&l2_0>; > > capacity-dmips-mhz =3D <530>; > > @@ -69,6 +72,7 @@ > > compatible =3D "arm,cortex-a55"; > > reg =3D <0x300>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 0>; > > clock-frequency =3D <1701000000>; > > next-level-cache =3D <&l2_0>; > > capacity-dmips-mhz =3D <530>; > > @@ -79,6 +83,7 @@ > > compatible =3D "arm,cortex-a76"; > > reg =3D <0x400>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 1>; > > clock-frequency =3D <2171000000>; > > next-level-cache =3D <&l2_1>; > > capacity-dmips-mhz =3D <1024>; > > @@ -89,6 +94,7 @@ > > compatible =3D "arm,cortex-a76"; > > reg =3D <0x500>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 1>; > > clock-frequency =3D <2171000000>; > > next-level-cache =3D <&l2_1>; > > capacity-dmips-mhz =3D <1024>; > > @@ -99,6 +105,7 @@ > > compatible =3D "arm,cortex-a76"; > > reg =3D <0x600>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 1>; > > clock-frequency =3D <2171000000>; > > next-level-cache =3D <&l2_1>; > > capacity-dmips-mhz =3D <1024>; > > @@ -109,6 +116,7 @@ > > compatible =3D "arm,cortex-a76"; > > reg =3D <0x700>; > > enable-method =3D "psci"; > > + performance-domains =3D <&performance 1>; > > clock-frequency =3D <2171000000>; > > next-level-cache =3D <&l2_1>; > > capacity-dmips-mhz =3D <1024>; > > @@ -194,6 +202,12 @@ > > compatible =3D "simple-bus"; > > ranges; > > = > > + performance: performance-controller@0011bc00 { Actually there is a warning being introduced here on dtbs_check: soc: 'performance-controller@0011bc00' does not match any of the regexes: = '@(0|[1-9a-f][0-9a-f]*)$', '^[^@]+$', 'pinctrl-[0-9]+' From schema: [...]/dtschema/schemas/simple-bus.yaml So you should also change the address to not start with zeros: 11bc00 Thanks, N=EDcolas > > + compatible =3D "mediatek,cpufreq-hw"; > > + reg =3D <0 0x0011bc10 0 0x120>, <0 0x0011bd30 0 0x120>; > > + #performance-domain-cells =3D <1>; > > + }; > > + > > gic: interrupt-controller@c000000 { > > compatible =3D "arm,gic-v3"; > > #interrupt-cells =3D <4>; > > -- = > > 2.12.5 > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel