From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 380B9C433F5 for ; Fri, 11 Feb 2022 08:58:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lf3w0YEaTLlL8jbdxsheiPERCe5DHpaJAxcpRXa6qdE=; b=V6nXxC1bNTopl+ WePWvTQmeZWjGfXpz0OpVVo75dhy2snFcsBkpNTYeiBi3q7BQFnGl8Q5uq+lvo/1e/XsXrHgD/j5a 0s8rkfmrsEdbkRKiZFd0xp7GoUcqamNkydjsGQp7DPmFA0BqT8e4tgiXT9RgDd5x3CymzvGyTBmfc 9m1rGidrq+r1kVnbOZEvqpnqR7QKWup5/0nPDayAG2krOF+zNpKEtX7mPf6sh//BNcxM2mdCK8xNi H4EDqbZRqucp/M7qSH147Ga623xRhvJH6fm19n2B4kiVoEB1hwSZU38s0YT2QRzqQaGPHeCRNXqio fJ3G8rTgZH4Rv4q2x7yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIRjv-006G6z-A1; Fri, 11 Feb 2022 08:57:15 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIRjr-006G5u-7z for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 08:57:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD04DB828BF; Fri, 11 Feb 2022 08:57:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 982E0C340E9; Fri, 11 Feb 2022 08:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644569828; bh=Z1hdFw/aj47eNjrve8QSKR6IQytXdTYgGyB3PpHw4dk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dwcyzNAdASY4KX+7L2O15ZAYg1ePnVgVVCFMT8DR5Jc/ol/IPfK/hOSNOv68muVRT 7dPerExB3N4q1mluihGLzMl9msY2QhRNiSEiedQmEBtCvpT98SviQAAu+qVhnJ4UTJ KTr8hG3E7J8tpsRegMBbaada720zawdxp9x4CXvn7Yh4+mPQChTiBxISeLwwLiVGo2 bjCQ0iMwWNUGlE5/7nlKT7OgXMz3fxYCXLg6hnRT1QLu8UuNpFWTKyHYlPz4BSlDJQ Px9+SioGlK3mle9ABPgUrRp40i0PGLE7VzS8A2Pa6/lxY9NnJ1sNzE7uZUU9trXQoC dVJIQBtQvBHhg== Date: Fri, 11 Feb 2022 16:57:03 +0800 From: Shawn Guo To: Vladimir Oltean Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Rob Herring , Leo Li Subject: Re: [PATCH 1/2] arm64: dts: fsl-ls1028a-qds: Drop overlay syntax hard coding Message-ID: <20220211085703.GR4909@dragon> References: <20220129070912.9836-1-shawnguo@kernel.org> <20220129070912.9836-2-shawnguo@kernel.org> <20220131110659.7lu7ccfcktfhgddm@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220131110659.7lu7ccfcktfhgddm@skbuf> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_005711_471502_601A9377 X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 31, 2022 at 11:07:00AM +0000, Vladimir Oltean wrote: > Hi Shawn, > > On Sat, Jan 29, 2022 at 03:09:11PM +0800, Shawn Guo wrote: > > As suggested by commit 9ae8578b517a ("of: Documentation: change overlay > > example to use current syntax"), there is no need to have overlay syntax > > be hard coded in the device tree source file any more. > > > > Signed-off-by: Shawn Guo > > --- > > This looks good. > > Reviewed-by: Vladimir Oltean > > Just one minor comment below: > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts > > index 8ffb707a1576..bd88438c2ecd 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts > > @@ -11,98 +11,78 @@ > > /dts-v1/; > > /plugin/; > > > > -/ { > > - fragment@0 { > > - target = <&mdio_slot1>; > > - > > - __overlay__ { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - slot1_sgmii: ethernet-phy@2 { > > - /* AQR112 */ > > - reg = <0x2>; > > - compatible = "ethernet-phy-ieee802.3-c45"; > > - }; > > - }; > > - }; > > +&mdio_slot1 { > > > > Can you please delete this blank line? Fixed. Thanks for spotting it, Vladimir! Shawn > > > - fragment@1 { > > - target = <&enetc_port0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > > > - __overlay__ { > > - phy-handle = <&slot1_sgmii>; > > - phy-mode = "2500base-x"; > > - managed = "in-band-status"; > > - status = "okay"; > > - }; > > + slot1_sgmii: ethernet-phy@2 { > > + /* AQR112 */ > > + reg = <0x2>; > > + compatible = "ethernet-phy-ieee802.3-c45"; > > }; > > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel