From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53C7EC433F5 for ; Fri, 11 Feb 2022 15:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VG9IK58pb+6Vd8xafyVvUFupuuryRQLsOJZZBP7BZCY=; b=15EJ6FtUhd5JpR CrrnP4oA6LIZTnwyFQiQLu0ZuSrPyNjjNqSwgKI/eqqQ1q9LunkjCLyTRx/irBh0y5P7rEwVsTDL4 yMaOyKcRlmXz3KkQA4XpqyCCpVvhAngfWi/yyhV7wex5MKpao11zm9JHQrfQdJ9A3dClxVLScpkEI wfkq9tQz4tZTcaBr0C+xzL3umKw1lXql9nAjhbvYbv6GklHlMateIYGn40yl3dU9t/hStdrae9YQm M1/3lzDm9lyuQh7X+3bpWODYPvTm6BhYMPvPgOe/ItE5+wuGj3xGsAv5ctMSFITfg+XwYUUWaeVus Po57RHTDDDtnS/YNm1fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIXdX-007jzx-KL; Fri, 11 Feb 2022 15:15:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIXdP-007jwv-4n for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 15:14:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2CD08106F; Fri, 11 Feb 2022 07:14:52 -0800 (PST) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3F4453F718; Fri, 11 Feb 2022 07:14:50 -0800 (PST) From: Mark Rutland To: linux-kernel@vger.kernel.org Cc: acme@redhat.com, ardb@kernel.org, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, jpoimboe@redhat.com, jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, mingo@redhat.com, ndesaulniers@google.com, peterz@infradead.org, tglx@linutronix.de, will@kernel.org Subject: [PATCH v3 0/5] linkage: better symbol aliasing Date: Fri, 11 Feb 2022 15:14:40 +0000 Message-Id: <20220211151445.2027553-1-mark.rutland@arm.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_071455_303825_B5AC0D5E X-CRM114-Status: UNSURE ( 8.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series aims to make symbol aliasing simpler and more consistent. The basic idea is to replace SYM_FUNC_START_ALIAS(alias) and SYM_FUNC_END_ALIAS(alias) with a new SYM_FUNC_ALIAS(alias, name), so that e.g. SYM_FUNC_START(func) SYM_FUNC_START_ALIAS(alias1) SYM_FUNC_START_ALIAS(alias2) ... asm insns ... SYM_FUNC_END(func) SYM_FUNC_END_ALIAS(alias1) SYM_FUNC_END_ALIAS(alias2) EXPORT_SYMBOL(alias1) EXPORT_SYMBOL(alias2) ... can become: SYM_FUNC_START(name) ... asm insns ... SYM_FUNC_END(name) SYM_FUNC_ALIAS(alias1, func) EXPORT_SYMBOL(alias1) SYM_FUNC_ALIAS(alias2, func) EXPORT_SYMBOL(alias2) This avoids repetition and hopefully make it easier to ensure consistency (e.g. so each function has a single canonical name and associated metadata). I've build-tested the following with both GCC 10.3.0 and LLVM 13.0.0 without issues (ignoring any existing warnings): * arm omap1_defconfig (v2 broke with LLVM here) * arm multi_v7_defconfig * arm64 defconfig * i386 defconfig * x86_64 defconfig I've boot-tested the arm64 Images. I've pushed the series to my `linkage/alias-rework` branch on git.kernel.org, atop v5.17-rc2: git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git linkage/alias-rework https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=linkage/alias-rework Since RFCv1 [1]: * Drop arm64 dma alias removal (taken via arm64 for v5.17-rc1) * Rename SYM_FUNC_LOCAL_ALIAS() -> SYM_FUNC_ALIAS_LOCAL() * Update the tools/ copies of x86 routines * Add preparatory fix for 32-bit arm * Rebase to v5.17-rc1 Since v2 [2]: * Rework to be LLVM-compatible - Drop SYM_ENTRY_AT() / SYM_END_AT() - Drop unnecessary local symbols - Calculate size in SYM_END() - Use common SYM_ALIAS() * Drop newly redundant arch/arm changes * Clarify commit message wording * Fix typos [1] https://lore.kernel.org/r/20211206124715.4101571-1-mark.rutland@arm.com/ [2] https://lore.kernel.org/r/20220125113200.3829108-1-mark.rutland@arm.com/ Thanks, Mark. Mark Rutland (5): linkage: add SYM_FUNC_ALIAS{,_LOCAL,_WEAK}() arm64: clean up symbol aliasing x86: clean up symbol aliasing linkage: remove SYM_FUNC_{START,END}_ALIAS() tools: update x86 string routines Documentation/asm-annotations.rst | 11 ++-- arch/arm64/include/asm/linkage.h | 24 --------- arch/arm64/kvm/hyp/nvhe/cache.S | 5 +- arch/arm64/lib/clear_page.S | 5 +- arch/arm64/lib/copy_page.S | 5 +- arch/arm64/lib/memchr.S | 5 +- arch/arm64/lib/memcmp.S | 6 +-- arch/arm64/lib/memcpy.S | 21 ++++---- arch/arm64/lib/memset.S | 12 +++-- arch/arm64/lib/strchr.S | 6 ++- arch/arm64/lib/strcmp.S | 6 +-- arch/arm64/lib/strlen.S | 6 +-- arch/arm64/lib/strncmp.S | 6 +-- arch/arm64/lib/strnlen.S | 6 ++- arch/arm64/lib/strrchr.S | 5 +- arch/arm64/mm/cache.S | 35 +++++++------ arch/x86/boot/compressed/head_32.S | 3 +- arch/x86/boot/compressed/head_64.S | 3 +- arch/x86/crypto/aesni-intel_asm.S | 4 +- arch/x86/lib/memcpy_64.S | 10 ++-- arch/x86/lib/memmove_64.S | 4 +- arch/x86/lib/memset_64.S | 6 +-- include/linux/linkage.h | 67 +++++++++++++------------ tools/arch/x86/lib/memcpy_64.S | 10 ++-- tools/arch/x86/lib/memset_64.S | 6 +-- tools/perf/util/include/linux/linkage.h | 46 ++++++++++++----- 26 files changed, 169 insertions(+), 154 deletions(-) -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel