From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05511C433EF for ; Fri, 11 Feb 2022 15:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UM3zcgczVRlO/zQTA60php9DB/rxXSBYEmgp5O2F2vU=; b=W8+6EM+O/bw+Xz M2NV299IBIBSCV+PSGhxYos0VwpnU+3VotVddrWfyKX5h0JIUjFW9/5kSuB6u3j0L4q9/MHtX/Io7 5QdKbd1u/UuCTrNvppvY2Edf51oiqcBwn9owhUxZrOji6nDWr2ZQJv19vl0tuaMlrcVPd/C807PwU hHo3uSAOkVLgJLD6RQclLBZ8xE7bNr3GgRL2tcHB67L+tLXABZuA2JDr52QUMn+y4K7+DczCuiQWD 24LTf3u/TcMyqlZ3sOkxqRlQ0vgq3OeqXfSu/2WWDtJfZ+IoMicq1HqSNrLgOS966PfC13aCMClXL YXZ1xHKPnaKKhJQQCExA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIXj2-007miu-Ep; Fri, 11 Feb 2022 15:20:44 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIXiw-007mg8-SL for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 15:20:41 +0000 Received: by mail-ed1-x534.google.com with SMTP id g7so988511edb.5 for ; Fri, 11 Feb 2022 07:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=A+pYq3gAvDRIBXzI8fOr1NWPq9Ez2hj6zeRc/MxGX5U=; b=XmIhBe0BW8s4Ne/ySLnWsQWfdi8M/ADrEQJrnY9xyXzT/oeRrWbnAaaPbsZsd/Thon ApfBEUIWpk/fY9kPrV0o6nd6jPQLWWBw5Kb5l53H/Ue7VgF97ZNjLGIObcxM8mdRlH97 wGJD4a9OGsNDKB7gVIjnbWaGxtBmyq5EvSVmighL+7lYdWSu/0unIakZ+57yS2ZcwfD7 kKRbwxmymXMhHSr9ppVsNcYIuudAD74mlMib6g0ZsTWNBoDOYCEPU5m5hlzFfOLeZvW8 4m965OzMozN2Uk8O9QpZQ3AyuQPrtCFir0JktrAdzv1JLXdowNN1TR1nVn7criYg/kPL TOfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=A+pYq3gAvDRIBXzI8fOr1NWPq9Ez2hj6zeRc/MxGX5U=; b=B+aZaW0Vn55bX0isWGNMhgy+pZgcLf/rE7zR39HPjrccaP8Wo7fbxNo6LYXNHbb6rr i/YLTJjPpQBHv44HxnXR+//IlxPb0ykBDfdGSBA4ZotB1bhF6snAgoD+0xWxLq0fVzip xXHiQU6Iggh3G6bi19vXWVnK3MN19TLcdEH3HbvH0QG8w0GRWUjfW0VeLWlq+pfbPEmv dZRlxiIGuu7ifgmyaaIvdu3GmiRE5bpGmbWyFXRb3nbqgcX2BIoNcGehctcCLtvERnTs 7TfhEYaUBm4s2UJUv7GyT+xtH3+AolXCIR86wiA0R1AFzx9RKRCdy7bC3FlVTgHfQZoO qnwg== X-Gm-Message-State: AOAM5310mDO8RcOhrVdGq87yoSZa5Pjqh5hNrQ1Sm/m17SknSh4usylR gOwW7i/khuBvyunNDAw64JZJeA== X-Google-Smtp-Source: ABdhPJwszJf8Sr9G+6mqytFUQlGUOUee0R8RNKRV/mCvOx3IsJhsrx0miYsUPgVbSRRKz/HPV1lxVg== X-Received: by 2002:a05:6402:2284:: with SMTP id cw4mr2458951edb.436.1644592836609; Fri, 11 Feb 2022 07:20:36 -0800 (PST) Received: from leoy-ThinkPad-X240s ([104.245.96.223]) by smtp.gmail.com with ESMTPSA id z8sm7909941ejc.151.2022.02.11.07.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 07:20:35 -0800 (PST) Date: Fri, 11 Feb 2022 23:20:26 +0800 From: Leo Yan To: James Clark Cc: acme@kernel.org, linux-perf-users@vger.kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, Mike Leach , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf: cs-etm: No-op refactor of synth opt usage Message-ID: <20220211152026.GC475776@leoy-ThinkPad-X240s> References: <20220210200620.1227232-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220210200620.1227232-1-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_072039_008165_50240140 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 10, 2022 at 08:06:19PM +0000, James Clark wrote: > sample_branches and sample_instructions are already saved in the > synth_opts struct. Other usages like synth_opts.last_branch don't save > a value, so make this more consistent by always going through synth_opts > and not saving duplicate values. > > Signed-off-by: James Clark The patch looks good to me: Reviewed-by: Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel