From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24551C433EF for ; Sat, 12 Feb 2022 05:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HC7E2/ZLhBbEaSC3vgj6UVykWelNP7vrXdNTtY/H9hw=; b=T34DMA7H0StTbn rlWF7lzw/1VMISNnxyaAUNDGWrSs7Rxts9owmU82ziUGA3xhDKgPN5WyBq3UxTFuD6pKyxZV8Skyq i9ok89aGHJJawLnJ4P3UP0BHGORe4fTEduvn1Fek6AVbxNU5YQzYS1kQVVZwicUCYNsZtM28jn4o1 rN8XgUtw2uSyP55NYmtzwb1d/ZOtUpVaI98IdHUxzb/5cFTGyi70IUUAKGg0IThiK1SBYehg55mUA SzBYNuzmDMo7G6MkOgziVDhaZNCb1JwOy9A68tTN8xBQw+qjfktVH4GYNdrIs/i8qlJIJkzZQow6n 67iINJ29dJwj0xxcTHig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIlF1-009RLT-GH; Sat, 12 Feb 2022 05:46:40 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIlEx-009RKP-Sa for linux-arm-kernel@lists.infradead.org; Sat, 12 Feb 2022 05:46:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C83FB82E5D; Sat, 12 Feb 2022 05:46:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CD39C340ED; Sat, 12 Feb 2022 05:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644644793; bh=D8Z7s01IRXNMSKDuM2y3UXpuZ9sPd9PVWLyQABy4pE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LfdSAuG7i8zkiDFXomC+6PKzqNDPkVibzZzI6+8ERXRPGJbSVM88H7bTRGR0xssip sLDrYieXdZbg/RYLkm63X/eXkpjGWe/xgtHQR2QpEZbBkvZxmQslvqNJt/qCBeX0AM nCFTx6hAqYqJ0lVQqbbDWUjpBoLf/hNbsMyQEnRtU9tPtZtmIDI14Uu5XbYhsgqeOv QWVS/fZSTE2XwLCxZ8Vu7Arqee3dJTS43efVg3sAjvX/7Y0MzMhICI6RnXyxaK7nQL vPahL74BI0z3KsDv4MpgBqwBXugSopbp/SbiakgUkGRYDFyNrrk9eNR1QNdzfVLfxa Rn9/IZwY2QwIQ== Date: Sat, 12 Feb 2022 13:46:27 +0800 From: Shawn Guo To: Andrej Picej Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, kernel@pengutronix.de, leoyang.li@nxp.com, krzysztof.kozlowski@canonical.com, festevam@gmail.com, linux@rempel-privat.de, arnd@arndb.de, linux-imx@nxp.com, y.bas@phytec.de Subject: Re: [PATCH RESEND 3/4] ARM: dts: imx6ul: phycore: Change USB LDO voltage for usb compliance Message-ID: <20220212054627.GZ4909@dragon> References: <20220131080526.1171072-1-andrej.picej@norik.com> <20220131080526.1171072-4-andrej.picej@norik.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220131080526.1171072-4-andrej.picej@norik.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_214636_112400_638A0A1C X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 31, 2022 at 09:05:25AM +0100, Andrej Picej wrote: > From: Yunus Bas > > According to the NXP usb compliance reference, the USB data lines for > Full/Low speed are connected to the ARM USB LDO, which is set to > minimum-voltage = 2.6V and maximum-voltage = 3.4 V. When the regulator > is deactivated, the data lines are defaulty driven with 2.6V, which is > not USB Full-Speed compliant. To be compliant, we need to activate the > USB LDO regulator and set it to the value of 3V, which is the specified > value in the USB specification. > > Signed-off-by: Yunus Bas > Signed-off-by: Andrej Picej > --- > arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi > index 3cddc68917a0..2e03be3d43ec 100644 > --- a/arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi > +++ b/arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi > @@ -83,6 +83,11 @@ eeprom@52 { > }; > }; > > +®_3p0 { > + regulator-min-microvolt = <3000000>; > + regulator-always-on; Rather than setting it always-on, shouldn't the consumer of the regulator turn it on/off as needed? Shawn > +}; > + > &snvs_poweroff { > status = "okay"; > }; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel