* [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required
@ 2022-02-11 11:02 Sudeep Holla
2022-02-11 11:47 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sudeep Holla @ 2022-02-11 11:02 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Peng Fan, Dong Aisheng, Jacky Bai, Sudeep Holla,
linux-arm-kernel
The SCMI binding clearly states the value of #thermal-sensor-cells must
be 1. However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which
results in the following warning with dtbs_check:
| arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
| protocol@15:#thermal-sensor-cells:0:0: 1 was expected
| From schema: Documentation/devicetree/bindings/firmware/arm,scmi.yaml
Fix it by setting it to 1 as required.
Cc:Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
index a987ff7156bd..09f7364dd1d0 100644
--- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
@@ -132,7 +132,7 @@ scmi_devpd: protocol@11 {
scmi_sensor: protocol@15 {
reg = <0x15>;
- #thermal-sensor-cells = <0>;
+ #thermal-sensor-cells = <1>;
};
};
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required
2022-02-11 11:02 [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required Sudeep Holla
@ 2022-02-11 11:47 ` Fabio Estevam
2022-02-13 3:23 ` Peng Fan
2022-02-13 4:58 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-02-11 11:47 UTC (permalink / raw)
To: Sudeep Holla
Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
Peng Fan, Dong Aisheng, Jacky Bai,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Sudeep,
On Fri, Feb 11, 2022 at 8:02 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> The SCMI binding clearly states the value of #thermal-sensor-cells must
> be 1. However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which
> results in the following warning with dtbs_check:
>
> | arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
> | protocol@15:#thermal-sensor-cells:0:0: 1 was expected
> | From schema: Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>
> Fix it by setting it to 1 as required.
>
> Cc:Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required
2022-02-11 11:02 [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required Sudeep Holla
2022-02-11 11:47 ` Fabio Estevam
@ 2022-02-13 3:23 ` Peng Fan
2022-02-13 4:58 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2022-02-13 3:23 UTC (permalink / raw)
To: Sudeep Holla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, dl-linux-imx, Aisheng Dong, Jacky Bai,
linux-arm-kernel@lists.infradead.org
> Subject: [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as
> required
>
> The SCMI binding clearly states the value of #thermal-sensor-cells must be 1.
> However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which results
> in the following warning with dtbs_check:
>
> | arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
> | protocol@15:#thermal-sensor-cells:0:0: 1 was expected
> | From schema:
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>
> Fix it by setting it to 1 as required.
>
> Cc:Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index a987ff7156bd..09f7364dd1d0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -132,7 +132,7 @@ scmi_devpd: protocol@11 {
>
> scmi_sensor: protocol@15 {
> reg = <0x15>;
> - #thermal-sensor-cells = <0>;
> + #thermal-sensor-cells = <1>;
> };
> };
> };
> --
> 2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required
2022-02-11 11:02 [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required Sudeep Holla
2022-02-11 11:47 ` Fabio Estevam
2022-02-13 3:23 ` Peng Fan
@ 2022-02-13 4:58 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-02-13 4:58 UTC (permalink / raw)
To: Sudeep Holla
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Peng Fan, Dong Aisheng, Jacky Bai,
linux-arm-kernel
On Fri, Feb 11, 2022 at 11:02:04AM +0000, Sudeep Holla wrote:
> The SCMI binding clearly states the value of #thermal-sensor-cells must
> be 1. However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which
> results in the following warning with dtbs_check:
>
> | arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
> | protocol@15:#thermal-sensor-cells:0:0: 1 was expected
> | From schema: Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>
> Fix it by setting it to 1 as required.
>
> Cc:Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-13 5:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-11 11:02 [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required Sudeep Holla
2022-02-11 11:47 ` Fabio Estevam
2022-02-13 3:23 ` Peng Fan
2022-02-13 4:58 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).