From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 136CCC433F5 for ; Mon, 14 Feb 2022 22:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t0BcA6ugUF4r18cOxch5V6LHcmLap0wzTaQfzBhsJWk=; b=aofPQjijpf5wZr B+5s6f+6uwXhUGvEVaHsyrUhjtvi0+dum1ledpFhYS0dKn5R3ub48fUCiCCzQN6FUcyOCinq9a1Vf BwBB/j8RnrExFRPFx6xcOL4jGv14957lw3KlV91oovTz681pQiMrCtHtA4Vtv4DbYJh20axuZZ2OR HcG1C/t7Ws3JLpoJtMtsGpbEPk9JV7n+dx4oPm7wQtVBtAighxF2QYvpdsX5aR7Glxk3LtewzvsqM BwZMBwK/cduIixb1+kFeWiu+K0g/E0ZeBzzEKO6tmUI94jiLVf3AUz/9lNncPmoGXrAORVB/EuEZe Q6LJLhCAziTBo8OgQsuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJk6C-00HCzI-69; Mon, 14 Feb 2022 22:45:36 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJk67-00HCyB-Vi for linux-arm-kernel@lists.infradead.org; Mon, 14 Feb 2022 22:45:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bR7fehLtd9M9qTlT7VF3MZCfD/oznbKy8d/rqBxhceI=; b=b6x2pgLOdjZzH5KLlIZgvJyoXv GKkZ3K/n17R148WZDlU1eruFAgIM7qcQ0yNXDJgq+kpCvYb0IUdkgTZfYmAJINSaDOyqX0mYh9Lmj INu+sZAUB3/X7OsoDFup9tB0VoLt3zT08ktodD/o+h4VgRv0JGAFH6LrxWCGAVyFb2TM=; Received: from p200300ccff09cb001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff09:cb00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1nJk5u-00041L-DZ; Mon, 14 Feb 2022 23:45:18 +0100 Date: Mon, 14 Feb 2022 23:45:17 +0100 From: Andreas Kemnade To: Rob Herring Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alistair@alistair23.me, samuel@sholland.org, josua.mayer@jm0.eu, letux-kernel@openphoenux.org Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Message-ID: <20220214234517.121e1167@aktux> In-Reply-To: References: <20220206080016.796556-1-andreas@kemnade.info> <20220206080016.796556-2-andreas@kemnade.info> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_144532_239285_E5E6F26B X-CRM114-Status: GOOD ( 27.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, 11 Feb 2022 09:46:27 -0600 Rob Herring wrote: > On Sun, Feb 06, 2022 at 09:00:11AM +0100, Andreas Kemnade wrote: > > Add a binding for the Electrophoretic Display Controller found at least > > in the i.MX6. > > The first version was in i.MX50 (I helped design the register > interface). Is that version compatible? > it has some differences, but that could be detected by EPDC_VERSION register. I do not own such a device, so I cannot fully check. I have not seen any driver with devicetree for IMX5. For now I am rejecting anything which has a EPDC version which I cannot check. > > The timing subnode is directly here to avoid having display parameters > > spread all over the plate. > > > > Supplies are organized the same way as in the fbdev driver in the > > NXP/Freescale kernel forks. The regulators used for that purpose, > > like the TPS65185, the SY7636A and MAX17135 have typically a single bit to > > start a bunch of regulators of higher or negative voltage with a > > well-defined timing. VCOM can be handled separately, but can also be > > incorporated into that single bit. > > > > Signed-off-by: Andreas Kemnade > > --- > > .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++ > > 1 file changed, 159 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > new file mode 100644 > > index 000000000000..7e0795cc3f70 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > @@ -0,0 +1,159 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/imx/fsl,mxc-epdc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale i.MX6 EPDC > > + > > +maintainers: > > + - Andreas Kemnade > > + > > +description: | > > + The EPDC is a controller for handling electronic paper displays found in > > + i.MX6 SoCs. > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx6sl-epdc > > + - fsl,imx6sll-epdc > > Not compatible with each other? > differences are detectable by EPDC_VERSION register, so probably so problem. NXP/Freescale kernel uses fsl,imx6dl-epdc and fsl,imx7d-epdc (used also by imx6 devices with EPDC_VERSION = 3.0) in their drivers. fsl,imx6dl-epdc fsl,imx6sl-epdc fsl,imx6sll-epdc fsl,imx7d-epdc in their dtsis. But the general rule is to use as less as possible compatible strings if differences can be probed properly, so only one should be sufficient? Which one? Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel