From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50B3DC433EF for ; Tue, 15 Feb 2022 09:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iDJSBOeWRgJc68VF6AsT2ygOxwBz4kx+njYAJtp31wQ=; b=WsQPUbwUPQr4sK kGsgQ3V3TO5XP84NGhZvp2vAQI+BjhRd3GyAx+JH+Azcus2O8xVNABI3AHOjVCsL9qHHPeEXC0F0e JNW8zOL3bBGgXIC8yxDGAC9eSQ6nYB5vYN81+YHCxARL3hQ/q2KZWiz40js3zk6RRAqK0qUdg3p3L y6JSUerX1ht9YXoBME2BKrpXp3MvHIT+UlQAkgtUUOGbtkwvdOyVgx6L9b83rHh+yiQo3rGkC+2vz iL5Bd/fIWqYSlXaxgXt7zxrvytc8U7DL376dvWT/u+z7OawJKWAdHvqecTENt9SWo9Wf5hiQNDdO9 5Db9/2HvJek37OFD2TEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJtrn-001w2T-Vl; Tue, 15 Feb 2022 09:11:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJtrZ-001vvD-2d for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 09:11:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A78C11063; Tue, 15 Feb 2022 01:11:05 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE4E33F66F; Tue, 15 Feb 2022 01:11:03 -0800 (PST) Date: Tue, 15 Feb 2022 09:11:01 +0000 From: Cristian Marussi To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mst@redhat.com Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, peter.hilber@opensynergy.com, igor.skalkin@opensynergy.com, "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 3/8] firmware: arm_scmi: Add atomic mode support to virtio transport Message-ID: <20220215091046.GF2535@e120937-lin> References: <20220213195832.27932-1-cristian.marussi@arm.com> <20220213195832.27932-4-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220213195832.27932-4-cristian.marussi@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_011109_231230_6ADE22F5 X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 13, 2022 at 07:58:27PM +0000, Cristian Marussi wrote: > Add support for .mark_txdone and .poll_done transport operations to SCMI > VirtIO transport as pre-requisites to enable atomic operations. > > Add a Kernel configuration option to enable SCMI VirtIO transport polling > and atomic mode for selected SCMI transactions while leaving it default > disabled. > > Cc: "Michael S. Tsirkin" > Cc: Igor Skalkin > Cc: Peter Hilber > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Cristian Marussi > --- > v1 --> v2 > - shrinked spinlocked section within virtio_poll_done to exclude > virtqueue_poll > - removed poll_lock > - use vio channel refcount acquire/release logic when polling > - using new free_list accessors > - added new dedicated pending_lock to access pending_cmds_list > - fixed a few comments > > v0 --> v1 > - check for deferred_wq existence before queueing work to avoid > race at driver removal time > - changed mark_txdone decision-logic about message release > - fixed race while checking for msg polled from another thread > - using dedicated poll_status instead of poll_idx upper bits > - pick initial poll_idx earlier inside send_message to avoid missing > early replies > - removed F_NOTIFY mention in comment > - clearing xfer->priv on the IRQ tx path once message has been fetched > - added some store barriers > - updated some comments > --- > drivers/firmware/arm_scmi/Kconfig | 15 ++ > drivers/firmware/arm_scmi/driver.c | 9 +- > drivers/firmware/arm_scmi/virtio.c | 277 ++++++++++++++++++++++++++++- > 3 files changed, 291 insertions(+), 10 deletions(-) > Hi Michael, how do you feel about the current status of this patch and the previous two in this series about SCMI virtio polling support after the last fixes ? Could we start thinking about merging this series on the SCMI side, leaving aside for the next iteration the polling ABA-problem mitigation I proposed in the virtio core (wrap counters and new API to enable them) that is now in a distinct series ? (and probably needs more tests/perfs/feedback...) Thank you, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel