From: Will Deacon <will@kernel.org>
To: James Morse <james.morse@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <maz@kernel.org>, Shuah Khan <shuah@kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/3] arm64: insn: Add tests for aarch64_insn_gen_logical_immediate()
Date: Tue, 15 Feb 2022 15:55:26 +0000 [thread overview]
Message-ID: <20220215155525.GA8117@willie-the-truck> (raw)
In-Reply-To: <20220127162127.2391947-3-james.morse@arm.com>
On Thu, Jan 27, 2022 at 04:21:26PM +0000, James Morse wrote:
> Aarch64 has instructions to generate reasonably complicated 32 or 64
> bit masks from only 13 bits of information.
> aarch64_insn_gen_logical_immediate() has to created the immediate
> encoding by spotting the patterns in the 32 or 64 bit immediate.
>
> Despite attempts to validate or model this code, or use it as-is outside
> the kernel tree, bugs still exist.
>
> Add a self test module that tests this code in place against a golden
> set of values.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> arch/arm64/Kconfig.debug | 3 +
> arch/arm64/Makefile | 2 +
> arch/arm64/lib/Makefile | 2 +
> arch/arm64/lib/insn.c | 3 +
> arch/arm64/lib/test_insn.c | 90 ++++++++++++++++++++++
Can we put the new tests under tools/testing/selftests/arm64 as well,
please? It looks like there's precedence for having modules in there (e.g.
bpf_testmod.c).
In the meantime, I'll pick up patch 3.
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-15 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 16:21 [PATCH 0/3] arm64: insn: Generate 64 bit mask immediates correctly James Morse
2022-01-27 16:21 ` [PATCH 1/3] arm64: selftests: Generate all the possible logical immediates as a header James Morse
2022-01-28 2:47 ` kernel test robot
2022-01-27 16:21 ` [PATCH 2/3] arm64: insn: Add tests for aarch64_insn_gen_logical_immediate() James Morse
2022-02-15 15:55 ` Will Deacon [this message]
2022-01-27 16:21 ` [PATCH 3/3] arm64: insn: Generate 64 bit mask immediates correctly James Morse
2022-01-27 18:34 ` Marc Zyngier
2022-02-15 23:18 ` [PATCH 0/3] " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215155525.GA8117@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox